don't use variables from the future

2 months ago · 63fb3b06b3
2 changed files with 2 additions and 2 deletions
--- a/app/services/csv/lettings_log_csv_service.rb
+++ b/app/services/csv/lettings_log_csv_service.rb
@ -289,7 +289,7 @@ module Csv
        exact_match = options.find { |definition| definition.year == @year }
        next exact_match if exact_match

-        options.max_by(&:year)
+        options.select { |opt| opt.year < @year }.max_by(&:year)
      end
    end

--- a/app/services/csv/sales_log_csv_service.rb
+++ b/app/services/csv/sales_log_csv_service.rb
@ -184,7 +184,7 @@ module Csv
        exact_match = options.find { |definition| definition.year == @year }
        next exact_match if exact_match

-        options.max_by(&:year)
+        options.select { |opt| opt.year < @year }.max_by(&:year)
      end
    end