purged total units and added test for location create

app/controllers/schemes_controller.rb

@@ -113,7 +113,6 @@ private
                                                      :stock_owning_organisation_id,
                                                      :scheme_type,
                                                      :registered_under_care_act,
-                                                     :total_units,
                                                      :id,
                                                      :has_other_client_group,
                                                      :primary_client_group,

spec/factories/scheme.rb

@@ -5,7 +5,6 @@ FactoryBot.define do
     registered_under_care_act { Faker::Number.within(range: 0..1) }
     support_type { Faker::Number.within(range: 0..6) }
     scheme_type { 0 }
-    total_units { Faker::Number.number(digits: 2) }
     intended_stay { %w[M P S V X].sample }
     primary_client_group { %w[O H M L A G F B D E I S N R Q P X].sample }
     secondary_client_group { %w[O H M L A G F B D E I S N R Q P X].sample }

spec/requests/locations_controller_spec.rb

@@ -55,4 +55,13 @@ RSpec.describe LocationsController, type: :request do
       end
     end
   end
+
+  describe "#create" do
+    context "when not signed in" do
+      it "redirects to the sign in page" do
+        post "/schemes/1/location/create"
+        expect(response).to redirect_to("/account/sign-in")
+      end
+    end
+  end
 end

spec/requests/schemes_controller_spec.rb

@@ -536,7 +536,7 @@ RSpec.describe SchemesController, type: :request do
 
     context "when signed in as a data coordinator" do
       let(:user) { FactoryBot.create(:user, :data_coordinator) }
-      let(:params) { { scheme: { service_name: "testy", sensitive: "1", scheme_type: "Foyer", registered_under_care_act: "No", total_units: "1" } } }
+      let(:params) { { scheme: { service_name: "testy", sensitive: "1", scheme_type: "Foyer", registered_under_care_act: "No" } } }
 
       before do
         sign_in user
@@ -569,7 +569,7 @@ RSpec.describe SchemesController, type: :request do
     context "when signed in as a support user" do
       let(:organisation) { FactoryBot.create(:organisation) }
       let(:user) { FactoryBot.create(:user, :support) }
-      let(:params) { { scheme: { service_name: "testy", sensitive: "1", scheme_type: "Foyer", registered_under_care_act: "No", total_units: "1", organisation_id: organisation.id } } }
+      let(:params) { { scheme: { service_name: "testy", sensitive: "1", scheme_type: "Foyer", registered_under_care_act: "No", organisation_id: organisation.id } } }
 
       before do
         allow(user).to receive(:need_two_factor_authentication?).and_return(false)
@@ -600,7 +600,7 @@ RSpec.describe SchemesController, type: :request do
       end
 
       context "when required organisation id param is missing" do
-        let(:params) { { "scheme" => { "service_name" => "qweqwer", "sensitive" => "Yes", "organisation_id" => "", "scheme_type" => "Foyer", "registered_under_care_act" => "Yes – part registered as a care home", "total_units" => "1" } } }
+        let(:params) { { "scheme" => { "service_name" => "qweqwer", "sensitive" => "Yes", "organisation_id" => "", "scheme_type" => "Foyer", "registered_under_care_act" => "Yes – part registered as a care home" } } }
 
         it "displays the new page with an error message" do
           post "/schemes", params: params
@@ -780,7 +780,7 @@ RSpec.describe SchemesController, type: :request do
       end
 
       context "when updating details" do
-        let(:params) { { scheme: { service_name: "testy", sensitive: "1", scheme_type: "Foyer", registered_under_care_act: "No", total_units: "1", page: "details" } } }
+        let(:params) { { scheme: { service_name: "testy", sensitive: "1", scheme_type: "Foyer", registered_under_care_act: "No", page: "details" } } }
 
         it "renders confirm secondary group after successful update" do
           follow_redirect!
@@ -794,11 +794,10 @@ RSpec.describe SchemesController, type: :request do
           expect(scheme_to_update.reload.scheme_type).to eq("Foyer")
           expect(scheme_to_update.reload.sensitive).to eq("Yes")
           expect(scheme_to_update.reload.registered_under_care_act).to eq("No")
-          expect(scheme_to_update.reload.total_units).to eq(1)
         end
 
         context "when updating from check answers page" do
-          let(:params) { { scheme: { service_name: "testy", sensitive: "1", scheme_type: "Foyer", registered_under_care_act: "No", total_units: "1", page: "details", check_answers: "true" } } }
+          let(:params) { { scheme: { service_name: "testy", sensitive: "1", scheme_type: "Foyer", registered_under_care_act: "No", page: "details", check_answers: "true" } } }
 
           it "renders check answers page after successful update" do
             follow_redirect!
@@ -812,7 +811,6 @@ RSpec.describe SchemesController, type: :request do
             expect(scheme_to_update.reload.scheme_type).to eq("Foyer")
             expect(scheme_to_update.reload.sensitive).to eq("Yes")
             expect(scheme_to_update.reload.registered_under_care_act).to eq("No")
-            expect(scheme_to_update.reload.total_units).to eq(1)
           end
         end
       end
@@ -972,7 +970,6 @@ RSpec.describe SchemesController, type: :request do
                       sensitive: "1",
                       scheme_type: "Foyer",
                       registered_under_care_act: "No",
-                      total_units: "1",
                       page: "details",
                       organisation_id: another_organisation.id,
                       stock_owning_organisation_id: another_organisation.id } }
@@ -990,13 +987,12 @@ RSpec.describe SchemesController, type: :request do
           expect(scheme_to_update.reload.scheme_type).to eq("Foyer")
           expect(scheme_to_update.reload.sensitive).to eq("Yes")
           expect(scheme_to_update.reload.registered_under_care_act).to eq("No")
-          expect(scheme_to_update.reload.total_units).to eq(1)
           expect(scheme_to_update.reload.organisation_id).to eq(another_organisation.id)
           expect(scheme_to_update.reload.stock_owning_organisation_id).to eq(another_organisation.id)
         end
 
         context "when updating from check answers page" do
-          let(:params) { { scheme: { service_name: "testy", sensitive: "1", scheme_type: "Foyer", registered_under_care_act: "No", total_units: "1", page: "details", check_answers: "true" } } }
+          let(:params) { { scheme: { service_name: "testy", sensitive: "1", scheme_type: "Foyer", registered_under_care_act: "No", page: "details", check_answers: "true" } } }
 
           it "renders check answers page after successful update" do
             follow_redirect!
@@ -1010,7 +1006,6 @@ RSpec.describe SchemesController, type: :request do
             expect(scheme_to_update.reload.scheme_type).to eq("Foyer")
             expect(scheme_to_update.reload.sensitive).to eq("Yes")
             expect(scheme_to_update.reload.registered_under_care_act).to eq("No")
-            expect(scheme_to_update.reload.total_units).to eq(1)
           end
         end
       end