Browse Source
* CLDC-4325: Set date to 2026 * CLDC-4325: Fix sale information % tests I'm not sure why I turned off strict post 2026, it's wanted in the same scenarios as before as shown by the failing tests * CLDC-4325: Fix check answers spec * CLDC-4325: Fix old rake task tests * CLDC-4325: Fix sales soft validations * CLDC-4325: Fix collection resources controller spec * CLDC-4325: Only add noms and org to CSV row if prp in most cases this was done by default but some tests construct an invalid log * CLDC-4325: Fix lettings household validations spec * CLDC-4221: Add 2026 collection deadlines * CLDC-4325: Fix remaining model specs * CLDC-4325: Fix form controller spec * CLDC-4325: Fix hhmemb spec * CLDC-4325: Fix duplicate logs controller spec also introduce a new helper for a dynamic way of setting year * CLDC-4325: Fix sales BU validator spec * CLDC-4325: Fix check answers summary component * CLDC-4325: Remove 2024 rake * CLDC-4325: Use or later in all touched tests * CLDC-4325: Fix guidance helper spec * CLDC-4325: Run all tests now and in 2026 * CLDC-4325: Turn off 2026 override * CLDC-4325: Add a corresponding return to timecop missing one * CLDC-4325: Fix sales log spec in 2025 need to use let rather than let! so the timecop can run first * CLDC-4325: Fix lettings log derived spec in 2025 timecop required for the start dates to work * CLDC-4325: Turn the 2026 override on again * fixup! CLDC-4325: Fix check answers summary component * CLDC-4325: Delete recalculate_reasonpref_dontknow rake only needed for 2024 logs * fixup! CLDC-4325: Fix lettings household validations spec Co-authored-by: Oscar Richardson <116292912+oscar-richardson-softwire@users.noreply.github.com> * fixup! CLDC-4325: Fix sales log spec in 2025 * fixup! CLDC-4325: Fix sales log spec in 2025 * CLDC-4325: Make start controller spec not year specific * CLDC-4325: Run tests in current day * CLDC-4325: Run tests on 31st march * CLDC-4325: Run tests on 2nd april * CLDC-4325: Properly run tests on current day * fixup! CLDC-4325: Fix sales soft validations * fixup! CLDC-4325: Make start controller spec not year specific * CLDC-4325: Run tests on 31st march * CLDC-4325: Run tests on 1st april * CLDC-4325: Run tests on 2nd april * CLDC-4325: Revert time travel --------- Co-authored-by: Oscar Richardson <116292912+oscar-richardson-softwire@users.noreply.github.com>pull/3278/head
Samuel Young
3 months ago
committed by
GitHub
24 changed files with 1395 additions and 1162 deletions
@ -1,12 +0,0 @@ |
|||||||
desc "Bulk update logs with invalid rp_dontknow values" |
|
||||||
task recalculate_invalid_rpdontknow: :environment do |
|
||||||
validation_trigger_condition = "rp_dontknow = 1 AND (rp_homeless = 1 OR rp_insan_unsat = 1 OR rp_medwel = 1 OR rp_hardship = 1)" |
|
||||||
|
|
||||||
LettingsLog.filter_by_year(2024).where(validation_trigger_condition).find_each do |log| |
|
||||||
log.rp_dontknow = 0 |
|
||||||
|
|
||||||
unless log.save |
|
||||||
Rails.logger.info "Could not save changes to lettings log #{log.id}" |
|
||||||
end |
|
||||||
end |
|
||||||
end |
|
||||||
@ -1,207 +0,0 @@ |
|||||||
namespace :bulk_update do |
|
||||||
desc "Update logs with specific criteria and set manual_address_entry_selected to true" |
|
||||||
task update_manual_address_entry_selected: :environment do |
|
||||||
updated_lettings_logs_count = 0 |
|
||||||
lettings_postcode_fixed_count = 0 |
|
||||||
lettings_postcode_fixed_status_changed_count = 0 |
|
||||||
lettings_postcode_not_fixed_status_changed_count = 0 |
|
||||||
lettings_postcode_fixed_status_changed_ids = [] |
|
||||||
lettings_postcode_not_fixed_status_changed_ids = [] |
|
||||||
lettings_updated_without_issue = 0 |
|
||||||
|
|
||||||
updated_sales_logs_count = 0 |
|
||||||
sales_postcode_fixed_count = 0 |
|
||||||
sales_postcode_fixed_status_changed_count = 0 |
|
||||||
sales_postcode_not_fixed_status_changed_count = 0 |
|
||||||
sales_postcode_fixed_status_changed_ids = [] |
|
||||||
sales_postcode_not_fixed_status_changed_ids = [] |
|
||||||
sales_updated_without_issue = 0 |
|
||||||
|
|
||||||
lettings_logs = LettingsLog.filter_by_year(2024) |
|
||||||
.where(status: %w[in_progress completed]) |
|
||||||
.where(needstype: 1, manual_address_entry_selected: false, uprn: nil) |
|
||||||
.where("(address_line1 IS NOT NULL AND address_line1 != '') OR (address_line2 IS NOT NULL AND address_line2 != '') OR (town_or_city IS NOT NULL AND town_or_city != '') OR (county IS NOT NULL AND county != '') OR (postcode_full IS NOT NULL AND postcode_full != '')") |
|
||||||
|
|
||||||
lettings_logs.find_each do |log| |
|
||||||
status_pre_change = log.status |
|
||||||
log.manual_address_entry_selected = true |
|
||||||
if log.save |
|
||||||
updated_lettings_logs_count += 1 |
|
||||||
Rails.logger.info "manual_address_entry_selected updated for lettings log #{log.id}" |
|
||||||
else |
|
||||||
Rails.logger.info "Could not save manual_address_entry_selected changes to lettings log #{log.id} : #{log.errors.full_messages.join(', ')}" |
|
||||||
end |
|
||||||
|
|
||||||
postcode_fixed = false |
|
||||||
if log.postcode_full.nil? && log.address_line1 == log.address_line1_input |
|
||||||
log.postcode_full = log.postcode_full_input |
|
||||||
if log.save |
|
||||||
lettings_postcode_fixed_count += 1 |
|
||||||
Rails.logger.info "postcode_full updated by address_line1_input for lettings log #{log.id}" |
|
||||||
postcode_fixed = true |
|
||||||
else |
|
||||||
Rails.logger.info "Could not save postcode_full changes to lettings log #{log.id} : #{log.errors.full_messages.join(', ')}" |
|
||||||
end |
|
||||||
end |
|
||||||
|
|
||||||
if log.postcode_full.nil? && log.creation_method == "bulk upload" && log.address_line1 == log.address_line1_as_entered |
|
||||||
log.postcode_full = log.postcode_full_as_entered |
|
||||||
if log.save |
|
||||||
lettings_postcode_fixed_count += 1 |
|
||||||
Rails.logger.info "postcode_full updated by address_line1_as_entered for lettings log #{log.id}" |
|
||||||
postcode_fixed = true |
|
||||||
else |
|
||||||
Rails.logger.info "Could not save postcode_full changes to lettings log #{log.id} : #{log.errors.full_messages.join(', ')}" |
|
||||||
end |
|
||||||
end |
|
||||||
|
|
||||||
status_post_change = log.status |
|
||||||
if status_pre_change != status_post_change |
|
||||||
if postcode_fixed |
|
||||||
lettings_postcode_fixed_status_changed_count += 1 |
|
||||||
lettings_postcode_fixed_status_changed_ids << log.id |
|
||||||
else |
|
||||||
lettings_postcode_not_fixed_status_changed_count += 1 |
|
||||||
lettings_postcode_not_fixed_status_changed_ids << log.id |
|
||||||
end |
|
||||||
else |
|
||||||
lettings_updated_without_issue += 1 |
|
||||||
end |
|
||||||
end |
|
||||||
|
|
||||||
sales_logs = SalesLog.filter_by_year(2024) |
|
||||||
.where(status: %w[in_progress completed]) |
|
||||||
.where(manual_address_entry_selected: false, uprn: nil) |
|
||||||
.where("(address_line1 IS NOT NULL AND address_line1 != '') OR (address_line2 IS NOT NULL AND address_line2 != '') OR (town_or_city IS NOT NULL AND town_or_city != '') OR (county IS NOT NULL AND county != '') OR (postcode_full IS NOT NULL AND postcode_full != '')") |
|
||||||
|
|
||||||
sales_logs.find_each do |log| |
|
||||||
status_pre_change = log.status |
|
||||||
log.manual_address_entry_selected = true |
|
||||||
if log.save |
|
||||||
updated_sales_logs_count += 1 |
|
||||||
Rails.logger.info "manual_address_entry_selected updated for sales log #{log.id}" |
|
||||||
else |
|
||||||
Rails.logger.info "Could not save manual_address_entry_selected changes to sales log #{log.id} : #{log.errors.full_messages.join(', ')}" |
|
||||||
end |
|
||||||
|
|
||||||
postcode_fixed = false |
|
||||||
if log.postcode_full.nil? && log.address_line1 == log.address_line1_input |
|
||||||
log.postcode_full = log.postcode_full_input |
|
||||||
if log.save |
|
||||||
sales_postcode_fixed_count += 1 |
|
||||||
Rails.logger.info "postcode_full updated by address_line1_input for sales log #{log.id}" |
|
||||||
postcode_fixed = true |
|
||||||
else |
|
||||||
Rails.logger.info "Could not save postcode_full changes to sales log #{log.id} : #{log.errors.full_messages.join(', ')}" |
|
||||||
end |
|
||||||
end |
|
||||||
|
|
||||||
if log.postcode_full.nil? && log.creation_method == "bulk upload" && log.address_line1 == log.address_line1_as_entered |
|
||||||
log.postcode_full = log.postcode_full_as_entered |
|
||||||
if log.save |
|
||||||
sales_postcode_fixed_count += 1 |
|
||||||
Rails.logger.info "postcode_full updated by address_line1_as_entered for sales log #{log.id}" |
|
||||||
postcode_fixed = true |
|
||||||
else |
|
||||||
Rails.logger.info "Could not save postcode_full changes to sales log #{log.id} : #{log.errors.full_messages.join(', ')}" |
|
||||||
end |
|
||||||
end |
|
||||||
|
|
||||||
status_post_change = log.status |
|
||||||
if status_pre_change != status_post_change |
|
||||||
if postcode_fixed |
|
||||||
sales_postcode_fixed_status_changed_count += 1 |
|
||||||
sales_postcode_fixed_status_changed_ids << log.id |
|
||||||
else |
|
||||||
sales_postcode_not_fixed_status_changed_count += 1 |
|
||||||
sales_postcode_not_fixed_status_changed_ids << log.id |
|
||||||
end |
|
||||||
else |
|
||||||
sales_updated_without_issue += 1 |
|
||||||
end |
|
||||||
end |
|
||||||
|
|
||||||
puts "#{updated_lettings_logs_count} lettings logs were updated." |
|
||||||
puts "#{lettings_updated_without_issue} lettings logs were updated without issue." |
|
||||||
puts "#{lettings_postcode_fixed_count} lettings logs where postcode fix was applied." |
|
||||||
puts "#{lettings_postcode_fixed_status_changed_count} lettings logs with postcode fix and status changed." |
|
||||||
puts "#{lettings_postcode_not_fixed_status_changed_count} lettings logs without postcode fix and status changed." |
|
||||||
puts "IDs of lettings logs with postcode fix and status changed: [#{lettings_postcode_fixed_status_changed_ids.join(', ')}]" |
|
||||||
puts "IDs of lettings logs without postcode fix and status changed: [#{lettings_postcode_not_fixed_status_changed_ids.join(', ')}]" |
|
||||||
|
|
||||||
lettings_postcode_fixed_org_counts = LettingsLog.where(id: lettings_postcode_fixed_status_changed_ids).group(:owning_organisation_id).count |
|
||||||
lettings_postcode_fixed_org_counts.each do |org_id, count| |
|
||||||
puts "Org #{org_id}: #{count} logs with postcode fix and status changed." |
|
||||||
end |
|
||||||
|
|
||||||
lettings_postcode_not_fixed_org_counts = LettingsLog.where(id: lettings_postcode_not_fixed_status_changed_ids).group(:owning_organisation_id).count |
|
||||||
lettings_postcode_not_fixed_org_counts.each do |org_id, count| |
|
||||||
puts "Org #{org_id}: #{count} logs without postcode fix and status changed." |
|
||||||
end |
|
||||||
|
|
||||||
puts "#{updated_sales_logs_count} sales logs were updated." |
|
||||||
puts "#{sales_updated_without_issue} sales logs were updated without issue." |
|
||||||
puts "#{sales_postcode_fixed_count} sales logs where postcode fix was applied." |
|
||||||
puts "#{sales_postcode_fixed_status_changed_count} sales logs with postcode fix and status changed." |
|
||||||
puts "#{sales_postcode_not_fixed_status_changed_count} sales logs without postcode fix and status changed." |
|
||||||
puts "IDs of sales logs with postcode fix and status changed: [#{sales_postcode_fixed_status_changed_ids.join(', ')}]" |
|
||||||
puts "IDs of sales logs without postcode fix and status changed: [#{sales_postcode_not_fixed_status_changed_ids.join(', ')}]" |
|
||||||
|
|
||||||
sales_postcode_fixed_org_counts = SalesLog.where(id: sales_postcode_fixed_status_changed_ids).group(:owning_organisation_id).count |
|
||||||
sales_postcode_fixed_org_counts.each do |org_id, count| |
|
||||||
puts "Org #{org_id}: #{count} logs with postcode fix and status changed." |
|
||||||
end |
|
||||||
|
|
||||||
sales_postcode_not_fixed_org_counts = SalesLog.where(id: sales_postcode_not_fixed_status_changed_ids).group(:owning_organisation_id).count |
|
||||||
sales_postcode_not_fixed_org_counts.each do |org_id, count| |
|
||||||
puts "Org #{org_id}: #{count} logs without postcode fix and status changed." |
|
||||||
end |
|
||||||
end |
|
||||||
|
|
||||||
desc "Find logs to fix and update postcode_full if conditions are met" |
|
||||||
task update_postcode_full_preexisting_manual_entry_logs: :environment do |
|
||||||
updated_count = 0 |
|
||||||
fixed_count = 0 |
|
||||||
not_updated_count = 0 |
|
||||||
not_updated_ids = [] |
|
||||||
updated_but_not_fixed_ids = [] |
|
||||||
|
|
||||||
logs_to_fix = LettingsLog.filter_by_year(2024).where(manual_address_entry_selected: true, uprn: nil, status: "in_progress", postcode_full: nil, updated_at: Time.zone.parse("2025-03-19 16:00:00")..Time.zone.parse("2025-03-19 17:00:00")) |
|
||||||
|
|
||||||
logs_to_fix.find_each do |log| |
|
||||||
previous_version = log.versions[-2] |
|
||||||
previous_status = previous_version&.reify&.status |
|
||||||
|
|
||||||
if log.address_line1 == log.address_line1_input |
|
||||||
log.postcode_full = log.postcode_full_input |
|
||||||
elsif log.creation_method == "bulk upload" && log.address_line1 == log.address_line1_as_entered |
|
||||||
log.postcode_full = log.postcode_full_as_entered |
|
||||||
end |
|
||||||
|
|
||||||
if log.postcode_full.present? |
|
||||||
if log.save |
|
||||||
Rails.logger.info "Updated postcode_full for lettings log #{log.id}" |
|
||||||
updated_count += 1 |
|
||||||
if log.status == previous_status |
|
||||||
fixed_count += 1 |
|
||||||
else |
|
||||||
updated_but_not_fixed_ids << log.id |
|
||||||
end |
|
||||||
else |
|
||||||
Rails.logger.info "Could not save changes to lettings log #{log.id}: #{log.errors.full_messages.join(', ')}" |
|
||||||
not_updated_count += 1 |
|
||||||
not_updated_ids << log.id |
|
||||||
end |
|
||||||
else |
|
||||||
not_updated_count += 1 |
|
||||||
not_updated_ids << log.id |
|
||||||
end |
|
||||||
end |
|
||||||
|
|
||||||
puts "#{updated_count} logs updated." |
|
||||||
puts "#{fixed_count} logs fixed." |
|
||||||
puts "#{not_updated_count} logs not updated." |
|
||||||
puts "IDs of logs not updated: [#{not_updated_ids.join(', ')}]" |
|
||||||
puts "IDs of logs updated but not fixed: [#{updated_but_not_fixed_ids.join(', ')}]" |
|
||||||
end |
|
||||||
end |
|
||||||
@ -1,77 +0,0 @@ |
|||||||
require "rails_helper" |
|
||||||
require "rake" |
|
||||||
|
|
||||||
RSpec.describe "recalculate_invalid_reasonpref_dontknow" do |
|
||||||
include CollectionTimeHelper |
|
||||||
|
|
||||||
subject(:task) { Rake::Task["recalculate_invalid_rpdontknow"] } |
|
||||||
|
|
||||||
before do |
|
||||||
Rake.application.rake_require("tasks/recalculate_invalid_reasonpref_dontknow") |
|
||||||
Rake::Task.define_task(:environment) |
|
||||||
task.reenable |
|
||||||
Timecop.freeze(previous_collection_end_date) |
|
||||||
end |
|
||||||
|
|
||||||
after do |
|
||||||
Timecop.return |
|
||||||
end |
|
||||||
|
|
||||||
let(:invalid_logs) { create_list(:lettings_log, 5, :completed, :ignore_validation_errors, reasonpref: 1, rp_dontknow: 1, rp_homeless: 1, rp_insan_unsat: rand(2), rp_medwel: rand(2), rp_hardship: rand(2), updated_at: Time.zone.local(2024, 4, 2, 12, 0, 0), startdate: Time.zone.local(2024, rand(4..12), rand(1..30))) } |
|
||||||
let(:pre_2024_invalid_logs) do |
|
||||||
create_list(:lettings_log, 5, :completed, reasonpref: 1, rp_dontknow: 1, rp_homeless: 1, rp_insan_unsat: rand(2), rp_medwel: rand(2), rp_hardship: rand(2)).each do |log| |
|
||||||
log.startdate = Time.zone.local(rand(2021..2023), 4, 1) |
|
||||||
log.save!(validate: false) |
|
||||||
end |
|
||||||
end |
|
||||||
let(:valid_logs) { create_list(:lettings_log, 3, :completed, :ignore_validation_errors, reasonpref: 1, rp_dontknow: 0, rp_homeless: 1, rp_insan_unsat: 1, rp_medwel: rand(2), rp_hardship: rand(2), updated_at: Time.zone.local(2024, 4, 2, 12, 0, 0), startdate: Time.zone.local(2024, rand(4..12), rand(1..30))) } |
|
||||||
|
|
||||||
it "updates the logs from 2024/25 with invalid rp_dontknow values" do |
|
||||||
invalid_logs.each do |log| |
|
||||||
expect(log.reasonpref).to eq(1) |
|
||||||
expect(log.rp_dontknow).to eq(1) |
|
||||||
expect(log.rp_homeless).to eq(1) |
|
||||||
end |
|
||||||
task.invoke |
|
||||||
invalid_logs.each do |log| |
|
||||||
log.reload |
|
||||||
expect(log.reasonpref).to eq(1) |
|
||||||
expect(log.rp_dontknow).to eq(0) |
|
||||||
expect(log.rp_homeless).to eq(1) |
|
||||||
expect(log.updated_at).not_to eq(Time.zone.local(2024, 4, 2, 12, 0, 0)) |
|
||||||
end |
|
||||||
end |
|
||||||
|
|
||||||
it "does not update the logs pre 2024 with invalid rp_dontknow values" do |
|
||||||
pre_2024_invalid_logs.each do |log| |
|
||||||
expect(log.reasonpref).to eq(1) |
|
||||||
expect(log.rp_dontknow).to eq(1) |
|
||||||
expect(log.rp_homeless).to eq(1) |
|
||||||
end |
|
||||||
task.invoke |
|
||||||
pre_2024_invalid_logs.each do |log| |
|
||||||
log.reload |
|
||||||
expect(log.reasonpref).to eq(1) |
|
||||||
expect(log.rp_dontknow).to eq(1) |
|
||||||
expect(log.rp_homeless).to eq(1) |
|
||||||
end |
|
||||||
end |
|
||||||
|
|
||||||
it "does not update the logs with valid rp_dontknow values" do |
|
||||||
valid_logs.each do |log| |
|
||||||
expect(log.reasonpref).to eq(1) |
|
||||||
expect(log.rp_dontknow).to eq(0) |
|
||||||
expect(log.rp_homeless).to eq(1) |
|
||||||
expect(log.rp_insan_unsat).to eq(1) |
|
||||||
end |
|
||||||
task.invoke |
|
||||||
valid_logs.each do |log| |
|
||||||
log.reload |
|
||||||
expect(log.reasonpref).to eq(1) |
|
||||||
expect(log.rp_dontknow).to eq(0) |
|
||||||
expect(log.rp_homeless).to eq(1) |
|
||||||
expect(log.rp_insan_unsat).to eq(1) |
|
||||||
expect(log.updated_at).to eq(Time.zone.local(2024, 4, 2, 12, 0, 0)) |
|
||||||
end |
|
||||||
end |
|
||||||
end |
|
||||||
@ -1,218 +0,0 @@ |
|||||||
require "rails_helper" |
|
||||||
require "rake" |
|
||||||
|
|
||||||
RSpec.describe "update_manual_address_entry_selected_preexisting_logs_spec", type: :task do |
|
||||||
include CollectionTimeHelper |
|
||||||
|
|
||||||
before do |
|
||||||
Rake.application.rake_require("tasks/update_manual_address_entry_selected_prexisting_logs") |
|
||||||
Rake::Task.define_task(:environment) |
|
||||||
task.reenable |
|
||||||
Timecop.freeze(previous_collection_end_date) |
|
||||||
end |
|
||||||
|
|
||||||
after do |
|
||||||
Timecop.return |
|
||||||
end |
|
||||||
|
|
||||||
describe "bulk_update:update_manual_address_entry_selected" do |
|
||||||
let(:task) { Rake::Task["bulk_update:update_manual_address_entry_selected"] } |
|
||||||
|
|
||||||
let(:lettings_log_uprn_entered) do |
|
||||||
build(:lettings_log, :completed, startdate: Time.zone.local(2024, 6, 1), needstype: 1, manual_address_entry_selected: false) |
|
||||||
end |
|
||||||
|
|
||||||
let(:lettings_log_uprn_found) do |
|
||||||
build(:lettings_log, :completed, startdate: Time.zone.local(2024, 9, 1), needstype: 1, manual_address_entry_selected: false, address_line1_input: "1 Test Street", postcode_full_input: "SW1 1AA") |
|
||||||
end |
|
||||||
|
|
||||||
let(:lettings_log_address_fields_not_entered) do |
|
||||||
build(:lettings_log, :inprogress_without_address_fields, startdate: Time.zone.local(2024, 9, 1), needstype: 1) |
|
||||||
end |
|
||||||
|
|
||||||
let(:lettings_log_address_manually_entered) do |
|
||||||
build(:lettings_log, :completed_without_uprn, startdate: Time.zone.local(2024, 12, 1), needstype: 1) |
|
||||||
end |
|
||||||
|
|
||||||
let(:sales_log_uprn_entered) do |
|
||||||
build(:sales_log, :completed, saledate: Time.zone.local(2024, 12, 1), manual_address_entry_selected: false) |
|
||||||
end |
|
||||||
|
|
||||||
let(:sales_log_uprn_found) do |
|
||||||
build(:sales_log, :completed, saledate: Time.zone.local(2024, 7, 1), manual_address_entry_selected: false, address_line1_input: "1 Test Street", postcode_full_input: "SW1 1AA") |
|
||||||
end |
|
||||||
|
|
||||||
let(:sales_log_address_fields_not_entered) do |
|
||||||
build(:sales_log, :inprogress_without_address_fields, saledate: Time.zone.local(2024, 12, 30)) |
|
||||||
end |
|
||||||
|
|
||||||
let(:sales_log_address_manually_entered) do |
|
||||||
build(:sales_log, :completed_without_uprn, saledate: Time.zone.local(2024, 12, 30)) |
|
||||||
end |
|
||||||
|
|
||||||
context "when running the task" do |
|
||||||
context "when logs do not meet the criteria" do |
|
||||||
before do |
|
||||||
lettings_log_uprn_found.save!(validate: false) |
|
||||||
lettings_log_uprn_entered.save!(validate: false) |
|
||||||
lettings_log_address_fields_not_entered.save!(validate: false) |
|
||||||
|
|
||||||
sales_log_uprn_found.save!(validate: false) |
|
||||||
sales_log_uprn_entered.save!(validate: false) |
|
||||||
sales_log_address_fields_not_entered.save!(validate: false) |
|
||||||
end |
|
||||||
|
|
||||||
it "does not update logs with a UPRN entered" do |
|
||||||
task.invoke |
|
||||||
|
|
||||||
lettings_log_uprn_entered.reload |
|
||||||
sales_log_uprn_entered.reload |
|
||||||
|
|
||||||
expect(lettings_log_uprn_entered.manual_address_entry_selected).to be false |
|
||||||
expect(lettings_log_uprn_entered.uprn).to eq("10033558653") |
|
||||||
expect(sales_log_uprn_entered.manual_address_entry_selected).to be false |
|
||||||
expect(sales_log_uprn_entered.uprn).to eq("10033558653") |
|
||||||
end |
|
||||||
|
|
||||||
it "does not update logs with a UPRN found" do |
|
||||||
task.invoke |
|
||||||
|
|
||||||
lettings_log_uprn_found.reload |
|
||||||
sales_log_uprn_found.reload |
|
||||||
|
|
||||||
expect(lettings_log_uprn_found.manual_address_entry_selected).to be false |
|
||||||
expect(lettings_log_uprn_found.uprn).to eq("10033558653") |
|
||||||
expect(sales_log_uprn_found.manual_address_entry_selected).to be false |
|
||||||
expect(sales_log_uprn_found.uprn).to eq("10033558653") |
|
||||||
end |
|
||||||
|
|
||||||
it "does not update logs with no UPRN or address fields entered" do |
|
||||||
task.invoke |
|
||||||
|
|
||||||
lettings_log_address_fields_not_entered.reload |
|
||||||
sales_log_address_fields_not_entered.reload |
|
||||||
|
|
||||||
expect(lettings_log_address_fields_not_entered.manual_address_entry_selected).to be false |
|
||||||
expect(sales_log_address_fields_not_entered.manual_address_entry_selected).to be false |
|
||||||
end |
|
||||||
end |
|
||||||
|
|
||||||
context "when logs do meet the criteria" do |
|
||||||
before do |
|
||||||
lettings_log_address_manually_entered.manual_address_entry_selected = false |
|
||||||
lettings_log_address_manually_entered.save!(validate: false) |
|
||||||
|
|
||||||
sales_log_address_manually_entered.manual_address_entry_selected = false |
|
||||||
sales_log_address_manually_entered.save!(validate: false) |
|
||||||
end |
|
||||||
|
|
||||||
it "updates logs with an address manually entered" do |
|
||||||
expect(lettings_log_address_manually_entered.manual_address_entry_selected).to be false |
|
||||||
expect(lettings_log_address_manually_entered.address_line1).to eq("1 Test Street") |
|
||||||
expect(lettings_log_address_manually_entered.address_line2).to eq("Testville") |
|
||||||
expect(lettings_log_address_manually_entered.town_or_city).to eq("Testford") |
|
||||||
expect(lettings_log_address_manually_entered.postcode_full).to eq("SW1 1AA") |
|
||||||
|
|
||||||
expect(sales_log_address_manually_entered.manual_address_entry_selected).to be false |
|
||||||
expect(sales_log_address_manually_entered.address_line1).to eq("1 Test Street") |
|
||||||
expect(sales_log_address_manually_entered.address_line2).to eq("Testville") |
|
||||||
expect(sales_log_address_manually_entered.town_or_city).to eq("Testford") |
|
||||||
expect(sales_log_address_manually_entered.postcode_full).to eq("SW1 1AA") |
|
||||||
|
|
||||||
task.invoke |
|
||||||
|
|
||||||
lettings_log_address_manually_entered.reload |
|
||||||
sales_log_address_manually_entered.reload |
|
||||||
|
|
||||||
expect(lettings_log_address_manually_entered.manual_address_entry_selected).to be true |
|
||||||
expect(lettings_log_address_manually_entered.address_line1).to eq("1 Test Street") |
|
||||||
expect(lettings_log_address_manually_entered.address_line2).to eq("Testville") |
|
||||||
expect(lettings_log_address_manually_entered.town_or_city).to eq("Testford") |
|
||||||
expect(lettings_log_address_manually_entered.postcode_full).to eq("SW1 1AA") |
|
||||||
|
|
||||||
expect(sales_log_address_manually_entered.manual_address_entry_selected).to be true |
|
||||||
expect(sales_log_address_manually_entered.address_line1).to eq("1 Test Street") |
|
||||||
expect(sales_log_address_manually_entered.address_line2).to eq("Testville") |
|
||||||
expect(sales_log_address_manually_entered.town_or_city).to eq("Testford") |
|
||||||
expect(sales_log_address_manually_entered.postcode_full).to eq("SW1 1AA") |
|
||||||
end |
|
||||||
end |
|
||||||
end |
|
||||||
end |
|
||||||
|
|
||||||
describe "bulk_update:update_postcode_full_preexisting_manual_entry_logs" do |
|
||||||
let(:task) { Rake::Task["bulk_update:update_postcode_full_preexisting_manual_entry_logs"] } |
|
||||||
|
|
||||||
let(:lettings_log_to_fix) do |
|
||||||
build(:lettings_log, :inprogress_without_address_fields, startdate: Time.zone.local(2024, 6, 1), updated_at: Time.zone.parse("2025-03-19 16:30:00")) |
|
||||||
end |
|
||||||
|
|
||||||
let(:bu_lettings_log_to_fix) do |
|
||||||
build(:lettings_log, :inprogress_without_address_fields, startdate: Time.zone.local(2024, 6, 1), creation_method: "bulk upload", updated_at: Time.zone.parse("2025-03-19 16:30:00")) |
|
||||||
end |
|
||||||
|
|
||||||
let(:lettings_log_not_to_fix) do |
|
||||||
build(:lettings_log, :inprogress_without_address_fields, startdate: Time.zone.local(2024, 6, 1), updated_at: Time.zone.parse("2025-03-19 15:30:00")) |
|
||||||
end |
|
||||||
|
|
||||||
before do |
|
||||||
lettings_log_to_fix.manual_address_entry_selected = true |
|
||||||
lettings_log_to_fix.address_line1 = "1 Test Street" |
|
||||||
lettings_log_to_fix.address_line2 = "Testville" |
|
||||||
lettings_log_to_fix.town_or_city = "Testford" |
|
||||||
lettings_log_to_fix.postcode_full = nil |
|
||||||
lettings_log_to_fix.address_line1_input = "1 Test Street" |
|
||||||
lettings_log_to_fix.postcode_full_input = "SW1 2BB" |
|
||||||
lettings_log_to_fix.save!(validate: false) |
|
||||||
|
|
||||||
bu_lettings_log_to_fix.manual_address_entry_selected = true |
|
||||||
bu_lettings_log_to_fix.address_line1 = "1 Test Street" |
|
||||||
bu_lettings_log_to_fix.address_line2 = "Testville" |
|
||||||
bu_lettings_log_to_fix.town_or_city = "Testford" |
|
||||||
bu_lettings_log_to_fix.postcode_full = nil |
|
||||||
bu_lettings_log_to_fix.address_line1_as_entered = "1 Test Street" |
|
||||||
bu_lettings_log_to_fix.postcode_full_as_entered = "SW1 2BB" |
|
||||||
bu_lettings_log_to_fix.save!(validate: false) |
|
||||||
|
|
||||||
lettings_log_not_to_fix.postcode_full = nil |
|
||||||
lettings_log_not_to_fix.save!(validate: false) |
|
||||||
end |
|
||||||
|
|
||||||
context "when running the task" do |
|
||||||
it "updates logs that meet the criteria" do |
|
||||||
expect(lettings_log_to_fix.postcode_full).to be_nil |
|
||||||
expect(lettings_log_to_fix.address_line1).to eq("1 Test Street") |
|
||||||
expect(lettings_log_to_fix.address_line2).to eq("Testville") |
|
||||||
expect(lettings_log_to_fix.town_or_city).to eq("Testford") |
|
||||||
expect(lettings_log_to_fix.address_line1_input).to eq("1 Test Street") |
|
||||||
expect(lettings_log_to_fix.postcode_full_input).to eq("SW1 2BB") |
|
||||||
|
|
||||||
expect(bu_lettings_log_to_fix.postcode_full).to be_nil |
|
||||||
expect(bu_lettings_log_to_fix.address_line1_input).to be_nil |
|
||||||
expect(bu_lettings_log_to_fix.address_line1).to eq("1 Test Street") |
|
||||||
expect(bu_lettings_log_to_fix.address_line2).to eq("Testville") |
|
||||||
expect(bu_lettings_log_to_fix.town_or_city).to eq("Testford") |
|
||||||
expect(bu_lettings_log_to_fix.address_line1_as_entered).to eq("1 Test Street") |
|
||||||
expect(bu_lettings_log_to_fix.postcode_full_as_entered).to eq("SW1 2BB") |
|
||||||
|
|
||||||
task.invoke |
|
||||||
|
|
||||||
lettings_log_to_fix.reload |
|
||||||
bu_lettings_log_to_fix.reload |
|
||||||
|
|
||||||
expect(lettings_log_to_fix.postcode_full).to eq(lettings_log_to_fix.postcode_full_input) |
|
||||||
expect(lettings_log_to_fix.postcode_full).to eq("SW1 2BB") |
|
||||||
expect(bu_lettings_log_to_fix.postcode_full).to eq(bu_lettings_log_to_fix.postcode_full_as_entered) |
|
||||||
expect(bu_lettings_log_to_fix.postcode_full).to eq("SW1 2BB") |
|
||||||
end |
|
||||||
|
|
||||||
it "does not update logs that do not meet the criteria" do |
|
||||||
task.invoke |
|
||||||
|
|
||||||
lettings_log_not_to_fix.reload |
|
||||||
|
|
||||||
expect(lettings_log_not_to_fix.postcode_full).to be_nil |
|
||||||
end |
|
||||||
end |
|
||||||
end |
|
||||||
end |
|
||||||
File diff suppressed because it is too large
Load Diff
Loading…
Reference in new issue