Browse Source

feat: validate nulls last in bu

pull/2338/head
natdeanlewissoftwire 10 months ago
parent
commit
7082fe0969
  1. 4
      app/services/bulk_upload/lettings/year2024/row_parser.rb
  2. 3
      app/services/bulk_upload/sales/year2024/row_parser.rb

4
app/services/bulk_upload/lettings/year2024/row_parser.rb

@ -411,13 +411,13 @@ class BulkUpload::Lettings::Year2024::RowParser
validate :validate_all_charges_given, on: :after_log, if: proc { is_carehome.zero? }
validate :validate_address_option_found, on: :after_log
validate :validate_nulls, on: :after_log
validate :validate_uprn_exists_if_any_key_address_fields_are_blank, on: :after_log, unless: -> { supported_housing? }
validate :validate_incomplete_soft_validations, on: :after_log
validate :validate_nationality, on: :after_log
validate :validate_nulls, on: :after_log
def self.question_for_field(field)
QUESTIONS[field]
end

3
app/services/bulk_upload/sales/year2024/row_parser.rb

@ -453,7 +453,6 @@ class BulkUpload::Sales::Year2024::RowParser
validate :validate_buyer1_economic_status, on: :before_log
validate :validate_address_option_found, on: :after_log
validate :validate_buyer2_economic_status, on: :before_log
validate :validate_nulls, on: :after_log
validate :validate_valid_radio_option, on: :before_log
validate :validate_owning_org_data_given, on: :after_log
@ -474,6 +473,8 @@ class BulkUpload::Sales::Year2024::RowParser
validate :validate_nationality, on: :after_log
validate :validate_buyer_2_nationality, on: :after_log
validate :validate_nulls, on: :after_log
def self.question_for_field(field)
QUESTIONS[field]
end

Loading…
Cancel
Save