From 723fd8eba354b17af78d9b994b5325ef235c7771 Mon Sep 17 00:00:00 2001 From: Nat Dean-Lewis Date: Tue, 17 Mar 2026 10:20:10 +0000 Subject: [PATCH] CLDC-4297: clarify test naming --- spec/services/bulk_upload/sales/year2023/row_parser_spec.rb | 6 +++--- spec/services/bulk_upload/sales/year2024/row_parser_spec.rb | 6 +++--- spec/services/bulk_upload/sales/year2025/row_parser_spec.rb | 4 ++-- spec/services/bulk_upload/sales/year2026/row_parser_spec.rb | 4 ++-- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/spec/services/bulk_upload/sales/year2023/row_parser_spec.rb b/spec/services/bulk_upload/sales/year2023/row_parser_spec.rb index 874bc05f0..010820bdd 100644 --- a/spec/services/bulk_upload/sales/year2023/row_parser_spec.rb +++ b/spec/services/bulk_upload/sales/year2023/row_parser_spec.rb @@ -1334,7 +1334,7 @@ RSpec.describe BulkUpload::Sales::Year2023::RowParser do context "when mscharge is given, but is set to 0 for shared ownership" do let(:attributes) { valid_attributes.merge(field_114: "0") } - it "does not override variables correctly" do + it "does not override variables" do log = parser.log expect(log["has_mscharge"]).to eq(0) # no expect(log["mscharge"]).to be_nil @@ -1344,7 +1344,7 @@ RSpec.describe BulkUpload::Sales::Year2023::RowParser do context "when mscharge is given, but is set to 0 for discounted ownership" do let(:attributes) { valid_attributes.merge(field_7: "2", field_126: "0") } - it "does not override variables correctly" do + it "does not override variables" do log = parser.log expect(log["has_mscharge"]).to eq(0) # no expect(log["mscharge"]).to be_nil @@ -1354,7 +1354,7 @@ RSpec.describe BulkUpload::Sales::Year2023::RowParser do context "when mscharge is given, but is set to 0 for outright sale" do let(:attributes) { valid_attributes.merge(field_7: "3", field_135: "0") } - it "does not override variables correctly" do + it "does not override variables" do log = parser.log expect(log["has_mscharge"]).to eq(0) # no expect(log["mscharge"]).to be_nil diff --git a/spec/services/bulk_upload/sales/year2024/row_parser_spec.rb b/spec/services/bulk_upload/sales/year2024/row_parser_spec.rb index 984cc2f33..898a7feee 100644 --- a/spec/services/bulk_upload/sales/year2024/row_parser_spec.rb +++ b/spec/services/bulk_upload/sales/year2024/row_parser_spec.rb @@ -1973,7 +1973,7 @@ RSpec.describe BulkUpload::Sales::Year2024::RowParser do context "when mscharge is given, but is set to 0 for shared ownership" do let(:attributes) { valid_attributes.merge(field_112: "0") } - it "does not override variables correctly" do + it "does not override variables" do log = parser.log expect(log["has_mscharge"]).to eq(0) # no expect(log["mscharge"]).to be_nil @@ -1983,7 +1983,7 @@ RSpec.describe BulkUpload::Sales::Year2024::RowParser do context "when mscharge is given, but is set to 0 for discounted ownership" do let(:attributes) { valid_attributes.merge(field_8: "2", field_124: "0") } - it "does not override variables correctly" do + it "does not override variables" do log = parser.log expect(log["has_mscharge"]).to eq(0) # no expect(log["mscharge"]).to be_nil @@ -1993,7 +1993,7 @@ RSpec.describe BulkUpload::Sales::Year2024::RowParser do context "when mscharge is given, but is set to 0 for outright sale" do let(:attributes) { valid_attributes.merge(field_8: "3", field_131: "0") } - it "does not override variables correctly" do + it "does not override variables" do log = parser.log expect(log["has_mscharge"]).to eq(0) # no expect(log["mscharge"]).to be_nil diff --git a/spec/services/bulk_upload/sales/year2025/row_parser_spec.rb b/spec/services/bulk_upload/sales/year2025/row_parser_spec.rb index 523e55fbd..3fc282142 100644 --- a/spec/services/bulk_upload/sales/year2025/row_parser_spec.rb +++ b/spec/services/bulk_upload/sales/year2025/row_parser_spec.rb @@ -1885,7 +1885,7 @@ RSpec.describe BulkUpload::Sales::Year2025::RowParser do context "when mscharge is given, but is set to 0 for shared ownership" do let(:attributes) { valid_attributes.merge(field_94: "0") } - it "does not override variables correctly" do + it "does not override variables" do log = parser.log expect(log["has_mscharge"]).to eq(0) # no expect(log["mscharge"]).to be_nil @@ -1895,7 +1895,7 @@ RSpec.describe BulkUpload::Sales::Year2025::RowParser do context "when mscharge is given, but is set to 0 for discounted ownership" do let(:attributes) { valid_attributes.merge(field_8: "2", field_121: "0") } - it "does not override variables correctly" do + it "does not override variables" do log = parser.log expect(log["has_mscharge"]).to eq(0) # no expect(log["mscharge"]).to be_nil diff --git a/spec/services/bulk_upload/sales/year2026/row_parser_spec.rb b/spec/services/bulk_upload/sales/year2026/row_parser_spec.rb index eef90645b..56a424730 100644 --- a/spec/services/bulk_upload/sales/year2026/row_parser_spec.rb +++ b/spec/services/bulk_upload/sales/year2026/row_parser_spec.rb @@ -1947,7 +1947,7 @@ RSpec.describe BulkUpload::Sales::Year2026::RowParser do context "when mscharge is given, but is set to 0 for shared ownership" do let(:attributes) { valid_attributes.merge(field_125: "0") } - it "does not override variables correctly" do + it "does not override variables" do log = parser.log expect(log["has_mscharge"]).to eq(0) # no expect(log["mscharge"]).to be_nil @@ -1957,7 +1957,7 @@ RSpec.describe BulkUpload::Sales::Year2026::RowParser do context "when mscharge is given, but is set to 0 for discounted ownership" do let(:attributes) { valid_attributes.merge(field_8: "2", field_136: "0") } - it "does not override variables correctly" do + it "does not override variables" do log = parser.log expect(log["has_mscharge"]).to eq(0) # no expect(log["mscharge"]).to be_nil