From 74f264f6f3b07d2d98231f3e682cd8b887cbcd8e Mon Sep 17 00:00:00 2001
From: Arthur Campbell <51094020+arfacamble@users.noreply.github.com>
Date: Tue, 7 Mar 2023 16:29:08 +0000
Subject: [PATCH] change question and hint copy, create test file for question
 class (#1374)

---
 .../lettings/questions/offered_social_let.rb  |  4 +-
 .../questions/offered_social_let_spec.rb      | 44 +++++++++++++++++++
 2 files changed, 46 insertions(+), 2 deletions(-)
 create mode 100644 spec/models/form/lettings/questions/offered_social_let_spec.rb

diff --git a/app/models/form/lettings/questions/offered_social_let.rb b/app/models/form/lettings/questions/offered_social_let.rb
index d2658a8e6..c87ffb998 100644
--- a/app/models/form/lettings/questions/offered_social_let.rb
+++ b/app/models/form/lettings/questions/offered_social_let.rb
@@ -3,13 +3,13 @@ class Form::Lettings::Questions::OfferedSocialLet < ::Form::Question
     super
     @id = "offered"
     @check_answer_label = "Times previously offered since becoming available"
-    @header = "Since becoming available, how many times has the property been previously offered?"
+    @header = "How many times was the property offered between becoming vacant and this letting?"
     @type = "numeric"
     @width = 2
     @check_answers_card_number = 0
     @max = 150
     @min = 0
-    @hint_text = "If the property is being offered for let for the first time, enter 0."
+    @hint_text = "Do not include the offer that led to this letting.This is after the last tenancy ended. If the property is being offered for let for the first time, enter 0."
     @step = 1
   end
 end
diff --git a/spec/models/form/lettings/questions/offered_social_let_spec.rb b/spec/models/form/lettings/questions/offered_social_let_spec.rb
new file mode 100644
index 000000000..8a3622e02
--- /dev/null
+++ b/spec/models/form/lettings/questions/offered_social_let_spec.rb
@@ -0,0 +1,44 @@
+require "rails_helper"
+
+RSpec.describe Form::Lettings::Questions::OfferedSocialLet, type: :model do
+  subject(:question) { described_class.new(nil, nil, page) }
+
+  let(:page) { instance_double(Form::Page) }
+
+  it "has correct page" do
+    expect(question.page).to eq page
+  end
+
+  it "has the correct id" do
+    expect(question.id).to eq "offered"
+  end
+
+  it "has the correct header" do
+    expect(question.header).to eq "How many times was the property offered between becoming vacant and this letting?"
+  end
+
+  it "has the correct check_answer_label" do
+    expect(question.check_answer_label).to eq "Times previously offered since becoming available"
+  end
+
+  it "has the correct type" do
+    expect(question.type).to eq "numeric"
+  end
+
+  it "has the correct minimum and maximum values" do
+    expect(question.min).to eq 0
+    expect(question.max).to eq 150
+  end
+
+  it "has the correct step" do
+    expect(question.step).to eq 1
+  end
+
+  it "is not marked as derived" do
+    expect(question.derived?).to be false
+  end
+
+  it "has the correct hint_text" do
+    expect(question.hint_text).to eq "Do not include the offer that led to this letting.This is after the last tenancy ended. If the property is being offered for let for the first time, enter 0."
+  end
+end