CLDC-3676: lint

app/models/validations/household_validations.rb

@@ -179,5 +179,4 @@ private
   def tenant_is_economic_child?(economic_status)
     economic_status == 9
   end
-
 end

app/models/validations/property_validations.rb

@@ -93,7 +93,7 @@ module Validations::PropertyValidations
 
   # see also: this validation in sales/property_validations.rb
   def validate_la_is_active(record)
-    return unless record.startdate.present?
+    return if record.startdate.blank?
     return unless record.la
 
     la = LocalAuthority.england.find_by(code: record.la)

app/models/validations/sales/property_validations.rb

@@ -30,7 +30,7 @@ module Validations::Sales::PropertyValidations
 
   # see also: this validation in validations/property_validations.rb
   def validate_la_in_england(record)
-    return unless record.la.present?
+    return if record.la.blank?
     return if record.la.in?(LocalAuthority.england.pluck(:code))
 
     record.errors.add :la, I18n.t("validations.sales.property_information.la.not_in_england")

spec/models/validations/sales/soft_validations_spec.rb

@@ -644,14 +644,6 @@ RSpec.describe Validations::Sales::SoftValidations do
 
       expect(record).not_to be_grant_outside_common_range
     end
-
-    it "returns true for logs with other type" do
-      record.grant = 100_000
-      record.type = 9
-      record.saledate = current_collection_start_date
-
-      expect(record).to be_grant_outside_common_range
-    end
   end
 
   describe "#staircase_bought_above_fifty" do
@@ -804,7 +796,6 @@ RSpec.describe Validations::Sales::SoftValidations do
     end
   end
 
-
   describe "#buyer1_livein_wrong_for_ownership_type?" do
     context "when it's a shared ownership" do
       let(:record) { FactoryBot.build(:sales_log, ownershipsch: 1) }