Browse Source

Add min and max to numeric question partial

pull/21/head
Matthew Phelan 3 years ago
parent
commit
7a215965da
  1. 2
      app/views/questions/_numeric_question.html.erb
  2. 20
      spec/views/questions/_numeric_question.html.erb_spec.rb

2
app/views/questions/_numeric_question.html.erb

@ -1,4 +1,4 @@
<div class="govuk-form-group"> <div class="govuk-form-group">
<label for="numeric_input"><%= label %></label> <label for="numeric_input"><%= label %></label>
<input id="numeric_input" class="govuk-input govuk-input--width-20" type="number" /> <input id="numeric_input" class="govuk-input govuk-input--width-20" type="number" min=<%= minimum %> max=<%= maximum %> />
</div> </div>

20
spec/views/questions/_numeric_question.html.erb_spec.rb

@ -1,11 +1,25 @@
describe 'questions/_numeric_question.html.erb' do describe 'questions/_numeric_question.html.erb' do
context 'when given a label' do context 'when given a label and value constraints' do
let(:label) { "Test Label" } let(:label) { "Test Label" }
let(:min) { "1" }
let(:max) { "150" }
let(:locals) { {label: label, minimum: min, maximum: max} }
it 'displays a numeric entry field' do before(:each) do
render :partial => 'numeric_question', locals: { label: label } render :partial => 'numeric_question', locals: locals
end
it 'displays a numeric entry field with a label' do
expect(rendered).to have_selector('//input[@type="number"]') expect(rendered).to have_selector('//input[@type="number"]')
expect(rendered).to have_selector("//label[contains('#{label}')]") expect(rendered).to have_selector("//label[contains('#{label}')]")
end end
it 'validates for a given minimum input' do
expect(rendered).to have_selector("//input[@min=#{min}]")
end
it 'validates for a given maximum input' do
expect(rendered).to have_selector("//input[@max=#{max}]")
end
end end
end end
Loading…
Cancel
Save