From 83c99d89706c10b0cfc468e9de58f849353cfc1f Mon Sep 17 00:00:00 2001 From: Kat Date: Wed, 1 Jun 2022 14:35:35 +0100 Subject: [PATCH] extract enabled_questions outside of the invalidated_page_questions loop --- app/models/case_log.rb | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/models/case_log.rb b/app/models/case_log.rb index 3823cfdeb..576078eb8 100644 --- a/app/models/case_log.rb +++ b/app/models/case_log.rb @@ -448,9 +448,10 @@ private end def reset_not_routed_questions + enabled_questions = form.enabled_page_questions(self) + enabled_question_ids = enabled_questions.map(&:id) + form.invalidated_page_questions(self).each do |question| - enabled_questions = form.enabled_page_questions(self) - enabled_question_ids = enabled_questions.map(&:id) if %w[radio checkbox].include?(question.type) enabled_answer_options = enabled_question_ids.include?(question.id) ? enabled_questions.find { |q| q.id == question.id }.answer_options : {} current_answer_option_valid = enabled_answer_options.present? ? enabled_answer_options.key?(public_send(question.id).to_s) : false