Browse Source

Clear postcode known if postcode is getting cleared (#1447)

pull/1449/head
kosiakkatrina 2 years ago committed by GitHub
parent
commit
84a6fc6308
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 2
      app/services/imports/sales_logs_import_service.rb
  2. 26
      spec/services/imports/sales_logs_import_service_spec.rb

2
app/services/imports/sales_logs_import_service.rb

@ -191,6 +191,8 @@ module Imports
sales_log.errors.each do |error|
@logger.warn("Log #{sales_log.old_id}: Removing field #{error.attribute} from log triggering validation: #{error.type}")
attributes.delete(error.attribute.to_s)
attributes.delete("pcodenk") if error.attribute == :postcode_full
attributes.delete("ppcodenk") if error.attribute == :ppostcode_full
end
@logs_overridden << sales_log.old_id
save_sales_log(attributes, previous_status)

26
spec/services/imports/sales_logs_import_service_spec.rb

@ -448,6 +448,32 @@ RSpec.describe Imports::SalesLogsImportService do
end
end
context "and it has invalid postcodes" do
let(:sales_log_id) { "shared_ownership_sales_log" }
before do
sales_log_xml.at_xpath("//meta:status").content = "submitted-invalid"
sales_log_xml.at_xpath("//xmlns:Q14Postcode").content = "2AA" # postcode
end
it "intercepts the relevant validation error" do
expect(logger).to receive(:warn).with(/Enter a postcode in the correct format, for example AA1 1AA/)
expect { sales_log_service.send(:create_log, sales_log_xml) }
.not_to raise_error
end
it "clears out the invalid answers" do
allow(logger).to receive(:warn)
sales_log_service.send(:create_log, sales_log_xml)
sales_log = SalesLog.find_by(old_id: sales_log_id)
expect(sales_log).not_to be_nil
expect(sales_log.postcode_full).to be_nil
expect(sales_log.postcode_full).to be_nil
end
end
context "and it has an invalid record with invalid contracts exchange date" do
let(:sales_log_id) { "shared_ownership_sales_log" }

Loading…
Cancel
Save