CLDC-4071: revert user_details_html update

app/helpers/user_helper.rb

@@ -82,15 +82,11 @@ module UserHelper
 
     case attribute
     when "role"
-      if current_user.data_coordinator? || current_user.support?
+      current_user.data_coordinator? || current_user.support? ? edit_link("Select role", user, current_user) : "No role assigned"
-        edit_link("Select role", user, current_user)
-      else
-        "No role assigned"
-      end
     when "phone"
       edit_link("Enter telephone number", user, current_user)
     else
-      no_answer_provided_text
+      "No answer provided"
     end
   end
 
@@ -109,8 +105,4 @@ private
       class: "govuk-link govuk-link--no-visited-state",
     )
   end
-
-  def no_answer_provided_text
-    "No answer provided"
-  end
 end