Add field to views

app/controllers/users_controller.rb

@@ -76,9 +76,9 @@ private
 
   def user_params
     if @user == current_user
-      params.require(:user).permit(:email, :name, :password, :password_confirmation, :role, :is_dpo)
+      params.require(:user).permit(:email, :name, :password, :password_confirmation, :role, :is_dpo, :is_key_contact)
     else
-      params.require(:user).permit(:email, :name, :role, :is_dpo)
+      params.require(:user).permit(:email, :name, :role, :is_dpo, :is_key_contact)
     end
   end
 

app/views/users/edit.html.erb

@@ -34,6 +34,14 @@
         legend: { text: "Are #{current_user == @user ? "you" : "they"} a data protection officer?", size: "m" }
       %>
 
+      <%= f.govuk_collection_radio_buttons :is_key_contact,
+        [OpenStruct.new(id: false, name: "No"), OpenStruct.new(id: true, name: "Yes")],
+        :id,
+        :name,
+        inline: true,
+        legend: { text: "Are #{current_user == @user ? "you" : "they"} a key contact?", size: "m" }
+      %>
+
       <%= f.govuk_submit "Save changes" %>
     </div>
   </div>

app/views/users/new.html.erb

@@ -39,6 +39,14 @@
         legend: { text: "Are #{current_user == @user ? "you" : "they"} a data protection officer?", size: "m" }
       %>
 
+      <%= f.govuk_collection_radio_buttons :is_key_contact,
+        [OpenStruct.new(id: false, name: "No"), OpenStruct.new(id: true, name: "Yes")],
+        :id,
+        :name,
+        inline: true,
+        legend: { text: "Are #{current_user == @user ? "you" : "they"} a key contact?", size: "m" }
+      %>
+
       <%= f.govuk_submit "Continue" %>
     </div>
   </div>

app/views/users/show.html.erb

@@ -50,6 +50,12 @@
         row.value { @user.is_data_protection_officer? ? "Yes" : "No" }
         row.action(visually_hidden_text: "are #{current_user == @user ? "you" : "they"} a data protection officer?", href: edit_user_path, html_attributes: { "data-qa": "change-are-#{current_user == @user ? "you" : "they"}-a-data-protection-officer" })
       end %>
+
+      <%= summary_list.row do |row|
+        row.key { 'Key contact' }
+        row.value { @user.is_key_contact? ? "Yes" : "No" }
+        row.action(visually_hidden_text: "are #{current_user == @user ? "you" : "they"} a key contact?", href: edit_user_path, html_attributes: { "data-qa": "change-are-#{current_user == @user ? "you" : "they"}-a-key-contact" })
+      end %>
     <% end %>
   </div>
 </div>

spec/features/user_spec.rb

@@ -237,16 +237,21 @@ RSpec.describe "User Features" do
       expect(page).to have_title("Error")
     end
 
-    it "sets name, email, role and is_dpo" do
+    it "sets name, email, role, is_dpo and is_key_contact fields" do
       visit("users/new")
       fill_in("user[name]", with: "New User")
       fill_in("user[email]", with: "newuser@example.com")
       choose("user-role-data-provider-field")
       choose("user-is-dpo-true-field")
+      choose("user-is-key-contact-true-field")
       click_button("Continue")
-      expect(
+      expect(User.find_by(
-        User.find_by(name: "New User", email: "newuser@example.com", role: "data_provider", is_dpo: true),
+               name: "New User",
-      ).to be_a(User)
+               email: "newuser@example.com",
+               role: "data_provider",
+               is_dpo: true,
+               is_key_contact: true,
+             )).to be_a(User)
     end
 
     it "defaults to is_dpo false" do
@@ -274,10 +279,16 @@ RSpec.describe "User Features" do
       first(:link, "Change").click
       expect(page).to have_field("user[is_dpo]", with: true)
       choose("user-is-dpo-field")
+      choose("user-is-key-contact-true-field")
       fill_in("user[name]", with: "Updated new name")
       click_button("Save changes")
       expect(page).to have_title("Updated new name’s account")
-      expect(User.find_by(name: "Updated new name", role: "data_provider", is_dpo: false)).to be_a(User)
+      expect(User.find_by(
+               name: "Updated new name",
+               role: "data_provider",
+               is_dpo: false,
+               is_key_contact: true,
+             )).to be_a(User)
     end
   end
 end

spec/requests/users_controller_spec.rb

@@ -210,13 +210,14 @@ RSpec.describe UsersController, type: :request do
           expect(whodunnit_actor.id).to eq(user.id)
         end
 
-        context "when user changes email and dpo" do
+        context "when user changes email, dpo, key_contact" do
-          let(:params) { { id: user.id, user: { name: new_name, email: new_email, is_dpo: "true" } } }
+          let(:params) { { id: user.id, user: { name: new_name, email: new_email, is_dpo: "true", is_key_contact: "true" } } }
 
           it "allows changing email and dpo" do
             user.reload
             expect(user.email).to eq(new_email)
             expect(user.is_data_protection_officer?).to be true
+            expect(user.is_key_contact?).to be true
           end
         end
       end
@@ -399,12 +400,13 @@ RSpec.describe UsersController, type: :request do
         end
 
         context "when user changes email and dpo" do
-          let(:params) { { id: user.id, user: { name: new_name, email: new_email, is_dpo: "true" } } }
+          let(:params) { { id: user.id, user: { name: new_name, email: new_email, is_dpo: "true", is_key_contact: "true" } } }
 
           it "allows changing email and dpo" do
             user.reload
             expect(user.email).to eq(new_email)
             expect(user.is_data_protection_officer?).to be true
+            expect(user.is_key_contact?).to be true
           end
         end
 
@@ -443,14 +445,15 @@ RSpec.describe UsersController, type: :request do
               .to change { other_user.reload.versions.last.actor&.id }.from(nil).to(user.id)
           end
 
-          context "when user changes email and dpo" do
+          context "when user changes email, dpo, key_contact" do
-            let(:params) { { id: other_user.id, user: { name: new_name, email: new_email, is_dpo: "true" } } }
+            let(:params) { { id: other_user.id, user: { name: new_name, email: new_email, is_dpo: "true", is_key_contact: "true" } } }
 
-            it "allows changing email and dpo" do
+            it "allows changing email, dpo, key_contact" do
               patch "/users/#{other_user.id}", headers: headers, params: params
               other_user.reload
               expect(other_user.email).to eq(new_email)
               expect(other_user.is_data_protection_officer?).to be true
+              expect(other_user.is_key_contact?).to be true
             end
           end