CLDC-3858 Correctly set checkbox values (#2931)

* Set unselected checkbox options to 0

* Correct checkbox values for existing logs

* Update CSV fixtures

* Update if statements

* Update a test

app/controllers/form_controller.rb

@@ -155,9 +155,9 @@ private
 
       next unless question_params
 
-      if %w[checkbox validation_override].include?(question.type)
+      if question.type == "checkbox"
         question.answer_keys_without_dividers.each do |option|
-          result[option] = question_params.include?(option) ? 1 : 0
+          result[option] = 1 if question_params.include?(option)
         end
       elsif question.type != "date"
         result[question.id] = question_params
@@ -347,7 +347,7 @@ private
   end
 
   def question_missing_response?(responses_for_page, question)
-    if %w[checkbox validation_override].include?(question.type)
+    if question.type == "checkbox"
       answered = question.answer_keys_without_dividers.map do |option|
         session["fields"][option] = @log[option] = params[@log.log_type][question.id].include?(option) ? 1 : 0
         params[@log.log_type][question.id].exclude?(option)

app/models/derived_variables/lettings_log_variables.rb

@@ -142,6 +142,8 @@ module DerivedVariables::LettingsLogVariables
     end
 
     reset_address_fields! if is_supported_housing?
+
+    set_checkbox_values!
   end
 
 private
@@ -362,4 +364,17 @@ private
     return 2 if rent_type == 4
     return 3 if rent_type == 5
   end
+
+  def set_checkbox_values!
+    form.questions.select { |q| q.type == "checkbox" }.each do |question|
+      options = question.answer_keys_without_dividers
+      next unless options.any? { |option| self[option] == 1 }
+
+      options.each do |option|
+        if self[option].nil?
+          self[option] = 0
+        end
+      end
+    end
+  end
 end

lib/tasks/correct_checkbox_values.rake

@@ -0,0 +1,20 @@
+desc "Update BU reasonable preference and illness type checkbox values"
+task correct_checkbox_values: :environment do
+  any_reasonpref_selected = "rp_homeless = 1 OR rp_hardship = 1 OR rp_medwel = 1 OR rp_insan_unsat = 1 OR rp_dontknow = 1"
+  any_reasonpref_is_null = "rp_homeless IS NULL OR rp_hardship IS NULL OR rp_medwel IS NULL OR rp_insan_unsat IS NULL OR rp_dontknow IS NULL"
+
+  LettingsLog.filter_by_year(2024).where(reasonpref: 1).where(any_reasonpref_selected).where(any_reasonpref_is_null).find_each do |lettings_log|
+    unless lettings_log.save
+      Rails.logger.info("Failed to save reasonpref for LettingsLog with id #{lettings_log.id}: #{lettings_log.errors.full_messages}")
+    end
+  end
+
+  any_illness_selected = "illness_type_1 = 1 OR illness_type_2 = 1 OR illness_type_3 = 1 OR illness_type_4 = 1 OR illness_type_5 = 1 OR illness_type_6 = 1 OR illness_type_7 = 1 OR illness_type_8 = 1 OR illness_type_9 = 1 OR illness_type_10 = 1"
+  any_illness_is_null = "illness_type_1 IS NULL OR illness_type_2 IS NULL OR illness_type_3 IS NULL OR illness_type_4 IS NULL OR illness_type_5 IS NULL OR illness_type_6 IS NULL OR illness_type_7 IS NULL OR illness_type_8 IS NULL OR illness_type_9 IS NULL OR illness_type_10 IS NULL"
+
+  LettingsLog.filter_by_year(2024).where(illness: 1).where(any_illness_selected).where(any_illness_is_null).find_each do |lettings_log|
+    unless lettings_log.save
+      Rails.logger.info("Failed to save illness for LettingsLog with id #{lettings_log.id}: #{lettings_log.errors.full_messages}")
+    end
+  end
+end

spec/lib/tasks/correct_checkbox_values_spec.rb

@@ -0,0 +1,216 @@
+require "rails_helper"
+require "rake"
+
+RSpec.describe "correct_checkbox_values" do
+  describe ":correct_checkbox_values", type: :task do
+    subject(:task) { Rake::Task["correct_checkbox_values"] }
+
+    let(:organisation) { create(:organisation, rent_periods: [2]) }
+    let(:user) { create(:user, organisation:) }
+
+    before do
+      Rake.application.rake_require("tasks/correct_checkbox_values")
+      Rake::Task.define_task(:environment)
+      task.reenable
+    end
+
+    context "when the rake task is run" do
+      context "and any of the reasonable_preference_reason options are 1" do
+        let(:bulk_upload) { create(:bulk_upload, :lettings, year: 2024, rent_type_fix_status: BulkUpload.rent_type_fix_statuses[:not_applied]) }
+
+        it "sets the remaining options to 0" do
+          log = build(:lettings_log, :completed, reasonpref: 1, rp_homeless: 1, rp_hardship: nil, rp_medwel: nil, rp_insan_unsat: nil, rp_dontknow: nil,
+                                                 bulk_upload:, assigned_to: user)
+          log.save!(validate: false)
+          initial_updated_at = log.updated_at
+
+          task.invoke
+          log.reload
+
+          expect(log.updated_at).not_to eq(initial_updated_at)
+          expect(log.status).to eq("completed")
+          expect(log.rp_homeless).to be(1)
+          expect(log.rp_hardship).to be(0)
+          expect(log.rp_medwel).to be(0)
+          expect(log.rp_insan_unsat).to be(0)
+          expect(log.rp_dontknow).to be(0)
+        end
+
+        it "updates the reasonable preference reason values on a pending log" do
+          log = build(:lettings_log, :completed, status: "pending", reasonpref: 1, rp_homeless: 1, rp_hardship: nil, rp_medwel: 1, rp_insan_unsat: nil, rp_dontknow: nil, bulk_upload:, assigned_to: user)
+          log.save!(validate: false)
+          initial_updated_at = log.updated_at
+          expect(log.status).to eq("pending")
+
+          task.invoke
+          log.reload
+          expect(log.rp_homeless).to be(1)
+          expect(log.rp_hardship).to be(0)
+          expect(log.rp_medwel).to be(1)
+          expect(log.rp_insan_unsat).to be(0)
+          expect(log.rp_dontknow).to be(0)
+          expect(log.status).to eq("pending")
+          expect(log.updated_at).not_to eq(initial_updated_at)
+        end
+
+        it "does not update logs if all unselected reasonable preference reason are alredy 0" do
+          log = build(:lettings_log, :completed, reasonpref: 1, rp_homeless: 0, rp_hardship: 1, rp_medwel: 0, rp_insan_unsat: 0, rp_dontknow: 0, bulk_upload:, assigned_to: user)
+          log.save!(validate: false)
+          initial_updated_at = log.updated_at
+          expect(log.status).to eq("completed")
+
+          task.invoke
+          log.reload
+
+          expect(log.status).to eq("completed")
+          expect(log.updated_at).to eq(initial_updated_at)
+        end
+
+        it "updates the reasonable preference reason values if some of the checkbox values are nil" do
+          log = build(:lettings_log, :completed, status: "pending", reasonpref: 1, rp_homeless: 0, rp_hardship: nil, rp_medwel: 1, rp_insan_unsat: 0, rp_dontknow: 0, bulk_upload:, assigned_to: user)
+          log.save!(validate: false)
+          initial_updated_at = log.updated_at
+          expect(log.status).to eq("pending")
+
+          task.invoke
+          log.reload
+          expect(log.rp_homeless).to be(0)
+          expect(log.rp_hardship).to be(0)
+          expect(log.rp_medwel).to be(1)
+          expect(log.rp_insan_unsat).to be(0)
+          expect(log.rp_dontknow).to be(0)
+          expect(log.status).to eq("pending")
+          expect(log.updated_at).not_to eq(initial_updated_at)
+        end
+
+        it "does not update the reasonable preference reason values on a 2023 log" do
+          log = build(:lettings_log, :completed, startdate: Time.zone.local(2023, 6, 6), reasonpref: 1, rp_homeless: 0, rp_hardship: nil, rp_medwel: 1, rp_insan_unsat: 0, rp_dontknow: 0, bulk_upload:, assigned_to: user)
+          log.save!(validate: false)
+          initial_updated_at = log.updated_at
+
+          task.invoke
+          log.reload
+
+          expect(log.updated_at).to eq(initial_updated_at)
+        end
+
+        it "does not update and logs error if a validation triggers" do
+          log = build(:lettings_log, :completed, postcode_full: "0", reasonpref: 1, rp_homeless: 0, rp_hardship: nil, rp_medwel: 1, rp_insan_unsat: 0, rp_dontknow: 0, bulk_upload:, assigned_to: user)
+          log.save!(validate: false)
+          initial_updated_at = log.updated_at
+
+          task.invoke
+          log.reload
+
+          expect(log.updated_at).to eq(initial_updated_at)
+        end
+      end
+
+      context "and any of the illness_type options are 1" do
+        let(:bulk_upload) { create(:bulk_upload, :lettings, year: 2024, rent_type_fix_status: BulkUpload.rent_type_fix_statuses[:not_applied]) }
+
+        it "sets the remaining options to 0" do
+          log = build(:lettings_log, :completed, illness: 1, illness_type_1: 1, illness_type_2: nil, illness_type_3: nil, illness_type_4: nil, illness_type_5: nil, illness_type_6: nil, illness_type_7: nil, illness_type_8: nil, illness_type_9: nil, illness_type_10: nil,
+                                                 bulk_upload:, assigned_to: user)
+          log.save!(validate: false)
+          initial_updated_at = log.updated_at
+
+          task.invoke
+          log.reload
+
+          expect(log.updated_at).not_to eq(initial_updated_at)
+          expect(log.status).to eq("completed")
+          expect(log.illness_type_1).to be(1)
+          expect(log.illness_type_2).to be(0)
+          expect(log.illness_type_3).to be(0)
+          expect(log.illness_type_4).to be(0)
+          expect(log.illness_type_5).to be(0)
+          expect(log.illness_type_6).to be(0)
+          expect(log.illness_type_7).to be(0)
+          expect(log.illness_type_8).to be(0)
+          expect(log.illness_type_9).to be(0)
+          expect(log.illness_type_10).to be(0)
+        end
+
+        it "updates the reasonable preference reason values on a pending log" do
+          log = build(:lettings_log, :completed, status: "pending", illness: 1, illness_type_1: 1, illness_type_2: nil, illness_type_3: nil, illness_type_4: nil, illness_type_5: nil, illness_type_6: nil, illness_type_7: nil, illness_type_8: nil, illness_type_9: nil, illness_type_10: nil, bulk_upload:, assigned_to: user)
+          log.save!(validate: false)
+          initial_updated_at = log.updated_at
+          expect(log.status).to eq("pending")
+
+          task.invoke
+          log.reload
+          expect(log.illness_type_1).to be(1)
+          expect(log.illness_type_2).to be(0)
+          expect(log.illness_type_3).to be(0)
+          expect(log.illness_type_4).to be(0)
+          expect(log.illness_type_5).to be(0)
+          expect(log.illness_type_6).to be(0)
+          expect(log.illness_type_7).to be(0)
+          expect(log.illness_type_8).to be(0)
+          expect(log.illness_type_9).to be(0)
+          expect(log.illness_type_10).to be(0)
+          expect(log.status).to eq("pending")
+          expect(log.updated_at).not_to eq(initial_updated_at)
+        end
+
+        it "does not update logs if all unselected reasonable preference reason are alredy 0" do
+          log = build(:lettings_log, :completed, illness: 1, illness_type_1: 0, illness_type_2: 1, illness_type_3: 0, illness_type_4: 0, illness_type_5: 0, illness_type_6: 0, illness_type_7: 0, illness_type_8: 0, illness_type_9: 0, illness_type_10: 0, bulk_upload:, assigned_to: user)
+          log.save!(validate: false)
+          initial_updated_at = log.updated_at
+          expect(log.status).to eq("completed")
+
+          task.invoke
+          log.reload
+
+          expect(log.status).to eq("completed")
+          expect(log.updated_at).to eq(initial_updated_at)
+        end
+
+        it "updates the reasonable preference reason values if some of the checkbox values are nil" do
+          log = build(:lettings_log, :completed, status: "pending", illness: 1, illness_type_1: 0, illness_type_2: nil, illness_type_3: 1, illness_type_4: 0, illness_type_5: 0, illness_type_6: nil, illness_type_7: nil, illness_type_8: nil, illness_type_9: nil, illness_type_10: nil, bulk_upload:, assigned_to: user)
+          log.save!(validate: false)
+          initial_updated_at = log.updated_at
+          expect(log.status).to eq("pending")
+
+          task.invoke
+          log.reload
+          expect(log.illness_type_1).to be(0)
+          expect(log.illness_type_2).to be(0)
+          expect(log.illness_type_3).to be(1)
+          expect(log.illness_type_4).to be(0)
+          expect(log.illness_type_5).to be(0)
+          expect(log.illness_type_6).to be(0)
+          expect(log.illness_type_7).to be(0)
+          expect(log.illness_type_8).to be(0)
+          expect(log.illness_type_9).to be(0)
+          expect(log.illness_type_10).to be(0)
+          expect(log.status).to eq("pending")
+          expect(log.updated_at).not_to eq(initial_updated_at)
+        end
+
+        it "does not update the reasonable preference reason values on a 2023 log" do
+          log = build(:lettings_log, :completed, startdate: Time.zone.local(2023, 6, 6), illness: 1, illness_type_1: 0, illness_type_2: nil, illness_type_3: 1, illness_type_4: 0, illness_type_5: 0, illness_type_6: nil, illness_type_7: nil, illness_type_8: nil, illness_type_9: nil, illness_type_10: nil, bulk_upload:, assigned_to: user)
+          log.save!(validate: false)
+          initial_updated_at = log.updated_at
+
+          task.invoke
+          log.reload
+
+          expect(log.updated_at).to eq(initial_updated_at)
+        end
+
+        it "does not update and logs error if a validation triggers" do
+          log = build(:lettings_log, :completed, postcode_full: "0", illness: 1, illness_type_1: 0, illness_type_2: nil, illness_type_3: 1, illness_type_4: 0, illness_type_5: 0, illness_type_6: nil, illness_type_7: nil, illness_type_8: nil, illness_type_9: nil, illness_type_10: nil, bulk_upload:, assigned_to: user)
+          log.save!(validate: false)
+          initial_updated_at = log.updated_at
+
+          task.invoke
+          log.reload
+
+          expect(log.updated_at).to eq(initial_updated_at)
+        end
+      end
+    end
+  end
+end

spec/services/bulk_upload/lettings/year2024/row_parser_spec.rb

@@ -1246,6 +1246,32 @@ RSpec.describe BulkUpload::Lettings::Year2024::RowParser do
           expect(parser.errors[:field_111]).to be_present
         end
       end
+
+      context "when some reasonable preference options are seleceted" do
+        let(:attributes) { setup_section_params.merge({ bulk_upload:, field_106: "1", field_107: "1", field_108: nil, field_109: "1", field_110: nil, field_111: nil }) }
+
+        it "sets the rest of the options to 0" do
+          parser.valid?
+          expect(parser.log.rp_homeless).to eq(1)
+          expect(parser.log.rp_insan_unsat).to eq(0)
+          expect(parser.log.rp_medwel).to eq(1)
+          expect(parser.log.rp_hardship).to eq(0)
+          expect(parser.log.rp_dontknow).to eq(0)
+        end
+      end
+
+      context "when some reasonable preference options are seleceted but reasonpref is No" do
+        let(:attributes) { setup_section_params.merge({ bulk_upload:, field_106: "2", field_107: "1", field_108: nil, field_109: "1", field_110: nil, field_111: nil }) }
+
+        it "sets the options to nil" do
+          parser.valid?
+          expect(parser.log.rp_homeless).to be_nil
+          expect(parser.log.rp_insan_unsat).to be_nil
+          expect(parser.log.rp_medwel).to be_nil
+          expect(parser.log.rp_hardship).to be_nil
+          expect(parser.log.rp_dontknow).to be_nil
+        end
+      end
     end
 
     describe "#field_116" do # referral
@@ -2484,6 +2510,42 @@ RSpec.describe BulkUpload::Lettings::Year2024::RowParser do
           end
         end
       end
+
+      context "when some illness type values are seleceted" do
+        let(:attributes) { setup_section_params.merge({ bulk_upload:, field_85: "1", field_94: "1", field_87: "1" }) }
+
+        it "sets the rest of the values to 0" do
+          parser.valid?
+          expect(parser.log.illness_type_1).to eq(1)
+          expect(parser.log.illness_type_2).to eq(0)
+          expect(parser.log.illness_type_3).to eq(0)
+          expect(parser.log.illness_type_4).to eq(0)
+          expect(parser.log.illness_type_5).to eq(1)
+          expect(parser.log.illness_type_6).to eq(0)
+          expect(parser.log.illness_type_7).to eq(0)
+          expect(parser.log.illness_type_8).to eq(0)
+          expect(parser.log.illness_type_9).to eq(0)
+          expect(parser.log.illness_type_10).to eq(0)
+        end
+      end
+
+      context "when none of the illness type values are seleceted" do
+        let(:attributes) { setup_section_params.merge({ bulk_upload:, field_85: "1" }) }
+
+        it "sets the values to nil" do
+          parser.valid?
+          expect(parser.log.illness_type_1).to be_nil
+          expect(parser.log.illness_type_2).to be_nil
+          expect(parser.log.illness_type_3).to be_nil
+          expect(parser.log.illness_type_4).to be_nil
+          expect(parser.log.illness_type_5).to be_nil
+          expect(parser.log.illness_type_6).to be_nil
+          expect(parser.log.illness_type_7).to be_nil
+          expect(parser.log.illness_type_8).to be_nil
+          expect(parser.log.illness_type_9).to be_nil
+          expect(parser.log.illness_type_10).to be_nil
+        end
+      end
     end
 
     describe "#irproduct_other" do