From 89b6522bc2a1516bd969c2f1ab415604a5aa1073 Mon Sep 17 00:00:00 2001 From: Kat Date: Mon, 28 Mar 2022 09:57:35 +0100 Subject: [PATCH] Switch order in if statement --- app/models/validations/financial_validations.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/models/validations/financial_validations.rb b/app/models/validations/financial_validations.rb index 782de55c7..64703ff7a 100644 --- a/app/models/validations/financial_validations.rb +++ b/app/models/validations/financial_validations.rb @@ -122,7 +122,7 @@ private %i[scharge pscharge supcharg].each do |charge| maximum = CHARGE_MAXIMUMS.dig(charge, LANDLORD_VALUES[record.landlord], NEEDSTYPE_VALUES[record.needstype]) - if maximum.present? && !weekly_value_in_range(record, charge, 0, maximum) && record[charge].present? + if maximum.present? && record[charge].present? && !weekly_value_in_range(record, charge, 0, maximum) record.errors.add charge, I18n.t("validations.financial.rent.#{charge}.#{LANDLORD_VALUES[record.landlord]}.#{NEEDSTYPE_VALUES[record.needstype]}") end end