From 8bac9a1bc46ea52d5d6cb08f4e03365f4beed365 Mon Sep 17 00:00:00 2001
From: Manny Dinssa <44172848+Dinssa@users.noreply.github.com>
Date: Wed, 19 Mar 2025 08:09:25 +0000
Subject: [PATCH] Try to prevent flaky test behaviour

---
 ...te_manual_address_entry_selected_prexisting_logs_spec.rb | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/spec/lib/tasks/update_manual_address_entry_selected_prexisting_logs_spec.rb b/spec/lib/tasks/update_manual_address_entry_selected_prexisting_logs_spec.rb
index a2e079256..4268b66c9 100644
--- a/spec/lib/tasks/update_manual_address_entry_selected_prexisting_logs_spec.rb
+++ b/spec/lib/tasks/update_manual_address_entry_selected_prexisting_logs_spec.rb
@@ -13,7 +13,7 @@ RSpec.describe "bulk_update:update_manual_address_entry_selected", type: :task d
   end
 
   let(:lettings_log_address_manually_entered) do
-    build(:lettings_log, :completed_without_uprn, startdate: Time.zone.local(2024, 12, 1), needstype: 1, manual_address_entry_selected: false)
+    build(:lettings_log, :completed_without_uprn, startdate: Time.zone.local(2024, 12, 1), needstype: 1)
   end
 
   let(:sales_log_uprn_entered) do
@@ -25,7 +25,7 @@ RSpec.describe "bulk_update:update_manual_address_entry_selected", type: :task d
   end
 
   let(:sales_log_address_manually_entered) do
-    build(:sales_log, :completed_without_uprn, saledate: Time.zone.local(2024, 12, 30), manual_address_entry_selected: false)
+    build(:sales_log, :completed_without_uprn, saledate: Time.zone.local(2024, 12, 30))
   end
 
   before do
@@ -65,7 +65,9 @@ RSpec.describe "bulk_update:update_manual_address_entry_selected", type: :task d
 
     context "when logs do meet the criteria" do
       before do
+        lettings_log_address_manually_entered.manual_address_entry_selected = false
         lettings_log_address_manually_entered.save!(validate: false)
+        sales_log_address_manually_entered.manual_address_entry_selected = false
         sales_log_address_manually_entered.save!(validate: false)
       end