diff --git a/app/helpers/numeric_questions_helper.rb b/app/helpers/numeric_questions_helper.rb index 0a8889d04..464f42723 100644 --- a/app/helpers/numeric_questions_helper.rb +++ b/app/helpers/numeric_questions_helper.rb @@ -5,7 +5,7 @@ module NumericQuestionsHelper { "data-controller": "numeric-question", "data-action": "numeric-question#calculateFields", - "data-affected": "#{question['result-field'].to_s.dasherize}-field", + "data-target": "#{question['result-field'].to_s.dasherize}-field", "data-calculated": question["fields-to-add"].to_json, } end diff --git a/app/javascript/controllers/numeric_question_controller.js b/app/javascript/controllers/numeric_question_controller.js index 479aa5e32..6a0a58d78 100644 --- a/app/javascript/controllers/numeric_question_controller.js +++ b/app/javascript/controllers/numeric_question_controller.js @@ -2,7 +2,7 @@ import { Controller } from "@hotwired/stimulus" export default class extends Controller { calculateFields() { - const affectedField = this.element.dataset.affected; + const affectedField = this.element.dataset.target; const fieldsToAdd = JSON.parse(this.element.dataset.calculated).map(x => `${x.replaceAll("_","-")}-field`); const valuesToAdd = fieldsToAdd.map(x => document.getElementById(x).value).filter(x => x); const newValue = valuesToAdd.map(x => parseInt(x)).reduce((a, b) => a + b, 0); diff --git a/spec/helpers/numeric_questions_helper_spec.rb b/spec/helpers/numeric_questions_helper_spec.rb index 0d5436983..48877babe 100644 --- a/spec/helpers/numeric_questions_helper_spec.rb +++ b/spec/helpers/numeric_questions_helper_spec.rb @@ -13,7 +13,7 @@ RSpec.describe NumericQuestionsHelper do expect(numeric_question_html_attributes(questions["basic_rent"])).to eq({ "data-controller": "numeric-question", "data-action": "numeric-question#calculateFields", - "data-affected": "#{questions['basic_rent']['result-field'].to_s.dasherize}-field", + "data-target": "#{questions['basic_rent']['result-field'].to_s.dasherize}-field", "data-calculated": questions["basic_rent"]["fields-to-add"].to_json, }) end