Browse Source

Remove unnecessary updates

pull/2818/head
Kat 8 months ago
parent
commit
8ca60bfa21
  1. 4
      spec/features/lettings_log_spec.rb
  2. 8
      spec/features/sales_log_spec.rb
  3. 1
      spec/features/schemes_spec.rb
  4. 2
      spec/helpers/tab_nav_helper_spec.rb
  5. 1
      spec/requests/merge_requests_controller_spec.rb

4
spec/features/lettings_log_spec.rb

@ -286,10 +286,6 @@ RSpec.describe "Lettings Log Features" do
context "when reviewing a complete log" do
let(:lettings_log) { create(:lettings_log, :completed) }
before do
lettings_log.owning_organisation.update!(name: "MHCLG")
end
it "has the correct breadcrumbs with the correct links" do
visit review_lettings_log_path(lettings_log)
breadcrumbs = page.find_all(".govuk-breadcrumbs__link")

8
spec/features/sales_log_spec.rb

@ -253,10 +253,6 @@ RSpec.describe "Sales Log Features" do
end
context "when visiting a subsection check answers page as a support user" do
before do
sales_log.owning_organisation.update!(name: "MHCLG")
end
it "has the correct breadcrumbs with the correct links" do
visit sales_log_setup_check_answers_path(sales_log.id)
breadcrumbs = page.find_all(".govuk-breadcrumbs__link")
@ -271,10 +267,6 @@ RSpec.describe "Sales Log Features" do
end
context "when reviewing a complete log" do
before do
sales_log.owning_organisation.update!(name: "MHCLG")
end
it "has the correct breadcrumbs with the correct links" do
visit review_sales_log_path(sales_log.id, sales_log: true)
breadcrumbs = page.find_all(".govuk-breadcrumbs__link")

1
spec/features/schemes_spec.rb

@ -197,7 +197,6 @@ RSpec.describe "Schemes scheme Features" do
context "when I visit schemes page" do
before do
user.organisation.update!(name: "MHCLG")
visit("schemes")
end

2
spec/helpers/tab_nav_helper_spec.rb

@ -1,7 +1,7 @@
require "rails_helper"
RSpec.describe TabNavHelper do
let(:organisation) { FactoryBot.create(:organisation, name: "MHCLG") }
let(:organisation) { FactoryBot.create(:organisation) }
let(:current_user) { FactoryBot.build(:user, organisation:) }
let(:scheme) { FactoryBot.create(:scheme, service_name: "Some name") }
let(:location) { FactoryBot.create(:location, scheme:) }

1
spec/requests/merge_requests_controller_spec.rb

@ -12,7 +12,6 @@ RSpec.describe MergeRequestsController, type: :request do
context "when user is signed in with a support user" do
before do
organisation.update!(name: "MHCLG")
allow(support_user).to receive(:need_two_factor_authentication?).and_return(false)
sign_in support_user
end

Loading…
Cancel
Save