Browse Source

Display `you didnt answer this question for unanswered questions

pull/228/head
Kat 4 years ago
parent
commit
8cd784691b
  1. 10
      app/helpers/check_answers_helper.rb
  2. 6
      app/models/form/question.rb
  3. 2
      app/views/form/_check_answers_table.html.erb
  4. 5
      spec/requests/case_log_controller_spec.rb

10
app/helpers/check_answers_helper.rb

@ -12,6 +12,16 @@ module CheckAnswersHelper
end
end
def get_answer_label(question, case_log)
answer = ActionController::Base.helpers.number_to_currency(question.answer_label(case_log), delimiter: ",", format: "%n")
if answer.present?
[question.prefix, answer, question.suffix].join("")
else
"<span class=\"app-!-colour-muted\">You didn’t answer this question</span>".html_safe
end
end
private
def create_next_missing_question_link(subsection, case_log)

6
app/models/form/question.rb

@ -33,12 +33,6 @@ class Form::Question
delegate :subsection, to: :page
delegate :form, to: :subsection
def get_answer_label(case_log)
answer = ActionController::Base.helpers.number_to_currency(answer_label(case_log), delimiter: ",", format: "%n")
answer.present? ? [prefix, answer, suffix].join("") : ""
end
def answer_label(case_log)
return checkbox_answer_label(case_log) if type == "checkbox"
return case_log[id].strftime("%d %b %Y") if type == "date"

2
app/views/form/_check_answers_table.html.erb

@ -3,7 +3,7 @@
<%= question.check_answer_label.to_s.present? ? question.check_answer_label.to_s : question.header.to_s %>
<dt>
<dd class="govuk-summary-list__value">
<%= question.get_answer_label(@case_log) %><br/>
<%= get_answer_label(question, @case_log) %><br/>
<% question.get_inferred_answers(@case_log).each do |inferred_answer| %>
<span class="govuk-!-font-weight-regular app-!-colour-muted"><%= inferred_answer %></span><br/>
<% end %>

5
spec/requests/case_log_controller_spec.rb

@ -278,6 +278,11 @@ RSpec.describe CaseLogsController, type: :request do
get "/logs/#{id}/property-information/check-answers"
expect(CGI.unescape_html(response.body)).to include("Not known")
end
it "shows `you haven't answered this question` if the question wasn't answered" do
get "/logs/#{id}/income-and-benefits/check-answers"
expect(CGI.unescape_html(response.body)).to include("You didn’t answer this question")
end
end
end

Loading…
Cancel
Save