From 8f7b6d17b6d4e26946655325f7157a727cd43859 Mon Sep 17 00:00:00 2001 From: Nat Dean-Lewis Date: Wed, 4 Feb 2026 11:04:57 +0000 Subject: [PATCH 1/2] CLDC-4177: remove frozen string literals --- app/models/form/sales/pages/person_sex_registered_at_birth.rb | 2 -- app/models/form/sales/pages/sex_registered_at_birth1.rb | 2 -- app/models/form/sales/pages/sex_registered_at_birth2.rb | 2 -- .../form/sales/questions/person_sex_registered_at_birth.rb | 2 -- app/models/form/sales/questions/sex_registered_at_birth1.rb | 2 -- app/models/form/sales/questions/sex_registered_at_birth2.rb | 2 -- 6 files changed, 12 deletions(-) diff --git a/app/models/form/sales/pages/person_sex_registered_at_birth.rb b/app/models/form/sales/pages/person_sex_registered_at_birth.rb index 807afe9b0..b2ea1da20 100644 --- a/app/models/form/sales/pages/person_sex_registered_at_birth.rb +++ b/app/models/form/sales/pages/person_sex_registered_at_birth.rb @@ -1,5 +1,3 @@ -# frozen_string_literal: true - class Form::Sales::Pages::PersonSexRegisteredAtBirth < ::Form::Page def initialize(id, hsh, subsection, person_index:) super(id, hsh, subsection) diff --git a/app/models/form/sales/pages/sex_registered_at_birth1.rb b/app/models/form/sales/pages/sex_registered_at_birth1.rb index 0990f3932..4e6f012a9 100644 --- a/app/models/form/sales/pages/sex_registered_at_birth1.rb +++ b/app/models/form/sales/pages/sex_registered_at_birth1.rb @@ -1,5 +1,3 @@ -# frozen_string_literal: true - class Form::Sales::Pages::SexRegisteredAtBirth1 < ::Form::Page def initialize(id, hsh, subsection) super diff --git a/app/models/form/sales/pages/sex_registered_at_birth2.rb b/app/models/form/sales/pages/sex_registered_at_birth2.rb index 74cf4034c..49ce339c4 100644 --- a/app/models/form/sales/pages/sex_registered_at_birth2.rb +++ b/app/models/form/sales/pages/sex_registered_at_birth2.rb @@ -1,5 +1,3 @@ -# frozen_string_literal: true - class Form::Sales::Pages::SexRegisteredAtBirth2 < ::Form::Page def initialize(id, hsh, subsection) super diff --git a/app/models/form/sales/questions/person_sex_registered_at_birth.rb b/app/models/form/sales/questions/person_sex_registered_at_birth.rb index fdc5ce3db..86bef9acd 100644 --- a/app/models/form/sales/questions/person_sex_registered_at_birth.rb +++ b/app/models/form/sales/questions/person_sex_registered_at_birth.rb @@ -1,5 +1,3 @@ -# frozen_string_literal: true - class Form::Sales::Questions::PersonSexRegisteredAtBirth < ::Form::Question def initialize(id, hsh, page, person_index:) super(id, hsh, page) diff --git a/app/models/form/sales/questions/sex_registered_at_birth1.rb b/app/models/form/sales/questions/sex_registered_at_birth1.rb index a1a659753..77a8e3fc3 100644 --- a/app/models/form/sales/questions/sex_registered_at_birth1.rb +++ b/app/models/form/sales/questions/sex_registered_at_birth1.rb @@ -1,5 +1,3 @@ -# frozen_string_literal: true - class Form::Sales::Questions::SexRegisteredAtBirth1 < ::Form::Question def initialize(id, hsh, page) super diff --git a/app/models/form/sales/questions/sex_registered_at_birth2.rb b/app/models/form/sales/questions/sex_registered_at_birth2.rb index 45edb3775..9a26d527a 100644 --- a/app/models/form/sales/questions/sex_registered_at_birth2.rb +++ b/app/models/form/sales/questions/sex_registered_at_birth2.rb @@ -1,5 +1,3 @@ -# frozen_string_literal: true - class Form::Sales::Questions::SexRegisteredAtBirth2 < ::Form::Question def initialize(id, hsh, page) super From 506c241cad334205d84aeeb8bdf682865b243a76 Mon Sep 17 00:00:00 2001 From: oscar-richardson-softwire Date: Wed, 4 Feb 2026 11:12:15 +0000 Subject: [PATCH 2/2] Delete redundant migration --- ...0203142107_enforce_lowercase_for_sex_rab_columns.rb | 10 ---------- 1 file changed, 10 deletions(-) delete mode 100644 db/migrate/20260203142107_enforce_lowercase_for_sex_rab_columns.rb diff --git a/db/migrate/20260203142107_enforce_lowercase_for_sex_rab_columns.rb b/db/migrate/20260203142107_enforce_lowercase_for_sex_rab_columns.rb deleted file mode 100644 index 7d2fb4e3e..000000000 --- a/db/migrate/20260203142107_enforce_lowercase_for_sex_rab_columns.rb +++ /dev/null @@ -1,10 +0,0 @@ -class EnforceLowercaseForSexRabColumns < ActiveRecord::Migration[7.2] - def change - rename_column :sales_logs, :"sexRAB1", :sexrab1 - rename_column :sales_logs, :"sexRAB2", :sexrab2 - rename_column :sales_logs, :"sexRAB3", :sexrab3 - rename_column :sales_logs, :"sexRAB4", :sexrab4 - rename_column :sales_logs, :"sexRAB5", :sexrab5 - rename_column :sales_logs, :"sexRAB6", :sexrab6 - end -end