From 8f0be6d63248eea0ce7086051f984289d8a973ec Mon Sep 17 00:00:00 2001 From: JG Date: Thu, 30 Jun 2022 07:14:24 +0100 Subject: [PATCH] flashing test rubocop --- app/controllers/schemes_controller.rb | 2 +- spec/requests/schemes_controller_spec.rb | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/controllers/schemes_controller.rb b/app/controllers/schemes_controller.rb index cd9065e05..4dd657534 100644 --- a/app/controllers/schemes_controller.rb +++ b/app/controllers/schemes_controller.rb @@ -7,7 +7,7 @@ class SchemesController < ApplicationController before_action :authenticate_scope! def index - flash[:notice] = ("#{Scheme.find(params[:scheme_id].to_i).service_name} has been created.") if params[:scheme_id] + flash[:notice] = "#{Scheme.find(params[:scheme_id].to_i).service_name} has been created." if params[:scheme_id] redirect_to schemes_organisation_path(current_user.organisation) unless current_user.support? all_schemes = Scheme.all diff --git a/spec/requests/schemes_controller_spec.rb b/spec/requests/schemes_controller_spec.rb index 0d2cfb75e..30cba5cf2 100644 --- a/spec/requests/schemes_controller_spec.rb +++ b/spec/requests/schemes_controller_spec.rb @@ -37,7 +37,7 @@ RSpec.describe SchemesController, type: :request do get "/schemes" end - context "params scheme_id is present" do + context "when params scheme_id is present" do it "shows a success banner" do get "/schemes", params: { scheme_id: schemes.first.id } follow_redirect! @@ -85,7 +85,7 @@ RSpec.describe SchemesController, type: :request do expect(CGI.unescape_html(response.body)).to include(expected_field) end - context "params scheme_id is present" do + context "when params scheme_id is present" do it "shows a success banner" do get "/schemes", params: { scheme_id: schemes.first.id } expect(page).to have_css(".govuk-notification-banner.govuk-notification-banner--success")