From 95f863c94e75fee06978dd0f2e8e4265e502cf9b Mon Sep 17 00:00:00 2001 From: Kat Date: Mon, 3 Apr 2023 16:14:21 +0100 Subject: [PATCH] Fix remaining uprn --- .../form/lettings/questions/uprn_confirmation_spec.rb | 6 ++++-- spec/models/form/sales/questions/uprn_confirmation_spec.rb | 7 +++++-- spec/models/form/sales/questions/uprn_spec.rb | 3 ++- 3 files changed, 11 insertions(+), 5 deletions(-) diff --git a/spec/models/form/lettings/questions/uprn_confirmation_spec.rb b/spec/models/form/lettings/questions/uprn_confirmation_spec.rb index 3c409641d..2bf34e4a9 100644 --- a/spec/models/form/lettings/questions/uprn_confirmation_spec.rb +++ b/spec/models/form/lettings/questions/uprn_confirmation_spec.rb @@ -50,7 +50,7 @@ RSpec.describe Form::Lettings::Questions::UprnConfirmation, type: :model do context "when address is present" do it "returns formatted value" do - log = create(:lettings_log, address_line1: "1, Test Street", town_or_city: "Test Town", county: "Test County", postcode_full: "AA1 1AA", uprn: "1234") + log = create(:lettings_log, address_line1: "1, Test Street", town_or_city: "Test Town", county: "Test County", postcode_full: "AA1 1AA", uprn: "1234", uprn_known: 1) expect(question.notification_banner(log)).to eq( { @@ -80,9 +80,11 @@ RSpec.describe Form::Lettings::Questions::UprnConfirmation, type: :model do end context "when uprn_known != 1 && uprn_confirmed == 1" do - let(:log) { create(:lettings_log, uprn_known: 1, uprn_confirmed: 1) } + let(:log) { create(:lettings_log) } it "returns true" do + log.uprn_known = 1 + log.uprn_confirmed = 1 expect(question.hidden_in_check_answers?(log)).to eq(true) end end diff --git a/spec/models/form/sales/questions/uprn_confirmation_spec.rb b/spec/models/form/sales/questions/uprn_confirmation_spec.rb index 2bb986fcd..27f8ec125 100644 --- a/spec/models/form/sales/questions/uprn_confirmation_spec.rb +++ b/spec/models/form/sales/questions/uprn_confirmation_spec.rb @@ -50,7 +50,7 @@ RSpec.describe Form::Sales::Questions::UprnConfirmation, type: :model do context "when address is present" do it "returns formatted value" do - log = create(:sales_log, address_line1: "1, Test Street", town_or_city: "Test Town", county: "Test County", postcode_full: "AA1 1AA", uprn: "1234") + log = create(:sales_log, address_line1: "1, Test Street", town_or_city: "Test Town", county: "Test County", postcode_full: "AA1 1AA", uprn: "1234", uprn_known: 1) expect(question.notification_banner(log)).to eq( { @@ -72,9 +72,12 @@ RSpec.describe Form::Sales::Questions::UprnConfirmation, type: :model do end context "when uprn_known == 1 && uprn_confirmed == nil" do - let(:log) { create(:sales_log, uprn_known: 1, uprn: "12345", uprn_confirmed: nil) } + let(:log) { create(:sales_log) } it "returns false" do + log.uprn_known = 1 + log.uprn = "12345" + log.uprn_confirmed = nil expect(question.hidden_in_check_answers?(log)).to eq(false) end end diff --git a/spec/models/form/sales/questions/uprn_spec.rb b/spec/models/form/sales/questions/uprn_spec.rb index 50e575445..f8fd75942 100644 --- a/spec/models/form/sales/questions/uprn_spec.rb +++ b/spec/models/form/sales/questions/uprn_spec.rb @@ -74,9 +74,10 @@ RSpec.describe Form::Sales::Questions::Uprn, type: :model do describe "has the correct hidden_in_check_answers" do context "when uprn_known == 1" do - let(:log) { create(:sales_log, uprn_known: 1) } + let(:log) { create(:sales_log) } it "returns false" do + log.uprn_known = 1 expect(question.hidden_in_check_answers?(log)).to eq(false) end end