Add tests

spec/models/form/sales/subsections/household_situation_spec.rb

@@ -25,6 +25,14 @@ RSpec.describe Form::Sales::Subsections::HouseholdSituation, type: :model do
         ],
       )
     end
+
+    it "has the correct id" do
+      expect(household_characteristics.id).to eq("household_situation")
+    end
+
+    it "has the correct label" do
+      expect(household_characteristics.label).to eq("Household situation")
+    end
   end
 
   context "when the start year is 2025" do
@@ -41,17 +49,9 @@ RSpec.describe Form::Sales::Subsections::HouseholdSituation, type: :model do
         ],
       )
     end
-  end
 
-  it "has the correct id" do
+    it "has correct depends on" do
-    expect(household_characteristics.id).to eq("household_situation")
+      expect(household_characteristics.depends_on).to eq([{ "setup_completed?" => true, "is_staircase?" => false }])
-  end
+    end
-
-  it "has the correct label" do
-    expect(household_characteristics.label).to eq("Household situation")
-  end
-
-  it "has correct depends on" do
-    expect(household_characteristics.depends_on).to eq([{ "setup_completed?" => true }])
   end
 end

spec/models/form/sales/subsections/income_benefits_and_savings_spec.rb

@@ -11,8 +11,16 @@ RSpec.describe Form::Sales::Subsections::IncomeBenefitsAndSavings, type: :model
     expect(subsection.section).to eq(section)
   end
 
+  it "has the correct id" do
+    expect(subsection.id).to eq("income_benefits_and_savings")
+  end
+
+  it "has the correct label" do
+    expect(subsection.label).to eq("Income, benefits and savings")
+  end
+
   describe "pages" do
-    let(:section) { instance_double(Form::Sales::Sections::Household, form: instance_double(Form, start_date:)) }
+    let(:section) { instance_double(Form::Sales::Sections::Household, form: instance_double(Form, start_date:, start_year_2025_or_later?: false)) }
 
     context "when 2022" do
       let(:start_date) { Time.utc(2022, 2, 8) }
@@ -83,18 +91,19 @@ RSpec.describe Form::Sales::Subsections::IncomeBenefitsAndSavings, type: :model
           ],
         )
       end
-    end
-  end
 
-  it "has the correct id" do
+      it "has correct depends on" do
-    expect(subsection.id).to eq("income_benefits_and_savings")
+        expect(subsection.depends_on).to eq([{ "setup_completed?" => true }])
+      end
+    end
   end
 
-  it "has the correct label" do
+  context "when 2025" do
-    expect(subsection.label).to eq("Income, benefits and savings")
+    let(:start_date) { Time.utc(2025, 2, 8) }
-  end
+    let(:section) { instance_double(Form::Sales::Sections::Household, form: instance_double(Form, start_date:, start_year_2025_or_later?: true)) }
 
-  it "has correct depends on" do
+    it "has correct depends on" do
-    expect(subsection.depends_on).to eq([{ "setup_completed?" => true }])
+      expect(subsection.depends_on).to eq([{ "setup_completed?" => true, "is_staircase?" => false }])
+    end
   end
 end

spec/models/form/sales/subsections/other_household_information_spec.rb

@@ -5,36 +5,48 @@ RSpec.describe Form::Sales::Subsections::OtherHouseholdInformation, type: :model
 
   let(:subsection_id) { nil }
   let(:subsection_definition) { nil }
-  let(:form) { instance_double(Form, start_date: Time.zone.local(2024, 4, 1)) }
-  let(:section) { instance_double(Form::Sales::Sections::Household, form:) }
 
-  it "has correct section" do
+  context "when 2024" do
-    expect(household_characteristics.section).to eq(section)
+    let(:form) { instance_double(Form, start_date: Time.zone.local(2024, 4, 1), start_year_2025_or_later?: false) }
-  end
+    let(:section) { instance_double(Form::Sales::Sections::Household, form:) }
 
-  it "has correct pages" do
+    it "has correct section" do
-    expect(household_characteristics.pages.map(&:id)).to eq(
+      expect(household_characteristics.section).to eq(section)
-      %w[
+    end
-        armed_forces
-        buyer_still_serving
-        armed_forces_spouse
-        household_disability
-        disability_wheelchair_check
-        household_wheelchair
-        wheelchair_check
-      ],
-    )
-  end
 
-  it "has the correct id" do
+    it "has correct pages" do
-    expect(household_characteristics.id).to eq("other_household_information")
+      expect(household_characteristics.pages.map(&:id)).to eq(
-  end
+        %w[
+          armed_forces
+          buyer_still_serving
+          armed_forces_spouse
+          household_disability
+          disability_wheelchair_check
+          household_wheelchair
+          wheelchair_check
+        ],
+      )
+    end
 
-  it "has the correct label" do
+    it "has the correct id" do
-    expect(household_characteristics.label).to eq("Other household information")
+      expect(household_characteristics.id).to eq("other_household_information")
+    end
+
+    it "has the correct label" do
+      expect(household_characteristics.label).to eq("Other household information")
+    end
+
+    it "has correct depends on" do
+      expect(household_characteristics.depends_on).to eq([{ "setup_completed?" => true }])
+    end
   end
 
-  it "has correct depends on" do
+  context "when 2025" do
-    expect(household_characteristics.depends_on).to eq([{ "setup_completed?" => true }])
+    let(:form) { instance_double(Form, start_date: Time.zone.local(2025, 4, 1), start_year_2025_or_later?: true) }
+    let(:section) { instance_double(Form::Sales::Sections::Household, form:) }
+
+    it "has correct depends on" do
+      expect(household_characteristics.depends_on).to eq([{ "setup_completed?" => true, "is_staircase?" => false }])
+    end
   end
 end