From 99630f74255d71fff487cb49307600c7c80b3afd Mon Sep 17 00:00:00 2001
From: kosiakkatrina <54268893+kosiakkatrina@users.noreply.github.com>
Date: Wed, 4 May 2022 11:25:30 +0100
Subject: [PATCH] map tshortfall value (#543)

---
 app/services/imports/case_logs_import_service.rb              | 1 +
 .../case_logs/0ead17cb-1668-442d-898c-0d52879ff592.xml        | 4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/app/services/imports/case_logs_import_service.rb b/app/services/imports/case_logs_import_service.rb
index 3bf1bc0dc..f04fb8cea 100644
--- a/app/services/imports/case_logs_import_service.rb
+++ b/app/services/imports/case_logs_import_service.rb
@@ -125,6 +125,7 @@ module Imports
       attributes["tcharge"] = safe_string_as_decimal(xml_doc, "Q18av")
 
       attributes["hbrentshortfall"] = unsafe_string_as_integer(xml_doc, "Q18d")
+      attributes["tshortfall"] = safe_string_as_decimal(xml_doc, "Q18dyes")
 
       attributes["voiddate"] = compose_date(xml_doc, "VDAY", "VMONTH", "VYEAR")
       attributes["mrcdate"] = compose_date(xml_doc, "MRCDAY", "MRCMONTH", "MRCYEAR")
diff --git a/spec/fixtures/softwire_imports/case_logs/0ead17cb-1668-442d-898c-0d52879ff592.xml b/spec/fixtures/softwire_imports/case_logs/0ead17cb-1668-442d-898c-0d52879ff592.xml
index bdd95321b..3ff204058 100644
--- a/spec/fixtures/softwire_imports/case_logs/0ead17cb-1668-442d-898c-0d52879ff592.xml
+++ b/spec/fixtures/softwire_imports/case_logs/0ead17cb-1668-442d-898c-0d52879ff592.xml
@@ -165,8 +165,8 @@
     <Q18aiii override-field=""/>
     <Q18aiv override-field=""/>
     <Q18av override-field="">438.11</Q18av>
-    <Q18d>2 No</Q18d>
-    <Q18dyes override-field=""/>
+    <Q18d>1 Yes</Q18d>
+    <Q18dyes override-field="">7.00</Q18dyes>
     <Q19void>2021-09-30</Q19void>
     <Q19repair/>
     <Q20 override-field="">0</Q20>