From 9b09af36253110cc76c9eba3e677263c023f52c8 Mon Sep 17 00:00:00 2001 From: JG Date: Wed, 29 Jun 2022 14:47:15 +0100 Subject: [PATCH] small refactoring - 3 --- app/controllers/schemes_controller.rb | 2 +- spec/requests/schemes_controller_spec.rb | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/app/controllers/schemes_controller.rb b/app/controllers/schemes_controller.rb index 78a4e49a1..5cfde3dcf 100644 --- a/app/controllers/schemes_controller.rb +++ b/app/controllers/schemes_controller.rb @@ -49,7 +49,7 @@ class SchemesController < ApplicationController if confirm_secondary_page? page redirect_to scheme_secondary_client_group_path(@scheme, check_answers: "true") else - @scheme.update!(secondary_client_group: nil) unless !@scheme.has_other_client_group == "No" + @scheme.update!(secondary_client_group: nil) if @scheme.has_other_client_group == "No" redirect_to scheme_check_answers_path(@scheme) end else diff --git a/spec/requests/schemes_controller_spec.rb b/spec/requests/schemes_controller_spec.rb index 3f93bcba7..10ad1f0b7 100644 --- a/spec/requests/schemes_controller_spec.rb +++ b/spec/requests/schemes_controller_spec.rb @@ -205,7 +205,6 @@ RSpec.describe SchemesController, type: :request do expect(page).to have_content(specific_scheme.sensitive) expect(page).to have_content(specific_scheme.scheme_type) expect(page).to have_content(specific_scheme.registered_under_care_act) - expect(page).to have_content(specific_scheme.total_units) expect(page).to have_content(specific_scheme.primary_client_group) expect(page).to have_content(specific_scheme.secondary_client_group) expect(page).to have_content(specific_scheme.support_type) @@ -239,7 +238,6 @@ RSpec.describe SchemesController, type: :request do expect(page).to have_content(specific_scheme.sensitive) expect(page).to have_content(specific_scheme.scheme_type) expect(page).to have_content(specific_scheme.registered_under_care_act) - expect(page).to have_content(specific_scheme.total_units) expect(page).to have_content(specific_scheme.primary_client_group) expect(page).to have_content(specific_scheme.secondary_client_group) expect(page).to have_content(specific_scheme.support_type)