From 9dc37f7fff1aa6ccbec213200192a73ab2afd7ff Mon Sep 17 00:00:00 2001
From: Rachael Booth <Rachael.Booth@softwire.com>
Date: Wed, 20 Mar 2024 15:38:15 +0000
Subject: [PATCH] CLDC-3304: Add bulk upload id to xml exports from 2024
 (#2323)

---
 app/services/exports/lettings_log_export_constants.rb     | 2 ++
 spec/fixtures/exports/general_needs_log_24_25.xml         | 3 ++-
 spec/services/exports/lettings_log_export_service_spec.rb | 2 +-
 3 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/app/services/exports/lettings_log_export_constants.rb b/app/services/exports/lettings_log_export_constants.rb
index c60f1339d..0e6edd139 100644
--- a/app/services/exports/lettings_log_export_constants.rb
+++ b/app/services/exports/lettings_log_export_constants.rb
@@ -141,6 +141,7 @@ module Exports::LettingsLogExportConstants
     "duplicate_set_id",
     "accessible_register",
     "nationality_all",
+    "bulk_upload_id",
     "address_line1_as_entered",
     "address_line2_as_entered",
     "town_or_city_as_entered",
@@ -167,6 +168,7 @@ module Exports::LettingsLogExportConstants
   POST_2024_EXPORT_FIELDS = Set[
     "accessible_register",
     "nationality_all",
+    "bulk_upload_id",
     "address_line1_as_entered",
     "address_line2_as_entered",
     "town_or_city_as_entered",
diff --git a/spec/fixtures/exports/general_needs_log_24_25.xml b/spec/fixtures/exports/general_needs_log_24_25.xml
index f21e20f47..3b27d50af 100644
--- a/spec/fixtures/exports/general_needs_log_24_25.xml
+++ b/spec/fixtures/exports/general_needs_log_24_25.xml
@@ -134,6 +134,7 @@
     <hhtype>4</hhtype>
     <new_old>2</new_old>
     <vacdays>698</vacdays>
+    <bulk_upload_id>1</bulk_upload_id>
     <uprn/>
     <uprn_known>0</uprn_known>
     <uprn_confirmed/>
@@ -142,7 +143,7 @@
     <town_or_city>London</town_or_city>
     <county/>
     <discarded_at/>
-    <creation_method>1</creation_method>
+    <creation_method>2</creation_method>
     <duplicate_set_id/>
     <accessible_register>2</accessible_register>
     <nationality_all/>
diff --git a/spec/services/exports/lettings_log_export_service_spec.rb b/spec/services/exports/lettings_log_export_service_spec.rb
index 2e534f748..dd2230598 100644
--- a/spec/services/exports/lettings_log_export_service_spec.rb
+++ b/spec/services/exports/lettings_log_export_service_spec.rb
@@ -472,7 +472,7 @@ RSpec.describe Exports::LettingsLogExportService do
       end
 
       context "and one lettings log is available for export" do
-        let!(:lettings_log) { FactoryBot.create(:lettings_log, :completed, created_by: user, ppostcode_full: "A1 1AA", nationality_all_group: 13, propcode: "123", postcode_full: "SE2 6RT", tenancycode: "BZ737", startdate: Time.zone.local(2024, 4, 2, 10, 36, 49), voiddate: Time.zone.local(2021, 11, 3), mrcdate: Time.zone.local(2022, 5, 5, 10, 36, 49), tenancylength: 5, underoccupation_benefitcap: 4, address_line1_as_entered: "address line 1 as entered", address_line2_as_entered: "address line 2 as entered", town_or_city_as_entered: "town or city as entered", county_as_entered: "county as entered", postcode_full_as_entered: "AB1 2CD", la_as_entered: "la as entered") }
+        let!(:lettings_log) { FactoryBot.create(:lettings_log, :completed, created_by: user, ppostcode_full: "A1 1AA", nationality_all_group: 13, propcode: "123", postcode_full: "SE2 6RT", tenancycode: "BZ737", startdate: Time.zone.local(2024, 4, 2, 10, 36, 49), voiddate: Time.zone.local(2021, 11, 3), mrcdate: Time.zone.local(2022, 5, 5, 10, 36, 49), tenancylength: 5, underoccupation_benefitcap: 4, creation_method: 2, bulk_upload_id: 1, address_line1_as_entered: "address line 1 as entered", address_line2_as_entered: "address line 2 as entered", town_or_city_as_entered: "town or city as entered", county_as_entered: "county as entered", postcode_full_as_entered: "AB1 2CD", la_as_entered: "la as entered") }
         let(:expected_zip_filename) { "core_2024_2025_apr_mar_f0001_inc0001.zip" }
         let(:expected_data_filename) { "core_2024_2025_apr_mar_f0001_inc0001_pt001.xml" }
         let(:xml_export_file) { File.open("spec/fixtures/exports/general_needs_log_24_25.xml", "r:UTF-8") }