From 9ec566afe759ad6d1a93199c0b39276c85fddbd3 Mon Sep 17 00:00:00 2001 From: Carolyn Date: Fri, 21 Mar 2025 16:16:47 +0000 Subject: [PATCH] CLDC-3899 remove flaky date comparison from tests --- spec/models/location_spec.rb | 6 ++---- spec/models/scheme_spec.rb | 3 +-- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/spec/models/location_spec.rb b/spec/models/location_spec.rb index 6d876381d..c220914b7 100644 --- a/spec/models/location_spec.rb +++ b/spec/models/location_spec.rb @@ -1016,16 +1016,14 @@ RSpec.describe Location, type: :model do end it "returns reactivating soon if the location has a future reactivation date" do - deactivation_period = FactoryBot.create(:location_deactivation_period, deactivation_date: Time.zone.yesterday, reactivation_date: Time.zone.tomorrow, location:) + FactoryBot.create(:location_deactivation_period, deactivation_date: Time.zone.yesterday, reactivation_date: Time.zone.tomorrow, location:) location.save! - expect(deactivation_period.deactivation_date).to eq(Time.zone.yesterday) expect(location.status).to eq(:reactivating_soon) end it "returns reactivating soon if the location had a deactivation during another deactivation" do - deactivation_period = FactoryBot.create(:location_deactivation_period, deactivation_date: Time.zone.today - 1.month, reactivation_date: Time.zone.today + 2.days, location:) + FactoryBot.create(:location_deactivation_period, deactivation_date: Time.zone.today - 1.month, reactivation_date: Time.zone.today + 2.days, location:) location.save! - expect(deactivation_period.deactivation_date).to eq(Time.zone.today - 1.month) expect(location.status).to eq(:reactivating_soon) end diff --git a/spec/models/scheme_spec.rb b/spec/models/scheme_spec.rb index a0afad6fa..21b60cd52 100644 --- a/spec/models/scheme_spec.rb +++ b/spec/models/scheme_spec.rb @@ -433,9 +433,8 @@ RSpec.describe Scheme, type: :model do end it "returns reactivating soon if the scheme had a deactivation during another deactivation" do - deactivation_period = FactoryBot.create(:scheme_deactivation_period, deactivation_date: Time.zone.today - 2.months, reactivation_date: Time.zone.today + 2.days, scheme:) + FactoryBot.create(:scheme_deactivation_period, deactivation_date: Time.zone.today - 2.months, reactivation_date: Time.zone.today + 2.days, scheme:) scheme.save! - expect(deactivation_period.deactivation_date).to eq(Time.zone.today - 2.months) expect(scheme.status).to eq(:reactivating_soon) end