From 9ef531b03bf3eed534d2941a169fc7d75c795830 Mon Sep 17 00:00:00 2001
From: Kat <54268893+kosiakkatrina@users.noreply.github.com>
Date: Mon, 13 Jan 2025 14:16:22 +0000
Subject: [PATCH] Check that income ranges exist

---
 app/models/lettings_log.rb | 2 +-
 app/models/sales_log.rb    | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/app/models/lettings_log.rb b/app/models/lettings_log.rb
index 67cafb75b..ad86a72b4 100644
--- a/app/models/lettings_log.rb
+++ b/app/models/lettings_log.rb
@@ -240,7 +240,7 @@ class LettingsLog < Log
   end
 
   def applicable_income_range
-    return unless ecstat1 && hhmemb
+    return unless ecstat1 && hhmemb && ALLOWED_INCOME_RANGES[ecstat1]
 
     range = ALLOWED_INCOME_RANGES[ecstat1].clone
 
diff --git a/app/models/sales_log.rb b/app/models/sales_log.rb
index d03425ee4..b82e2b209 100644
--- a/app/models/sales_log.rb
+++ b/app/models/sales_log.rb
@@ -440,9 +440,9 @@ class SalesLog < Log
   def income_soft_min_for_ecstat(ecstat_field)
     economic_status_code = public_send(ecstat_field)
 
-    return unless ALLOWED_INCOME_RANGES_SALES
+    return unless ALLOWED_INCOME_RANGES_SALES && ALLOWED_INCOME_RANGES_SALES[economic_status_code]
 
-    soft_min = ALLOWED_INCOME_RANGES_SALES[economic_status_code]&.soft_min
+    soft_min = ALLOWED_INCOME_RANGES_SALES[economic_status_code].soft_min
     format_as_currency(soft_min)
   end