Browse Source

lint fixes

pull/552/head
Ted 3 years ago
parent
commit
a103b8616a
  1. 6
      app/helpers/filters_helper.rb
  2. 2
      spec/helpers/filters_helper_spec.rb

6
app/helpers/filters_helper.rb

@ -1,9 +1,9 @@
module FiltersHelper module FiltersHelper
def filter_selected?(filter, value) def filter_selected?(filter, value)
return false unless session[:case_logs_filters] return false unless session[:case_logs_filters]
selected_filters = JSON.parse(session[:case_logs_filters]) selected_filters = JSON.parse(session[:case_logs_filters])
return true if selected_filters.blank? && filter == "user" && value == :all return true if selected_filters.blank? && filter == "user" && value == :all
return false if selected_filters[filter].blank? return false if selected_filters[filter].blank?
selected_filters[filter].include?(value.to_s) selected_filters[filter].include?(value.to_s)

2
spec/helpers/filters_helper_spec.rb

@ -11,7 +11,7 @@ RSpec.describe FiltersHelper do
context "when the filter is the user filter but session filters is empty" do context "when the filter is the user filter but session filters is empty" do
before do before do
session[:case_logs_filters] = { }.to_json session[:case_logs_filters] = {}.to_json
end end
context "when looking at the all value" do context "when looking at the all value" do

Loading…
Cancel
Save