From a3a04998b05e8a4b3efb7199f27ad31d7dd77437 Mon Sep 17 00:00:00 2001 From: Nat Dean-Lewis Date: Wed, 18 Mar 2026 17:04:51 +0000 Subject: [PATCH] CLDC-4297: comment update --- app/services/bulk_upload/lettings/year2025/row_parser.rb | 4 +++- app/services/bulk_upload/lettings/year2026/row_parser.rb | 4 +++- app/services/bulk_upload/sales/year2025/row_parser.rb | 4 +++- app/services/bulk_upload/sales/year2026/row_parser.rb | 4 +++- 4 files changed, 12 insertions(+), 4 deletions(-) diff --git a/app/services/bulk_upload/lettings/year2025/row_parser.rb b/app/services/bulk_upload/lettings/year2025/row_parser.rb index d00c6f437..f3b6e7edd 100644 --- a/app/services/bulk_upload/lettings/year2025/row_parser.rb +++ b/app/services/bulk_upload/lettings/year2025/row_parser.rb @@ -525,7 +525,9 @@ class BulkUpload::Lettings::Year2025::RowParser @log ||= LettingsLog.new(attributes_for_log) end - # Will send a "Bulk upload failed" email rather than an "Errors in bulk upload" email + # Will send a "Bulk upload failed" email rather than an "Errors in bulk upload" email. + # The body of the "Bulk upload failed" email says there are errors in the setup section, + # so only use this method for setup section errors. def block_log_creation! self.block_log_creation = true end diff --git a/app/services/bulk_upload/lettings/year2026/row_parser.rb b/app/services/bulk_upload/lettings/year2026/row_parser.rb index e646e9445..98a38d6e7 100644 --- a/app/services/bulk_upload/lettings/year2026/row_parser.rb +++ b/app/services/bulk_upload/lettings/year2026/row_parser.rb @@ -560,7 +560,9 @@ class BulkUpload::Lettings::Year2026::RowParser @log ||= LettingsLog.new(attributes_for_log) end - # Will send a "Bulk upload failed" email rather than an "Errors in bulk upload" email + # Will send a "Bulk upload failed" email rather than an "Errors in bulk upload" email. + # The body of the "Bulk upload failed" email says there are errors in the setup section, + # so only use this method for setup section errors. def block_log_creation! self.block_log_creation = true end diff --git a/app/services/bulk_upload/sales/year2025/row_parser.rb b/app/services/bulk_upload/sales/year2025/row_parser.rb index b188fbe25..dda701163 100644 --- a/app/services/bulk_upload/sales/year2025/row_parser.rb +++ b/app/services/bulk_upload/sales/year2025/row_parser.rb @@ -1288,7 +1288,9 @@ private end end - # Will send a "Bulk upload failed" email rather than an "Errors in bulk upload" email + # Will send a "Bulk upload failed" email rather than an "Errors in bulk upload" email. + # The body of the "Bulk upload failed" email says there are errors in the setup section, + # so only use this method for setup section errors. def block_log_creation! self.block_log_creation = true end diff --git a/app/services/bulk_upload/sales/year2026/row_parser.rb b/app/services/bulk_upload/sales/year2026/row_parser.rb index 6a03db265..6d812f324 100644 --- a/app/services/bulk_upload/sales/year2026/row_parser.rb +++ b/app/services/bulk_upload/sales/year2026/row_parser.rb @@ -1419,7 +1419,9 @@ private end end - # Will send a "Bulk upload failed" email rather than an "Errors in bulk upload" email + # Will send a "Bulk upload failed" email rather than an "Errors in bulk upload" email. + # The body of the "Bulk upload failed" email says there are errors in the setup section, + # so only use this method for setup section errors. def block_log_creation! self.block_log_creation = true end