From a66c47a1abf7a429f25e0a016fedb0b92e92f15c Mon Sep 17 00:00:00 2001
From: Manny Dinssa <44172848+Dinssa@users.noreply.github.com>
Date: Thu, 27 Feb 2025 15:03:04 +0000
Subject: [PATCH] Fix bug clearing uprn from see all answers

---
 app/models/derived_variables/lettings_log_variables.rb | 2 ++
 app/models/derived_variables/sales_log_variables.rb    | 1 +
 app/models/validations/property_validations.rb         | 2 +-
 app/models/validations/sales/property_validations.rb   | 2 +-
 4 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/app/models/derived_variables/lettings_log_variables.rb b/app/models/derived_variables/lettings_log_variables.rb
index 4327469dc..a1dc09332 100644
--- a/app/models/derived_variables/lettings_log_variables.rb
+++ b/app/models/derived_variables/lettings_log_variables.rb
@@ -102,6 +102,7 @@ module DerivedVariables::LettingsLogVariables
       self.uprn = nil
       self.uprn_known = 0
       self.uprn_confirmed = nil
+      self.uprn_selection = nil
       self.address_line1 = nil
       self.address_line2 = nil
       self.town_or_city = nil
@@ -356,6 +357,7 @@ private
     self.uprn = nil
     self.uprn_known = nil
     self.uprn_confirmed = nil
+    self.uprn_selection = nil
     self.address_line1 = nil
     self.address_line2 = nil
     self.town_or_city = nil
diff --git a/app/models/derived_variables/sales_log_variables.rb b/app/models/derived_variables/sales_log_variables.rb
index 81ad177e4..3b5f6209d 100644
--- a/app/models/derived_variables/sales_log_variables.rb
+++ b/app/models/derived_variables/sales_log_variables.rb
@@ -241,6 +241,7 @@ private
   def reset_address_fields!
     self.uprn = nil
     self.uprn_known = nil
+    self.uprn_selection = nil
     self.address_line1 = nil
     self.address_line2 = nil
     self.town_or_city = nil
diff --git a/app/models/validations/property_validations.rb b/app/models/validations/property_validations.rb
index f051a65db..1cf710857 100644
--- a/app/models/validations/property_validations.rb
+++ b/app/models/validations/property_validations.rb
@@ -50,7 +50,7 @@ module Validations::PropertyValidations
   end
 
   def validate_la_in_england(record)
-    return unless record.form.start_year_2025_or_later? || (record.startdate_changed? && record.startdate_was&.year == 2025 && record.startdate.year == 2024)
+    return unless record.form.start_year_2025_or_later?
 
     if record.is_general_needs?
       return unless record.la
diff --git a/app/models/validations/sales/property_validations.rb b/app/models/validations/sales/property_validations.rb
index af576c260..af1ca7c4e 100644
--- a/app/models/validations/sales/property_validations.rb
+++ b/app/models/validations/sales/property_validations.rb
@@ -40,7 +40,7 @@ module Validations::Sales::PropertyValidations
   end
 
   def validate_la_in_england(record)
-    return unless record.form.start_year_2025_or_later? || (record.saledate_changed? && record.saledate_was&.year == 2025 && record.saledate.year == 2024)
+    return unless record.form.start_year_2025_or_later?
     return unless record.la
     return if record.la.in?(LocalAuthority.england.pluck(:code))