From a933e2989e0f8062ec4f6a2ff08b4e5aa98b7d4e Mon Sep 17 00:00:00 2001 From: baarkerlounger Date: Mon, 11 Oct 2021 11:33:01 +0100 Subject: [PATCH] Refactor checkbox question selection --- app/models/form.rb | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/app/models/form.rb b/app/models/form.rb index e6483ba50..b1d0a98b0 100644 --- a/app/models/form.rb +++ b/app/models/form.rb @@ -77,12 +77,10 @@ class Form end def checkbox_questions_for_page(page) - questions = {} - questions_for_page = all_pages[page]["questions"] - checkbox_questions = questions_for_page.select { |_title, question| question["type"] == "checkbox" } - checkbox_questions.each { |title, question| - questions[title] = question["answer_options"].keys.reject { |key, _value| key.match?(/divider/) } } - questions.map { |_key, value| value }.flatten + checkbox_questions = questions_for_page(page).select { |_title, question| question["type"] == "checkbox" } + checkbox_questions.flat_map do |title, question| + question["answer_options"].keys.reject { |key, _value| key.match?(/divider/) } + end end end