Refactor validation specs (#297)

* Unit tests

* Age validations

* Add todo

* Check all new records have correct validator

* Reasonable preference

* Pregnancy validations

* Spec

* Fix spec

app/models/validations/household_validations.rb

@@ -6,6 +6,7 @@ module Validations::HouseholdValidations
   def validate_reasonable_preference(record)
     if record.homeless == "No" && record.reasonpref == "Yes"
       record.errors.add :reasonpref, I18n.t("validations.household.reasonpref.not_homeless")
+      record.errors.add :homeless, I18n.t("validations.household.reasonpref.not_homeless")
     elsif record.reasonpref == "No"
       if [record.rp_homeless, record.rp_insan_unsat, record.rp_medwel, record.rp_hardship, record.rp_dontknow].any? { |a| a == "Yes" }
         record.errors.add :reasonable_preference_reason, I18n.t("validations.household.reasonable_preference_reason.reason_not_required")

spec/models/case_log_spec.rb

@@ -18,123 +18,21 @@ RSpec.describe CaseLog do
   end
 
   describe "#new" do
-    it "raises an error when offered is present and invalid" do
-      expect {
-        described_class.create!(
-          offered: "random",
+    context "when creating a record" do
+      let(:case_log) do
+        described_class.create(
           owning_organisation: owning_organisation,
           managing_organisation: managing_organisation,
         )
-      }.to raise_error(ActiveRecord::RecordInvalid)
-    end
-
-    it "raises an error when previous_postcode is present and invalid" do
-      expect {
-        described_class.create!(
-          previous_postcode: "invalid_postcode",
-          owning_organisation: owning_organisation,
-          managing_organisation: managing_organisation,
-        )
-      }.to raise_error(ActiveRecord::RecordInvalid, /#{I18n.t("validations.postcode")}/)
-    end
-
-    it "validates age is a number" do
-      expect {
-        described_class.create!(
-          age1: "random",
-          owning_organisation: owning_organisation,
-          managing_organisation: managing_organisation,
-        )
-      }.to raise_error(ActiveRecord::RecordInvalid)
-      expect {
-        described_class.create!(
-          age3: "random",
-          owning_organisation: owning_organisation,
-          managing_organisation: managing_organisation,
-        )
-      }.to raise_error(ActiveRecord::RecordInvalid)
-    end
-
-    it "validates age is under 120" do
-      expect {
-        described_class.create!(
-          age1: 121,
-          owning_organisation: owning_organisation,
-          managing_organisation: managing_organisation,
-        )
-      }.to raise_error(ActiveRecord::RecordInvalid)
-      expect {
-        described_class.create!(
-          age3: 121,
-          owning_organisation: owning_organisation,
-          managing_organisation: managing_organisation,
-        )
-      }.to raise_error(ActiveRecord::RecordInvalid)
-    end
-
-    it "validates age is over 0" do
-      expect {
-        described_class.create!(
-          age1: 0,
-          owning_organisation: owning_organisation,
-          managing_organisation: managing_organisation,
-        )
-      }.to raise_error(ActiveRecord::RecordInvalid)
-      expect {
-        described_class.create!(
-          age3: 0,
-          owning_organisation: owning_organisation,
-          managing_organisation: managing_organisation,
-        )
-      }.to raise_error(ActiveRecord::RecordInvalid)
-    end
-
-    it "validates bedroom number" do
-      expect {
-        described_class.create!(unittype_gn: "Shared house",
-                                beds: 0,
-                                owning_organisation: owning_organisation,
-                                managing_organisation: managing_organisation)
-      }.to raise_error(ActiveRecord::RecordInvalid)
-    end
-
-    context "when a reasonable preference is set to yes" do
-      it "validates that previously homeless should be selected" do
-        expect {
-          described_class.create!(
-            homeless: "No",
-            reasonpref: "Yes",
-            owning_organisation: owning_organisation,
-            managing_organisation: managing_organisation,
-          )
-        }.to raise_error(ActiveRecord::RecordInvalid)
       end
-    end
 
-    context "when a reasonable preference is set to no" do
-      it "validates no reason is needed" do
-        expect {
-          described_class.create!(
-            reasonpref: "No",
-            rp_homeless: "No",
-            owning_organisation: owning_organisation,
-            managing_organisation: managing_organisation,
-          )
-        }.not_to raise_error
-      end
-
-      it "validates that no reason has been provided" do
-        expect {
-          described_class.create!(
-            reasonpref: "No",
-            rp_medwel: "Yes",
-            owning_organisation: owning_organisation,
-            managing_organisation: managing_organisation,
-          )
-        }.to raise_error(ActiveRecord::RecordInvalid)
+      it "attaches the correct custom validator" do
+        expect(case_log._validators.values.flatten.map(&:class))
+          .to include(CaseLogValidator)
       end
     end
 
+    # TODO: replace these with validator specs and checks for method call here
     context "with a reason for leaving last settled home validation" do
       it "checks the reason for leaving must be don’t know if reason for leaving settled home (Q9a) is don’t know." do
         expect {
@@ -178,46 +76,6 @@ RSpec.describe CaseLog do
     end
 
     context "when validating pregnancy questions" do
-      it "Cannot answer yes if no female tenants" do
-        expect {
-          described_class.create!(preg_occ: "Yes",
-                                  sex1: "Male",
-                                  age1: 20,
-                                  owning_organisation: owning_organisation,
-                                  managing_organisation: managing_organisation)
-        }.to raise_error(ActiveRecord::RecordInvalid)
-      end
-
-      it "Cannot answer yes if no female tenants within age range" do
-        expect {
-          described_class.create!(preg_occ: "Yes",
-                                  sex1: "Female",
-                                  age1: 51,
-                                  owning_organisation: owning_organisation,
-                                  managing_organisation: managing_organisation)
-        }.to raise_error(ActiveRecord::RecordInvalid)
-      end
-
-      it "Cannot answer prefer not to say if no valid tenants" do
-        expect {
-          described_class.create!(preg_occ: "Prefer not to say",
-                                  sex1: "Male",
-                                  age1: 20,
-                                  owning_organisation: owning_organisation,
-                                  managing_organisation: managing_organisation)
-        }.to raise_error(ActiveRecord::RecordInvalid)
-      end
-
-      it "Can answer yes if valid tenants" do
-        expect {
-          described_class.create!(preg_occ: "Yes",
-                                  sex1: "Female",
-                                  age1: 20,
-                                  owning_organisation: owning_organisation,
-                                  managing_organisation: managing_organisation)
-        }.not_to raise_error
-      end
-
       it "Can answer yes if valid second tenant" do
         expect {
           described_class.create!(preg_occ: "Yes",
@@ -357,17 +215,6 @@ RSpec.describe CaseLog do
       end
     end
 
-    context "when validating fixed term tenancy" do
-      it "Must not be completed if Type of main tenancy is not responded with either Secure or Assured shorthold " do
-        expect {
-          described_class.create!(tenancy: "Other",
-                                  tenancylength: 10,
-                                  owning_organisation: owning_organisation,
-                                  managing_organisation: managing_organisation)
-        }.to raise_error(ActiveRecord::RecordInvalid)
-      end
-    end
-
     context "when validating armed forces is active" do
       it "must not be answered if not ever served as a regular" do
         expect {
@@ -798,6 +645,45 @@ RSpec.describe CaseLog do
         check_rsnvac_referral_validation("Health service")
       end
     end
+    # END TODO
+  end
+
+  describe "#update" do
+    let(:case_log) { FactoryBot.create(:case_log) }
+    let(:validator) { case_log._validators[nil].first }
+
+    after do
+      case_log.update(age1: 25)
+    end
+
+    it "validates ages" do
+      expect(validator).to receive(:validate_person_1_age)
+      expect(validator).to receive(:validate_household_number_of_other_members)
+    end
+
+    it "validates bedroom number" do
+      expect(validator).to receive(:validate_shared_housing_rooms)
+    end
+
+    it "validates number of times the property has been relet" do
+      expect(validator).to receive(:validate_property_number_of_times_relet)
+    end
+
+    it "validates tenancy length for tenancy type" do
+      expect(validator).to receive(:validate_fixed_term_tenancy)
+    end
+
+    it "validates the previous postcode" do
+      expect(validator).to receive(:validate_previous_accommodation_postcode)
+    end
+
+    it "validates the net income" do
+      expect(validator).to receive(:validate_net_income)
+    end
+
+    it "validates reasonable preference" do
+      expect(validator).to receive(:validate_reasonable_preference)
+    end
   end
 
   describe "status" do

spec/models/validations/household_validations_spec.rb

@@ -0,0 +1,168 @@
+require "rails_helper"
+
+RSpec.describe Validations::HouseholdValidations do
+  subject(:household_validator) { validator_class.new }
+
+  let(:validator_class) { Class.new { include Validations::HouseholdValidations } }
+  let(:record) { FactoryBot.create(:case_log) }
+
+  describe "age validations" do
+    it "validates that person 1's age is a number" do
+      record.age1 = "random"
+      household_validator.validate_person_1_age(record)
+      expect(record.errors["age1"])
+        .to include(match I18n.t("validations.household.age.must_be_valid", lower_bound: 16))
+    end
+
+    it "validates that other household member ages are a number" do
+      record.age3 = "random"
+      household_validator.validate_household_number_of_other_members(record)
+      expect(record.errors["age3"])
+        .to include(match I18n.t("validations.household.age.must_be_valid", lower_bound: 1))
+    end
+
+    it "validates that person 1's age is greater than 16" do
+      record.age1 = 15
+      household_validator.validate_person_1_age(record)
+      expect(record.errors["age1"])
+        .to include(match I18n.t("validations.household.age.must_be_valid", lower_bound: 16))
+    end
+
+    it "validates that other household member ages are greater than 1" do
+      record.age4 = 0
+      household_validator.validate_household_number_of_other_members(record)
+      expect(record.errors["age4"])
+        .to include(match I18n.t("validations.household.age.must_be_valid", lower_bound: 1))
+    end
+
+    it "validates that person 1's age is less than 121" do
+      record.age1 = 121
+      household_validator.validate_person_1_age(record)
+      expect(record.errors["age1"])
+        .to include(match I18n.t("validations.household.age.must_be_valid", lower_bound: 16))
+    end
+
+    it "validates that other household member ages are greater than 121" do
+      record.age4 = 123
+      household_validator.validate_household_number_of_other_members(record)
+      expect(record.errors["age4"])
+        .to include(match I18n.t("validations.household.age.must_be_valid", lower_bound: 1))
+    end
+
+    it "validates that person 1's age is between 16 and 120" do
+      record.age1 = 63
+      household_validator.validate_person_1_age(record)
+      expect(record.errors["age1"]).to be_empty
+    end
+
+    it "validates that other household member ages are between 1 and 120" do
+      record.age6 = 45
+      household_validator.validate_household_number_of_other_members(record)
+      expect(record.errors["age6"]).to be_empty
+    end
+  end
+
+  describe "reasonable preference validations" do
+    context "when reasonable preference is given" do
+      context "when the tenant was not previously homeless" do
+        it "adds an error" do
+          record.homeless = "No"
+          record.reasonpref = "Yes"
+          household_validator.validate_reasonable_preference(record)
+          expect(record.errors["reasonpref"])
+            .to include(match I18n.t("validations.household.reasonpref.not_homeless"))
+          expect(record.errors["homeless"])
+            .to include(match I18n.t("validations.household.reasonpref.not_homeless"))
+        end
+      end
+
+      context "when reasonable preference is given" do
+        context "when the tenant was previously homeless" do
+          it "does not add an error" do
+            record.homeless = "Other homeless - not found statutorily homeless but considered homeless by landlord"
+            record.reasonpref = "Yes"
+            household_validator.validate_reasonable_preference(record)
+            expect(record.errors["reasonpref"]).to be_empty
+            expect(record.errors["homeless"]).to be_empty
+            record.homeless = "Assessed as homeless (or threatened with homelessness within 56 days) by a local authority and owed a homelessness duty"
+            household_validator.validate_reasonable_preference(record)
+            expect(record.errors["reasonpref"]).to be_empty
+            expect(record.errors["homeless"]).to be_empty
+          end
+        end
+      end
+    end
+
+    context "when reasonable preference is not given" do
+      it "validates that no reason is needed" do
+        record.reasonpref = "No"
+        record.rp_homeless = "No"
+        household_validator.validate_reasonable_preference(record)
+        expect(record.errors["reasonpref"]).to be_empty
+      end
+
+      it "validates that no reason is given" do
+        record.reasonpref = "No"
+        record.rp_medwel = "Yes"
+        household_validator.validate_reasonable_preference(record)
+        expect(record.errors["reasonable_preference_reason"])
+          .to include(match I18n.t("validations.household.reasonable_preference_reason.reason_not_required"))
+      end
+    end
+  end
+
+  describe "pregnancy validations" do
+    context "when there are no female tenants" do
+      it "validates that pregnancy cannot be yes" do
+        record.preg_occ = "Yes"
+        record.sex1 = "Male"
+        household_validator.validate_pregnancy(record)
+        expect(record.errors["preg_occ"])
+          .to include(match I18n.t("validations.household.preg_occ.no_female"))
+      end
+
+      it "validates that pregnancy cannot be prefer not to say" do
+        record.preg_occ = "Prefer not to say"
+        record.sex1 = "Male"
+        household_validator.validate_pregnancy(record)
+        expect(record.errors["preg_occ"])
+          .to include(match I18n.t("validations.household.preg_occ.no_female"))
+      end
+    end
+
+    context "when there are female tenants" do
+      context "but they are older than 50" do
+        it "validates that pregnancy cannot be yes" do
+          record.preg_occ = "Yes"
+          record.sex1 = "Female"
+          record.age1 = "51"
+          household_validator.validate_pregnancy(record)
+          expect(record.errors["preg_occ"])
+            .to include(match I18n.t("validations.household.preg_occ.no_female"))
+        end
+      end
+
+      context "and they are the main tenant and under 51" do
+        it "pregnancy can be yes" do
+          record.preg_occ = "Yes"
+          record.sex1 = "Female"
+          record.age1 = "32"
+          household_validator.validate_pregnancy(record)
+          expect(record.errors["preg_occ"]).to be_empty
+        end
+      end
+
+      context "and they are another household member and under 51" do
+        it "pregnancy can be yes" do
+          record.preg_occ = "Yes"
+          record.sex1 = "Male"
+          record.age1 = 25
+          record.sex3 = "Female"
+          record.age3 = "32"
+          household_validator.validate_pregnancy(record)
+          expect(record.errors["preg_occ"]).to be_empty
+        end
+      end
+    end
+  end
+end