From b5458001acfc960a6f6425680c191fc222d86465 Mon Sep 17 00:00:00 2001 From: natdeanlewissoftwire <94526761+natdeanlewissoftwire@users.noreply.github.com> Date: Thu, 18 May 2023 12:15:06 +0100 Subject: [PATCH] CLDC-2370 Add missing bulk upload translation (#1636) * feat: add missing copy * feat: proper case * test: fixed --- config/locales/en.yml | 9 +++++++-- spec/services/bulk_upload/lettings/validator_spec.rb | 12 ++++++------ 2 files changed, 13 insertions(+), 8 deletions(-) diff --git a/config/locales/en.yml b/config/locales/en.yml index 39f90a88a..ce969b9f9 100644 --- a/config/locales/en.yml +++ b/config/locales/en.yml @@ -44,8 +44,13 @@ en: bulk_upload/lettings/validator: attributes: base: - wrong_field_numbers_count: "incorrect number of fields, please ensure you have used the correct template" - over_max_column_count: "too many columns, please ensure you have used the correct template" + wrong_field_numbers_count: "Incorrect number of fields, please ensure you have used the correct template" + over_max_column_count: "Too many columns, please ensure you have used the correct template" + bulk_upload/sales/validator: + attributes: + base: + wrong_field_numbers_count: "Incorrect number of fields, please ensure you have used the correct template" + over_max_column_count: "Too many columns, please ensure you have used the correct template" forms/bulk_upload_lettings/year: attributes: year: diff --git a/spec/services/bulk_upload/lettings/validator_spec.rb b/spec/services/bulk_upload/lettings/validator_spec.rb index 3ba36dfc0..f4fd98a12 100644 --- a/spec/services/bulk_upload/lettings/validator_spec.rb +++ b/spec/services/bulk_upload/lettings/validator_spec.rb @@ -30,7 +30,7 @@ RSpec.describe BulkUpload::Lettings::Validator do it "is not valid" do expect(validator).not_to be_valid - expect(validator.errors["base"]).to eql(["too many columns, please ensure you have used the correct template"]) + expect(validator.errors["base"]).to eql(["Too many columns, please ensure you have used the correct template"]) end end @@ -81,7 +81,7 @@ RSpec.describe BulkUpload::Lettings::Validator do it "is not valid" do expect(validator).not_to be_valid - expect(validator.errors["base"]).to eql(["incorrect number of fields, please ensure you have used the correct template"]) + expect(validator.errors["base"]).to eql(["Incorrect number of fields, please ensure you have used the correct template"]) end end @@ -99,7 +99,7 @@ RSpec.describe BulkUpload::Lettings::Validator do it "is not valid" do expect(validator).not_to be_valid - expect(validator.errors["base"]).to eql(["incorrect number of fields, please ensure you have used the correct template"]) + expect(validator.errors["base"]).to eql(["Incorrect number of fields, please ensure you have used the correct template"]) end end end @@ -118,7 +118,7 @@ RSpec.describe BulkUpload::Lettings::Validator do it "is not valid" do expect(validator).not_to be_valid - expect(validator.errors["base"]).to eql(["too many columns, please ensure you have used the correct template"]) + expect(validator.errors["base"]).to eql(["Too many columns, please ensure you have used the correct template"]) end end @@ -169,7 +169,7 @@ RSpec.describe BulkUpload::Lettings::Validator do it "is not valid" do expect(validator).not_to be_valid - expect(validator.errors["base"]).to eql(["incorrect number of fields, please ensure you have used the correct template"]) + expect(validator.errors["base"]).to eql(["Incorrect number of fields, please ensure you have used the correct template"]) end end @@ -187,7 +187,7 @@ RSpec.describe BulkUpload::Lettings::Validator do it "is not valid" do expect(validator).not_to be_valid - expect(validator.errors["base"]).to eql(["incorrect number of fields, please ensure you have used the correct template"]) + expect(validator.errors["base"]).to eql(["Incorrect number of fields, please ensure you have used the correct template"]) end end end