Remove old feature flags (#2862)

app/controllers/lettings_logs_controller.rb

@@ -22,7 +22,7 @@ class LettingsLogsController < LogsController
     @total_count = all_logs.size
     @unresolved_count = all_logs.unresolved.assigned_to(current_user).count
     @filter_type = "lettings_logs"
-    @duplicate_sets_count = FeatureToggle.duplicate_summary_enabled? && !current_user.support? ? duplicate_sets_count(current_user, current_user.organisation) : 0
+    @duplicate_sets_count = !current_user.support? ? duplicate_sets_count(current_user, current_user.organisation) : 0
     render "logs/index"
   end
 

app/controllers/organisations_controller.rb

@@ -186,7 +186,7 @@ class OrganisationsController < ApplicationController
     @total_count = organisation_logs.size
     @log_type = :lettings
     @filter_type = "lettings_logs"
-    @duplicate_sets_count = FeatureToggle.duplicate_summary_enabled? ? duplicate_sets_count(current_user, @organisation) : 0
+    @duplicate_sets_count = duplicate_sets_count(current_user, @organisation)
     render "logs", layout: "application"
   end
 
@@ -218,7 +218,7 @@ class OrganisationsController < ApplicationController
         @total_count = organisation_logs.size
         @log_type = :sales
         @filter_type = "sales_logs"
-        @duplicate_sets_count = FeatureToggle.duplicate_summary_enabled? ? duplicate_sets_count(current_user, @organisation) : 0
+        @duplicate_sets_count = duplicate_sets_count(current_user, @organisation)
         render "logs", layout: "application"
       end
 

app/controllers/sales_logs_controller.rb

@@ -24,7 +24,7 @@ class SalesLogsController < LogsController
     @searched = search_term.presence
     @total_count = all_logs.size
     @filter_type = "sales_logs"
-    @duplicate_sets_count = FeatureToggle.duplicate_summary_enabled? && !current_user.support? ? duplicate_sets_count(current_user, current_user.organisation) : 0
+    @duplicate_sets_count = !current_user.support? ? duplicate_sets_count(current_user, current_user.organisation) : 0
     render "logs/index"
   end
 

app/services/feature_toggle.rb

@@ -11,10 +11,6 @@ class FeatureToggle
     !Rails.env.development?
   end
 
-  def self.duplicate_summary_enabled?
-    true
-  end
-
   def self.service_unavailable?
     false
   end
@@ -23,18 +19,6 @@ class FeatureToggle
     false
   end
 
-  def self.delete_scheme_enabled?
-    true
-  end
-
-  def self.delete_location_enabled?
-    true
-  end
-
-  def self.delete_user_enabled?
-    true
-  end
-
   def self.local_storage?
     Rails.env.development?
   end

app/views/locations/check_answers.html.erb

@@ -42,7 +42,7 @@
 <% if LocationPolicy.new(current_user, @location).create? %>
   <div class="govuk-button-group">
     <%= govuk_button_to "Save and return to locations", scheme_location_confirm_path(@scheme, @location, route: params[:route]), method: :patch %>
-    <% if LocationPolicy.new(current_user, @location).delete? && FeatureToggle.delete_location_enabled? %>
+    <% if LocationPolicy.new(current_user, @location).delete? %>
       <%= delete_location_link(@location) %>
     <% end %>
     <%= govuk_button_link_to "Cancel", scheme_locations_path(@scheme), secondary: true %>

app/views/locations/show.html.erb

@@ -51,6 +51,6 @@
   <%= toggle_location_link(@location) %>
 <% end %>
 
-<% if LocationPolicy.new(current_user, @location).delete? && FeatureToggle.delete_location_enabled? %>
+<% if LocationPolicy.new(current_user, @location).delete? %>
   <%= delete_location_link(@location) %>
 <% end %>

app/views/schemes/check_answers.html.erb

@@ -24,7 +24,7 @@
     <%= f.govuk_submit button_label %>
   <% end %>
 
-  <% if SchemePolicy.new(current_user, @scheme).delete? && FeatureToggle.delete_scheme_enabled? %>
+  <% if SchemePolicy.new(current_user, @scheme).delete? %>
     <%= delete_scheme_link(@scheme) %>
   <% end %>
 <% end %>

app/views/schemes/show.html.erb

@@ -56,6 +56,6 @@
   <%= toggle_scheme_link(@scheme) %>
 <% end %>
 
-<% if SchemePolicy.new(current_user, @scheme).delete? && FeatureToggle.delete_scheme_enabled? %>
+<% if SchemePolicy.new(current_user, @scheme).delete? %>
   <%= delete_scheme_link(@scheme) %>
 <% end %>

app/views/users/show.html.erb

@@ -157,7 +157,7 @@
           </span>
         <% end %>
       <% end %>
-      <% if UserPolicy.new(current_user, @user).delete? && FeatureToggle.delete_user_enabled? %>
+      <% if UserPolicy.new(current_user, @user).delete? %>
         <%= delete_user_link(@user) %>
       <% end %>
     </div>