From b8ce2fc5ad569854eab28a32fc934351ba8e9e35 Mon Sep 17 00:00:00 2001
From: natdeanlewissoftwire <nat.dean-lewis@softwire.com>
Date: Wed, 19 Oct 2022 13:04:01 +0100
Subject: [PATCH] tests: add tests to org_controller and remove redundant
 housing_providers controller

---
 .../housing_providers_controller.rb           | 28 ------
 app/controllers/organisations_controller.rb   |  6 +-
 .../requests/organisations_controller_spec.rb | 96 +++++++++++++++++++
 3 files changed, 101 insertions(+), 29 deletions(-)
 delete mode 100644 app/controllers/housing_providers_controller.rb

diff --git a/app/controllers/housing_providers_controller.rb b/app/controllers/housing_providers_controller.rb
deleted file mode 100644
index b3a014ada..000000000
--- a/app/controllers/housing_providers_controller.rb
+++ /dev/null
@@ -1,28 +0,0 @@
-class HousingProvidersController < ApplicationController
-  include Pagy::Backend
-  include Modules::SearchFilter
-
-  def index
-    housing_providers =
-      Organisation.joins(:child_organisation_relationships)
-                  .where(organisation_relationships: {
-                    child_organisation_id: current_user.organisation_id,
-                    relationship_type: OrganisationRelationship.relationship_types[:owning],
-                  })
-                  .order(:name)
-    respond_to do |format|
-      format.html do
-        @pagy, @housing_providers = pagy(filtered_collection(housing_providers, search_term))
-        @searched = search_term.presence
-        @total_count = housing_providers.size
-        render "housing_providers/index"
-      end
-    end
-  end
-
-private
-
-  def search_term
-    params["search"]
-  end
-end
diff --git a/app/controllers/organisations_controller.rb b/app/controllers/organisations_controller.rb
index ccc3f65b3..6baa0405d 100644
--- a/app/controllers/organisations_controller.rb
+++ b/app/controllers/organisations_controller.rb
@@ -149,7 +149,11 @@ class OrganisationsController < ApplicationController
         @pagy, @housing_providers = pagy(unpaginated_filtered_housing_providers)
         @searched = search_term.presence
         @total_count = housing_providers.size
-        render "housing_providers", layout: "application"
+        if current_user.support?
+          render "housing_providers", layout: "application"
+        else
+          render "housing_providers/index"
+        end
       end
     end
   end
diff --git a/spec/requests/organisations_controller_spec.rb b/spec/requests/organisations_controller_spec.rb
index 6bc335921..ae36a6d88 100644
--- a/spec/requests/organisations_controller_spec.rb
+++ b/spec/requests/organisations_controller_spec.rb
@@ -284,6 +284,54 @@ RSpec.describe OrganisationsController, type: :request do
         end
       end
 
+      context "when accessing the housing providers tab" do
+        context "with an organisation that the user belongs to" do
+          let!(:housing_provider) { FactoryBot.create(:organisation) }
+          let!(:other_org_housing_provider) { FactoryBot.create(:organisation, name: "Foobar LTD") }
+          let!(:other_organisation) { FactoryBot.create(:organisation, name: "Foobar LTD") }
+          let!(:organisation_relationship) { FactoryBot.create(:organisation_relationship, child_organisation: organisation, parent_organisation: housing_provider, relationship_type: OrganisationRelationship.relationship_types[:owning]) }
+          let!(:other_organisation_relationship) { FactoryBot.create(:organisation_relationship, child_organisation: other_organisation, parent_organisation: other_org_housing_provider, relationship_type: OrganisationRelationship.relationship_types[:owning]) }
+
+          before do
+            get "/organisations/#{organisation.id}/housing-providers", headers:, params: {}
+          end
+
+          it "shows the tab navigation" do
+            expected_html = "<nav class=\"app-primary-navigation\""
+            expect(response.body).to include(expected_html)
+          end
+
+          it "shows an add housing provider button" do
+            expect(page).to have_link("Add a housing provider")
+          end
+
+          it "shows a table of housing providers" do
+            expected_html = "<table class=\"govuk-table\""
+            expect(response.body).to include(expected_html)
+            expect(response.body).to include(housing_provider.name)
+          end
+
+          it "shows only housing providers for the current user's organisation" do
+            expect(page).to have_content(housing_provider.name)
+            expect(page).not_to have_content(other_org_housing_provider.name)
+          end
+
+          it "shows the pagination count" do
+            expect(page).to have_content("1 total housing providers")
+          end
+        end
+
+        context "with an organisation that are not in scope for the user, i.e. that they do not belong to" do
+          before do
+            get "/organisations/#{unauthorised_organisation.id}/housing-providers", headers:, params: {}
+          end
+
+          it "returns not found 404 from users page" do
+            expect(response).to have_http_status(:not_found)
+          end
+        end
+      end
+
       describe "#edit" do
         context "with an organisation that the user belongs to" do
           before do
@@ -478,6 +526,54 @@ RSpec.describe OrganisationsController, type: :request do
         end
       end
 
+      context "when accessing the housing providers tab" do
+        context "with an organisation that the user belongs to" do
+          let!(:housing_provider) { FactoryBot.create(:organisation) }
+          let!(:other_org_housing_provider) { FactoryBot.create(:organisation, name: "Foobar LTD") }
+          let!(:other_organisation) { FactoryBot.create(:organisation, name: "Foobar LTD") }
+          let!(:organisation_relationship) { FactoryBot.create(:organisation_relationship, child_organisation: organisation, parent_organisation: housing_provider, relationship_type: OrganisationRelationship.relationship_types[:owning]) }
+          let!(:other_organisation_relationship) { FactoryBot.create(:organisation_relationship, child_organisation: other_organisation, parent_organisation: other_org_housing_provider, relationship_type: OrganisationRelationship.relationship_types[:owning]) }
+
+          before do
+            get "/organisations/#{organisation.id}/housing-providers", headers:, params: {}
+          end
+
+          it "shows the tab navigation" do
+            expected_html = "<nav class=\"app-primary-navigation\""
+            expect(response.body).to include(expected_html)
+          end
+
+          it "doesn't show an add housing provider button" do
+            expect(page).not_to have_link("Add a housing provider")
+          end
+
+          it "shows a table of housing providers" do
+            expected_html = "<table class=\"govuk-table\""
+            expect(response.body).to include(expected_html)
+            expect(response.body).to include(housing_provider.name)
+          end
+
+          it "shows only housing providers for the current user's organisation" do
+            expect(page).to have_content(housing_provider.name)
+            expect(page).not_to have_content(other_org_housing_provider.name)
+          end
+
+          it "shows the pagination count" do
+            expect(page).to have_content("1 total housing providers")
+          end
+        end
+
+        context "with an organisation that are not in scope for the user, i.e. that they do not belong to" do
+          before do
+            get "/organisations/#{unauthorised_organisation.id}/housing-providers", headers:, params: {}
+          end
+
+          it "returns not found 404 from users page" do
+            expect(response).to have_http_status(:not_found)
+          end
+        end
+      end
+
       describe "#edit" do
         before do
           get "/organisations/#{organisation.id}/edit", headers:, params: {}