Browse Source

CLDC-3154 Update reasonable preference hint for 24/25 (#2185)

* feat: update hint text for 24 and test

* feat: update test

* feat: update copy
pull/2195/head
natdeanlewissoftwire 11 months ago committed by GitHub
parent
commit
bb098f3dd5
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
  1. 2
      app/models/form/lettings/questions/reasonpref.rb
  2. 77
      spec/models/form/lettings/questions/reasonpref_spec.rb

2
app/models/form/lettings/questions/reasonpref.rb

@ -6,7 +6,7 @@ class Form::Lettings::Questions::Reasonpref < ::Form::Question
@header = "Was the household given ‘reasonable preference’ by the local authority?" @header = "Was the household given ‘reasonable preference’ by the local authority?"
@type = "radio" @type = "radio"
@check_answers_card_number = 0 @check_answers_card_number = 0
@hint_text = "Households may be given ‘reasonable preference’ for social housing, also known as ‘priority need’, by the local authority." @hint_text = form.start_year_after_2024? ? "Households may be given ‘reasonable preference’ for social housing under one or more specific categories by the local authority. This is also known as ‘priority need’." : "Households may be given ‘reasonable preference’ for social housing, also known as ‘priority need’, by the local authority."
@answer_options = ANSWER_OPTIONS @answer_options = ANSWER_OPTIONS
@question_number = 82 @question_number = 82
end end

77
spec/models/form/lettings/questions/reasonpref_spec.rb

@ -0,0 +1,77 @@
require "rails_helper"
RSpec.describe Form::Lettings::Questions::Reasonpref, type: :model do
subject(:question) { described_class.new(nil, question_definition, page) }
let(:question_definition) { nil }
let(:page) { instance_double(Form::Page) }
let(:subsection) { instance_double(Form::Subsection) }
let(:form) { instance_double(Form) }
before do
allow(form).to receive(:start_year_after_2024?).and_return(false)
allow(page).to receive(:subsection).and_return(subsection)
allow(subsection).to receive(:form).and_return(form)
end
it "has correct page" do
expect(question.page).to eq(page)
end
it "has the correct type" do
expect(question.type).to eq("radio")
end
it "is not marked as derived" do
expect(question.derived?).to be false
end
it "has the correct answer_options" do
expect(question.answer_options).to eq({
"1" => { "value" => "Yes" },
"2" => { "value" => "No" },
"3" => { "value" => "Don’t know" },
"divider" => { "value" => true },
})
end
it "has the correct check_answer_label" do
expect(question.check_answer_label).to eq("Household given reasonable preference")
end
it "has the correct id" do
expect(question.id).to eq("reasonpref")
end
it "has the correct header" do
expect(question.header).to eq("Was the household given ‘reasonable preference’ by the local authority?")
end
it "has correct conditional for" do
expect(question.conditional_for).to be_nil
end
it "has the correct hidden_in_check_answers" do
expect(question.hidden_in_check_answers).to be_nil
end
it "has the correct check_answers_card_number" do
expect(question.check_answers_card_number).to eq(0)
end
context "with 2023/24 form" do
it "has the correct hint" do
expect(question.hint_text).to eq("Households may be given ‘reasonable preference’ for social housing, also known as ‘priority need’, by the local authority.")
end
end
context "with 2024/25 form" do
before do
allow(form).to receive(:start_year_after_2024?).and_return(true)
end
it "has the correct hint" do
expect(question.hint_text).to eq("Households may be given ‘reasonable preference’ for social housing under one or more specific categories by the local authority. This is also known as ‘priority need’.")
end
end
end
Loading…
Cancel
Save