From c036bcb171111fcaa1bd965284f58bbe089744cb Mon Sep 17 00:00:00 2001 From: Samuel Young Date: Thu, 22 Jan 2026 14:33:46 +0000 Subject: [PATCH] CLDC-4115: Ensure page is loaded before running accessibility tests unclear whether this will make a difference, will push now and run the pipeline a couple times --- spec/features/accessibility_spec.rb | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/spec/features/accessibility_spec.rb b/spec/features/accessibility_spec.rb index 889fcdf26..9f9e62295 100644 --- a/spec/features/accessibility_spec.rb +++ b/spec/features/accessibility_spec.rb @@ -44,6 +44,8 @@ RSpec.describe "Accessibility", js: true do it "is has accessible pages" do user_paths.each do |path| visit(path) + wait = Selenium::WebDriver::Wait.new(timeout: 10) + wait.until { execute_script("return document.readyState") == "complete" } expect(page).to have_current_path(path) expect(page).to be_axe_clean.according_to :wcag2aa end @@ -77,6 +79,8 @@ RSpec.describe "Accessibility", js: true do it "is has accessible pages" do organisation_paths.each do |path| visit(path) + wait = Selenium::WebDriver::Wait.new(timeout: 10) + wait.until { execute_script("return document.readyState") == "complete" } expect(page).to have_current_path(path) expect(page).to be_axe_clean.according_to :wcag2aa end @@ -120,6 +124,8 @@ RSpec.describe "Accessibility", js: true do path.gsub!("/start", "/prepare-your-file?form[year]=2024") if path.include?("bulk-upload-logs/start") path.gsub!("/start", "/fix-choice") if path.include?("/bulk-upload-resume/#{bulk_upload.id}/start") visit(path) + wait = Selenium::WebDriver::Wait.new(timeout: 10) + wait.until { execute_script("return document.readyState") == "complete" } expect(page).to have_current_path(path) expect(page).to be_axe_clean.according_to :wcag2aa end @@ -164,6 +170,8 @@ RSpec.describe "Accessibility", js: true do path.gsub!("/start", "/fix-choice") if path.include?("/bulk-upload-resume/#{bulk_upload.id}/start") visit(path) + wait = Selenium::WebDriver::Wait.new(timeout: 10) + wait.until { execute_script("return document.readyState") == "complete" } expect(page).to have_current_path(path) expect(page).to be_axe_clean.according_to :wcag2aa end @@ -189,6 +197,8 @@ RSpec.describe "Accessibility", js: true do it "is has accessible pages" do scheme_paths.each do |path| visit(path) + wait = Selenium::WebDriver::Wait.new(timeout: 10) + wait.until { execute_script("return document.readyState") == "complete" } expect(page).to have_current_path(path) expect(page).to be_axe_clean.according_to :wcag2aa end @@ -203,6 +213,8 @@ RSpec.describe "Accessibility", js: true do { path: "/sales-logs/bulk-upload-logs/guidance?form[year]=2024&referrer=home", title: "sales BU guidance" }].each do |test_case| it "is has accessible #{test_case[:title]} page" do visit(test_case[:path]) + wait = Selenium::WebDriver::Wait.new(timeout: 10) + wait.until { execute_script("return document.readyState") == "complete" } expect(page).to have_current_path(test_case[:path]) expect(page).to be_axe_clean.according_to :wcag2aa end