From c06f7eb46844489087efbd47e0a4dcdb28a54ab3 Mon Sep 17 00:00:00 2001 From: natdeanlewissoftwire Date: Fri, 9 Jun 2023 17:57:03 +0100 Subject: [PATCH] refactor: lint --- spec/models/sales_log_spec.rb | 1 + spec/services/bulk_upload/sales/log_creator_spec.rb | 1 + spec/services/bulk_upload/sales/validator_spec.rb | 1 + spec/services/bulk_upload/sales/year2022/row_parser_spec.rb | 1 - 4 files changed, 3 insertions(+), 1 deletion(-) diff --git a/spec/models/sales_log_spec.rb b/spec/models/sales_log_spec.rb index a660ea0ed..f2337b84d 100644 --- a/spec/models/sales_log_spec.rb +++ b/spec/models/sales_log_spec.rb @@ -162,6 +162,7 @@ RSpec.describe SalesLog, type: :model do describe "derived variables" do let(:sales_log) { create(:sales_log, :completed) } + around do |example| Timecop.freeze(Time.zone.local(2022, 7, 4)) do example.run diff --git a/spec/services/bulk_upload/sales/log_creator_spec.rb b/spec/services/bulk_upload/sales/log_creator_spec.rb index 299da7853..7e0082311 100644 --- a/spec/services/bulk_upload/sales/log_creator_spec.rb +++ b/spec/services/bulk_upload/sales/log_creator_spec.rb @@ -18,6 +18,7 @@ RSpec.describe BulkUpload::Sales::LogCreator do Timecop.return Singleton.__init__(FormHandler) end + context "when a valid csv with new log" do it "creates a new log" do expect { service.call }.to change(SalesLog, :count) diff --git a/spec/services/bulk_upload/sales/validator_spec.rb b/spec/services/bulk_upload/sales/validator_spec.rb index f9c642dda..851109772 100644 --- a/spec/services/bulk_upload/sales/validator_spec.rb +++ b/spec/services/bulk_upload/sales/validator_spec.rb @@ -69,6 +69,7 @@ RSpec.describe BulkUpload::Sales::Validator do after do Timecop.unfreeze end + it "is not valid" do expect(validator).not_to be_valid end diff --git a/spec/services/bulk_upload/sales/year2022/row_parser_spec.rb b/spec/services/bulk_upload/sales/year2022/row_parser_spec.rb index 004e4977e..9da1fbe79 100644 --- a/spec/services/bulk_upload/sales/year2022/row_parser_spec.rb +++ b/spec/services/bulk_upload/sales/year2022/row_parser_spec.rb @@ -107,7 +107,6 @@ RSpec.describe BulkUpload::Sales::Year2022::RowParser do } end - around do |example| Timecop.freeze(Time.zone.local(2023, 2, 22)) do Singleton.__init__(FormHandler)