From 7d0f207f42c560a58c0c23e385e6568232f8bcfd Mon Sep 17 00:00:00 2001 From: magicmilo Date: Tue, 26 Oct 2021 00:45:45 +0100 Subject: [PATCH 1/2] RemoveUnusedLinesInTotalQuestions --- app/helpers/check_answers_helper.rb | 3 --- 1 file changed, 3 deletions(-) diff --git a/app/helpers/check_answers_helper.rb b/app/helpers/check_answers_helper.rb index 16f07032d..3e59de811 100644 --- a/app/helpers/check_answers_helper.rb +++ b/app/helpers/check_answers_helper.rb @@ -16,9 +16,6 @@ module CheckAnswersHelper while page_name.to_s != "check_answers" && subsection_keys.include?(page_name) questions = form.questions_for_page(page_name) - question_key = questions.keys[0] - question_value = questions.values[0] - applicable_questions = filter_conditional_questions(questions, case_log) total_questions = total_questions.merge(applicable_questions) From e93e58b853eedb5248fc502ad9fcb7bfd1adcbb7 Mon Sep 17 00:00:00 2001 From: baarkerlounger Date: Tue, 26 Oct 2021 10:05:49 +0100 Subject: [PATCH 2/2] Rubocop --- app/models/case_log.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/models/case_log.rb b/app/models/case_log.rb index 1ddef13a0..aad4d23b0 100644 --- a/app/models/case_log.rb +++ b/app/models/case_log.rb @@ -38,7 +38,7 @@ class CaseLogValidator < ActiveModel::Validator record.errors.add :other_reason_for_leaving_last_settled_home, "The other reason must not be provided if the reason for leaving settled home was not other" end end - + def validate_reason_for_leaving_last_settled_home(record) if record.reason_for_leaving_last_settled_home == "Do not know" && record.benefit_cap_spare_room_subsidy != "Do not know" record.errors.add :benefit_cap_spare_room_subsidy, "must be do not know if tenant’s main reason for leaving is do not know"