From c53f7298af20d60c2a9634a9c6753419fd6e74df Mon Sep 17 00:00:00 2001
From: Paul Robert Lloyd <me+git@paulrobertlloyd.com>
Date: Tue, 26 Apr 2022 16:52:35 +0100
Subject: [PATCH] Refactor document list component to have better semantics

---
 app/components/document_list_component.html.erb | 16 ++++++++--------
 app/frontend/styles/_document-list.scss         |  7 -------
 2 files changed, 8 insertions(+), 15 deletions(-)

diff --git a/app/components/document_list_component.html.erb b/app/components/document_list_component.html.erb
index 6242ab3dc..c5b7affc5 100644
--- a/app/components/document_list_component.html.erb
+++ b/app/components/document_list_component.html.erb
@@ -1,15 +1,15 @@
-<ul class="app-document-list">
+<dl class="app-document-list">
   <% items.each do |item| %>
-    <li class="app-document-list__item">
-      <h3 class="app-document-list__item-title">
+    <div class="app-document-list__item">
+      <dt class="app-document-list__item-title">
         <%= govuk_link_to item[:name], item[:href] %>
-      </h3>
+      </dt>
       <% if item[:description] %>
-        <p class="app-document-list__item-description"><%= item[:description] %></p>
+        <dd class="app-document-list__item-description"><%= item[:description] %></dd>
       <% end %>
       <% if item[:metadata] %>
-        <p class="app-document-list__item-metadata"><%= item[:metadata] %></p>
+        <dd class="app-document-list__item-metadata"><%= item[:metadata] %></dd>
       <% end %>
-    </li>
+    </div>
   <% end %>
-</ul>
+</dl>
diff --git a/app/frontend/styles/_document-list.scss b/app/frontend/styles/_document-list.scss
index c510e52b2..d3f632b27 100644
--- a/app/frontend/styles/_document-list.scss
+++ b/app/frontend/styles/_document-list.scss
@@ -1,15 +1,8 @@
-.app-document-list {
-  list-style: none;
-  padding: 0;
-}
-
 .app-document-list__item {
   margin-bottom: govuk-spacing(4);
 
   &:last-child {
-    border-bottom: 0;
     margin-bottom: 0;
-    padding-bottom: 0;
   }
 }