From c8df193bf2ddbfe2619fd7c5dc9788f1244d6b70 Mon Sep 17 00:00:00 2001
From: Kat <54268893+kosiakkatrina@users.noreply.github.com>
Date: Thu, 6 Mar 2025 08:56:41 +0000
Subject: [PATCH] Add mrentprestaircasing, update factory and tests

---
 app/services/exports/sales_log_export_constants.rb | 1 +
 spec/factories/sales_log.rb                        | 5 -----
 spec/fixtures/exports/sales_log.xml                | 1 +
 spec/fixtures/exports/sales_log_2024.xml           | 3 ++-
 spec/services/exports/export_service_spec.rb       | 3 ++-
 5 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/app/services/exports/sales_log_export_constants.rb b/app/services/exports/sales_log_export_constants.rb
index d286b40ac..459925f43 100644
--- a/app/services/exports/sales_log_export_constants.rb
+++ b/app/services/exports/sales_log_export_constants.rb
@@ -57,6 +57,7 @@ module Exports::SalesLogExportConstants
                       "stairbought",
                       "stairowned",
                       "mrent",
+                      "mrentprestaircasing",
                       "resale",
                       "deposit",
                       "cashdis",
diff --git a/spec/factories/sales_log.rb b/spec/factories/sales_log.rb
index 344aebaab..ebb85fb4c 100644
--- a/spec/factories/sales_log.rb
+++ b/spec/factories/sales_log.rb
@@ -270,11 +270,6 @@ FactoryBot.define do
       value { 110_000 }
       value_value_check { 0 }
       grant { 10_000 }
-      proplen { 10 }
-      pregyrha { 1 }
-      pregla { 1 }
-      pregother { 1 }
-      pregghb { 1 }
       hhregres { 7 }
       ppcodenk { 1 }
       prevten { 1 }
diff --git a/spec/fixtures/exports/sales_log.xml b/spec/fixtures/exports/sales_log.xml
index fb59de54e..6a9f02abe 100644
--- a/spec/fixtures/exports/sales_log.xml
+++ b/spec/fixtures/exports/sales_log.xml
@@ -89,6 +89,7 @@
     <address_search_value_check/>
     <firststair/>
     <numstair/>
+    <mrentprestaircasing/>
     <day>1</day>
     <month>3</month>
     <year>2026</year>
diff --git a/spec/fixtures/exports/sales_log_2024.xml b/spec/fixtures/exports/sales_log_2024.xml
index caf57e7cf..5f49b8ffa 100644
--- a/spec/fixtures/exports/sales_log_2024.xml
+++ b/spec/fixtures/exports/sales_log_2024.xml
@@ -66,7 +66,7 @@
     <prevloc>E09000033</prevloc>
     <hhregres>7</hhregres>
     <hhregresstill/>
-    <proplen>10</proplen>
+    <proplen/>
     <mscharge>100.0</mscharge>
     <prevten>1</prevten>
     <mortgageused>1</mortgageused>
@@ -89,6 +89,7 @@
     <address_search_value_check/>
     <firststair/>
     <numstair/>
+    <mrentprestaircasing/>
     <day>3</day>
     <month>4</month>
     <year>2024</year>
diff --git a/spec/services/exports/export_service_spec.rb b/spec/services/exports/export_service_spec.rb
index 160c80a01..051a0f38d 100644
--- a/spec/services/exports/export_service_spec.rb
+++ b/spec/services/exports/export_service_spec.rb
@@ -26,6 +26,8 @@ RSpec.describe Exports::ExportService do
   end
 
   context "when exporting daily XMLs before 2025" do
+    let(:start_time) { Time.zone.local(2022, 5, 1) }
+
     context "and no lettings archives get created in lettings logs export" do
       let(:lettings_logs_export_service) { instance_double("Exports::LettingsLogExportService", export_xml_lettings_logs: {}) }
 
@@ -394,7 +396,6 @@ RSpec.describe Exports::ExportService do
   context "with date after 2025-04-01" do
     let(:start_time) { Time.zone.local(2025, 5, 1) }
     let(:expected_master_manifest_filename) { "Manifest_2025_05_01_0001.csv" }
-    let(:lettings_logs_export_service) { instance_double("Exports::LettingsLogExportService", export_xml_lettings_logs: {}) }
 
     context "when exporting daily XMLs" do
       context "and no sales archives get created in sales logs export" do