From cc407b3b7863b6ac281ddf8996260d6b5ea90c12 Mon Sep 17 00:00:00 2001 From: samyou-softwire Date: Thu, 19 Feb 2026 17:50:44 +0000 Subject: [PATCH] fixup! CLDC-4119: Update duplicate logs page improve duplicate_logs_helper.rb --- app/helpers/duplicate_logs_helper.rb | 21 ++++++++------------- 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/app/helpers/duplicate_logs_helper.rb b/app/helpers/duplicate_logs_helper.rb index 92490c10f..228b4a6c6 100644 --- a/app/helpers/duplicate_logs_helper.rb +++ b/app/helpers/duplicate_logs_helper.rb @@ -75,21 +75,16 @@ module DuplicateLogsHelper end def duplicate_log_extra_value(question, log) - if log.form.start_year_2026_or_later? - case question.id - when "uprn" - value = [ - log.address_line1, - log.postcode_full, - ].select(&:present?) - - "\n\n#{value.join("\n")}" + case question.id + when "uprn" + if log.form.start_year_2026_or_later? + "\n\n#{[log.address_line1, log.postcode_full].join("\n")}" else - question.get_extra_check_answer_value(log) + postcode_question = log.form.get_question("postcode_full", log) + postcode_question.get_extra_check_answer_value(log) end - elsif question.id == "uprn" && !log.form.start_year_2026_or_later? - postcode_question = log.form.get_question("postcode_full", log) - postcode_question.get_extra_check_answer_value(log) + else + question.get_extra_check_answer_value(log) end end