From cd1694fe69868a39daa89db5980722e000f7e733 Mon Sep 17 00:00:00 2001
From: Kat <54268893+kosiakkatrina@users.noreply.github.com>
Date: Wed, 13 Nov 2024 10:37:49 +0000
Subject: [PATCH] Rename household needs occurences

---
 app/models/form/sales/sections/household.rb                | 2 +-
 app/models/form/sales/subsections/household_needs.rb       | 4 ++--
 config/locales/forms/2023/sales/household_needs.en.yml     | 2 +-
 config/locales/forms/2024/sales/household_needs.en.yml     | 2 +-
 config/locales/forms/2025/sales/household_needs.en.yml     | 2 +-
 spec/models/form/sales/sections/household_spec.rb          | 2 +-
 spec/models/form/sales/subsections/household_needs_spec.rb | 4 ++--
 7 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/app/models/form/sales/sections/household.rb b/app/models/form/sales/sections/household.rb
index e8bcc1451..674f38197 100644
--- a/app/models/form/sales/sections/household.rb
+++ b/app/models/form/sales/sections/household.rb
@@ -7,7 +7,7 @@ class Form::Sales::Sections::Household < ::Form::Section
     @subsections = [
       Form::Sales::Subsections::HouseholdCharacteristics.new(nil, nil, self),
       Form::Sales::Subsections::HouseholdSituation.new(nil, nil, self),
-      Form::Sales::Subsections::HouseholdNeeds.new(nil, nil, self),
+      Form::Sales::Subsections::OtherHouseholdInformation.new(nil, nil, self),
     ]
   end
 end
diff --git a/app/models/form/sales/subsections/household_needs.rb b/app/models/form/sales/subsections/household_needs.rb
index a419cff95..3acc9ffd5 100644
--- a/app/models/form/sales/subsections/household_needs.rb
+++ b/app/models/form/sales/subsections/household_needs.rb
@@ -1,7 +1,7 @@
-class Form::Sales::Subsections::HouseholdNeeds < ::Form::Subsection
+class Form::Sales::Subsections::OtherHouseholdInformation < ::Form::Subsection
   def initialize(id, hsh, section)
     super
-    @id = "household_needs"
+    @id = "other_household_information"
     @label = "Other household information"
     @depends_on = [{ "setup_completed?" => true }]
   end
diff --git a/config/locales/forms/2023/sales/household_needs.en.yml b/config/locales/forms/2023/sales/household_needs.en.yml
index f4a13e47a..6d96ca46e 100644
--- a/config/locales/forms/2023/sales/household_needs.en.yml
+++ b/config/locales/forms/2023/sales/household_needs.en.yml
@@ -2,7 +2,7 @@ en:
   forms:
     2023:
       sales:
-        household_needs:
+        other_household_information:
           hhregres:
             page_header: ""
             check_answer_label: "Have any of the buyers ever served as a regular in the UK armed forces?"
diff --git a/config/locales/forms/2024/sales/household_needs.en.yml b/config/locales/forms/2024/sales/household_needs.en.yml
index 290543a34..8363c5108 100644
--- a/config/locales/forms/2024/sales/household_needs.en.yml
+++ b/config/locales/forms/2024/sales/household_needs.en.yml
@@ -2,7 +2,7 @@ en:
   forms:
     2024:
       sales:
-        household_needs:
+        other_household_information:
           hhregres:
             page_header: ""
             check_answer_label: "Have any of the buyers ever served as a regular in the UK armed forces?"
diff --git a/config/locales/forms/2025/sales/household_needs.en.yml b/config/locales/forms/2025/sales/household_needs.en.yml
index 1908ba6ca..ddae70ffa 100644
--- a/config/locales/forms/2025/sales/household_needs.en.yml
+++ b/config/locales/forms/2025/sales/household_needs.en.yml
@@ -2,7 +2,7 @@ en:
   forms:
     2025:
       sales:
-        household_needs:
+        other_household_information:
           hhregres:
             page_header: ""
             check_answer_label: "Have any of the buyers ever served as a regular in the UK armed forces?"
diff --git a/spec/models/form/sales/sections/household_spec.rb b/spec/models/form/sales/sections/household_spec.rb
index cff166510..d747d171d 100644
--- a/spec/models/form/sales/sections/household_spec.rb
+++ b/spec/models/form/sales/sections/household_spec.rb
@@ -16,7 +16,7 @@ RSpec.describe Form::Sales::Sections::Household, type: :model do
       %w[
         household_characteristics
         household_situation
-        household_needs
+        other_household_information
       ],
     )
   end
diff --git a/spec/models/form/sales/subsections/household_needs_spec.rb b/spec/models/form/sales/subsections/household_needs_spec.rb
index cd4ff67fa..461ad2cc9 100644
--- a/spec/models/form/sales/subsections/household_needs_spec.rb
+++ b/spec/models/form/sales/subsections/household_needs_spec.rb
@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe Form::Sales::Subsections::HouseholdNeeds, type: :model do
+RSpec.describe Form::Sales::Subsections::OtherHouseholdInformation, type: :model do
   subject(:household_characteristics) { described_class.new(subsection_id, subsection_definition, section) }
 
   let(:subsection_id) { nil }
@@ -27,7 +27,7 @@ RSpec.describe Form::Sales::Subsections::HouseholdNeeds, type: :model do
   end
 
   it "has the correct id" do
-    expect(household_characteristics.id).to eq("household_needs")
+    expect(household_characteristics.id).to eq("other_household_information")
   end
 
   it "has the correct label" do