From cdb8f7211008330a5a11355b3a59c9ba8f2c697c Mon Sep 17 00:00:00 2001 From: Rachael Booth Date: Mon, 18 Nov 2024 17:27:34 +0000 Subject: [PATCH] Update tests --- spec/models/form/page_spec.rb | 4 ++-- spec/models/form/question_spec.rb | 4 ++-- spec/models/form/subsection_spec.rb | 4 ++++ 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/spec/models/form/page_spec.rb b/spec/models/form/page_spec.rb index 9315fb237..3ec929fc4 100644 --- a/spec/models/form/page_spec.rb +++ b/spec/models/form/page_spec.rb @@ -9,7 +9,7 @@ RSpec.describe Form::Page, type: :model do let(:enabled) { true } let(:depends_on_met) { true } let(:form) { instance_double(Form, depends_on_met:, type: "form-type", start_date: Time.utc(2024, 12, 25)) } - let(:subsection) { instance_double(Form::Subsection, depends_on:, enabled?: enabled, form:, id: "subsection-id") } + let(:subsection) { instance_double(Form::Subsection, depends_on:, enabled?: enabled, form:, id: "subsection-id", copy_key: "subsection-copy-key") } let(:page_id) { "net_income" } let(:questions) { [["earnings", { "conditional_for" => { "age1": nil }, "type" => "radio" }], %w[incfreq]] } let(:page_definition) do @@ -25,7 +25,7 @@ RSpec.describe Form::Page, type: :model do end it "sets copy_key in the default style" do - expect(page.copy_key).to eq("#{form.type}.#{subsection.id}.#{questions[0][0]}") + expect(page.copy_key).to eq("#{form.type}.#{subsection.copy_key}.#{questions[0][0]}") end context "when header is not provided" do diff --git a/spec/models/form/question_spec.rb b/spec/models/form/question_spec.rb index 651d167bd..8b9ab7a85 100644 --- a/spec/models/form/question_spec.rb +++ b/spec/models/form/question_spec.rb @@ -15,7 +15,7 @@ RSpec.describe Form::Question, type: :model do let(:inferred_check_answers_value) { [{ "condition" => { "postcode_known" => 0 }, "value" => "Weekly" }] } let(:form) { instance_double(Form, depends_on_met:, conditional_question_conditions:, type: "form-type", start_date: Time.utc(2024, 12, 25)) } - let(:subsection) { instance_double(Form::Subsection, form:, id: "subsection-id") } + let(:subsection) { instance_double(Form::Subsection, form:, id: "subsection-id", copy_key: "subsection-copy-key") } let(:page) { instance_double(Form::Page, subsection:, routed_to?: true, questions: form_questions) } let(:question_id) { "earnings" } let(:question_definition) do @@ -39,7 +39,7 @@ RSpec.describe Form::Question, type: :model do end it "sets copy_key in the default style" do - expect(question.copy_key).to eq("#{form.type}.#{subsection.id}.#{question_id}") + expect(question.copy_key).to eq("#{form.type}.#{subsection.copy_key}.#{question_id}") end context "when copy is not provided" do diff --git a/spec/models/form/subsection_spec.rb b/spec/models/form/subsection_spec.rb index 8a4b9d3d7..0215e51dc 100644 --- a/spec/models/form/subsection_spec.rb +++ b/spec/models/form/subsection_spec.rb @@ -19,6 +19,10 @@ RSpec.describe Form::Subsection, type: :model do expect(subsection.id).to eq(subsection_id) end + it "has a copy_key defaulting to the id" do + expect(subsection.copy_key).to eq(subsection_id) + end + it "has a label" do expect(subsection.label).to eq("Household characteristics") end