From d032c7ffc13939bac2e6877e9673d5c1e5fcbb33 Mon Sep 17 00:00:00 2001 From: kosiakkatrina <54268893+kosiakkatrina@users.noreply.github.com> Date: Fri, 26 Jan 2024 08:06:42 +0000 Subject: [PATCH] Move void date quidance to the top (#2164) --- app/models/form/lettings/pages/void_date.rb | 1 + app/models/form/lettings/questions/voiddate.rb | 2 +- spec/models/form/lettings/pages/void_date_spec.rb | 2 +- spec/models/form/lettings/questions/voiddate_spec.rb | 4 ++-- 4 files changed, 5 insertions(+), 4 deletions(-) diff --git a/app/models/form/lettings/pages/void_date.rb b/app/models/form/lettings/pages/void_date.rb index 5ba80d41e..2187ebe57 100644 --- a/app/models/form/lettings/pages/void_date.rb +++ b/app/models/form/lettings/pages/void_date.rb @@ -2,6 +2,7 @@ class Form::Lettings::Pages::VoidDate < ::Form::Page def initialize(id, hsh, subsection) super @id = "void_date" + @header = "Void date" @depends_on = [{ "is_renewal?" => false }] end diff --git a/app/models/form/lettings/questions/voiddate.rb b/app/models/form/lettings/questions/voiddate.rb index d20219b0b..38064bb3e 100644 --- a/app/models/form/lettings/questions/voiddate.rb +++ b/app/models/form/lettings/questions/voiddate.rb @@ -7,6 +7,6 @@ class Form::Lettings::Questions::Voiddate < ::Form::Question @type = "date" @check_answers_card_number = 0 @question_number = 23 - @bottom_guidance_partial = "void_date" + @top_guidance_partial = "void_date" end end diff --git a/spec/models/form/lettings/pages/void_date_spec.rb b/spec/models/form/lettings/pages/void_date_spec.rb index c2eb8004a..0d5e1689a 100644 --- a/spec/models/form/lettings/pages/void_date_spec.rb +++ b/spec/models/form/lettings/pages/void_date_spec.rb @@ -20,7 +20,7 @@ RSpec.describe Form::Lettings::Pages::VoidDate, type: :model do end it "has the correct header" do - expect(page.header).to be_nil + expect(page.header).to eq("Void date") end it "has the correct description" do diff --git a/spec/models/form/lettings/questions/voiddate_spec.rb b/spec/models/form/lettings/questions/voiddate_spec.rb index c8198bc89..aa3270d89 100644 --- a/spec/models/form/lettings/questions/voiddate_spec.rb +++ b/spec/models/form/lettings/questions/voiddate_spec.rb @@ -31,8 +31,8 @@ RSpec.describe Form::Lettings::Questions::Voiddate, type: :model do expect(question.question_number).to eq(23) end - it "has the correct bottom_guidance_partial" do - expect(question.bottom_guidance_partial).to eq("void_date") + it "has the correct top_guidance_partial" do + expect(question.top_guidance_partial).to eq("void_date") end it "has the correct type" do