From d3077ae156b2ede00d9931e81ce21b4c39f12fdb Mon Sep 17 00:00:00 2001 From: Manny Dinssa <44172848+Dinssa@users.noreply.github.com> Date: Tue, 26 Nov 2024 10:50:29 +0000 Subject: [PATCH] Updates --- spec/factories/location.rb | 2 +- spec/models/location_spec.rb | 36 ++++++++++++++++--- .../validations/setup_validations_spec.rb | 4 +-- 3 files changed, 35 insertions(+), 7 deletions(-) diff --git a/spec/factories/location.rb b/spec/factories/location.rb index 19f874d44..00fa0d77f 100644 --- a/spec/factories/location.rb +++ b/spec/factories/location.rb @@ -22,7 +22,7 @@ FactoryBot.define do end trait :incomplete do - mobility_type { nil } + units { nil } confirmed { false } end diff --git a/spec/models/location_spec.rb b/spec/models/location_spec.rb index 1d43df6ab..db317a351 100644 --- a/spec/models/location_spec.rb +++ b/spec/models/location_spec.rb @@ -740,10 +740,38 @@ RSpec.describe Location, type: :model do describe "#units" do let(:location) { FactoryBot.build(:location) } - it "does add an error when the number of units is invalid" do - location.units = nil - location.valid?(:units) - expect(location.errors.count).to eq(2) + context "when the number of units is invalid" do + it "adds an error when units is nil" do + location.units = nil + location.valid?(:units) + expect(location.errors.count).to eq(2) + end + + it "adds an error when units is 0" do + location.units = 0 + location.valid?(:units) + expect(location.errors.count).to eq(2) + end + end + + context "when the number of units is valid" do + it "does not add an error when units is 1" do + location.units = 1 + location.valid?(:units) + expect(location.errors.count).to eq(0) + end + + it "does not add an error when units is 10" do + location.units = 10 + location.valid?(:units) + expect(location.errors.count).to eq(0) + end + + it "does not add an error when units is 200" do + location.units = 200 + location.valid?(:units) + expect(location.errors.count).to eq(0) + end end end diff --git a/spec/models/validations/setup_validations_spec.rb b/spec/models/validations/setup_validations_spec.rb index bbe264f55..1104cc23d 100644 --- a/spec/models/validations/setup_validations_spec.rb +++ b/spec/models/validations/setup_validations_spec.rb @@ -703,8 +703,8 @@ RSpec.describe Validations::SetupValidations do .to include("This location is incomplete. Select another location or update this one.") end - it "produces no error when location is completes" do - location.update!(mobility_type: "A") + it "produces no error when location is complete" do + location.update!(units: 1) location.reload record.location = location setup_validator.validate_location(record)