From d3219b9ba3055c6c4ea4dcb87944570251790090 Mon Sep 17 00:00:00 2001
From: Manny Dinssa <44172848+Dinssa@users.noreply.github.com>
Date: Wed, 12 Mar 2025 14:34:35 +0000
Subject: [PATCH] Add error handling for JSON parsing in UPRN client (#2989)

* Add error handling for JSON parsing in UPRN client

* Update error handling

* Update error handling 2
---
 app/services/uprn_client.rb | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/app/services/uprn_client.rb b/app/services/uprn_client.rb
index 97dc4753f..f170ba3a0 100644
--- a/app/services/uprn_client.rb
+++ b/app/services/uprn_client.rb
@@ -20,7 +20,14 @@ class UprnClient
   end
 
   def result
-    @result ||= JSON.parse(response.body).dig("results", 0, "DPA") || JSON.parse(response.body).dig("results", 0, "LPI")
+    @result ||= if response.is_a?(Net::HTTPSuccess)
+                  parsed_response = JSON.parse(response.body)
+                  parsed_response.dig("results", 0, "DPA") || parsed_response.dig("results", 0, "LPI")
+                else
+                  Rails.logger.error("Response code: #{response.code}")
+                  Rails.logger.error("Response body: #{response.body}")
+                  nil
+                end
   end
 
 private