Remove redundant logic from infer_at_most_one_relationship!

4 days ago · d7e0c9f940
1 changed files with 3 additions and 5 deletions
--- a/app/models/derived_variables/lettings_log_variables.rb
+++ b/app/models/derived_variables/lettings_log_variables.rb
@ -331,11 +331,9 @@ private

  def infer_at_most_one_relationship!
    new_partner_numbers = partner_numbers.select { |i| public_send("relat#{i}_changed?") }
-    if new_partner_numbers.any?
-      infer_only_partner!(new_partner_numbers.first)
-    elsif partner_numbers.any?
-      infer_only_partner!(partner_numbers.first)
-    end
+    return unless new_partner_numbers.any?
+
+    infer_only_partner!(new_partner_numbers.first)
  end

  def infer_only_partner!(partner_number)