* feat: add 2022 rent range data, update rake task for population of this
* feat: change file format so ranges_rent_id is recognised
* feat: add updated error messages and casing
* tests: make tests pass
* feat: ensure there is a location_code in all locations and use this (and beds = 0) for supported housing rent validations
* feat: fix general needs validation behaviour
* feat: add local authorities enum to location.rb
* feat: ensure case when beds > 4 is accounted for
* feat: add error messages on property postcode page as well as la page
* feat: add error messages on scheme_id and location_id as well as la page
* feat: add error messages on scheme_id and location_id as well as la page
* feat: null coalescing and validations on changing las to one that invalidates rent in supported housing
* feat: nil protection
* refactor: linting
* refactor: combining duplicated logic
* tests: add hard validation tests split by needstype
* feat: update validations when beds > 4
* feat: update validations when beds > 4
* refactor: simplification, use preivous la method
* refactor: response to PR comments, fixing beds.negative validation
* feat: remove dynamic local auth name text from interruption screens - to be added back in later if this becomes a priority, would need some work on adding local auth name to log for supported housing logs not just leaving it in the location
one_seven_bedroom_shared:"A shared house must have 1 to 7 bedrooms"
one_seven_bedroom_shared:"A shared house must have 1 to 7 bedrooms"
one_three_bedroom_single_tenant_shared:"A shared house with fewer than two tenants must have 1 to 3 bedrooms"
one_three_bedroom_single_tenant_shared:"A shared house with fewer than two tenants must have 1 to 3 bedrooms"
beds:
beds:
negative:"Number of bedrooms has to be greater than 0"
non_positive:"Number of bedrooms has to be greater than 0"
over_max:"Number of bedrooms cannot be more than 12"
over_max:"Number of bedrooms cannot be more than 12"
financial:
financial:
@ -190,6 +190,15 @@ en:
brent:
brent:
below_hard_min:"Rent is below the absolute minimum expected for a property of this type. Please check the rent, rent period, local authority and (if general needs) number of bedrooms"
below_hard_min:"Rent is below the absolute minimum expected for a property of this type. Please check the rent, rent period, local authority and (if general needs) number of bedrooms"
above_hard_max:"Rent is higher than the absolute maximum expected for a property of this type. Please check the rent, rent period, local authority and (if general needs) number of bedrooms"
above_hard_max:"Rent is higher than the absolute maximum expected for a property of this type. Please check the rent, rent period, local authority and (if general needs) number of bedrooms"
scheme_id:
below_hard_min:"Rent is below the absolute minimum expected for a property of this type. Please check the rent, rent period and local authority"
above_hard_max:"Rent is higher than the absolute maximum expected for a property of this type. Please check the rent, rent period and local authority"
location_id:
below_hard_min:"Rent is below the absolute minimum expected for a property of this type. Please check the rent, rent period and local authority"
above_hard_max:"Rent is higher than the absolute maximum expected for a property of this type. Please check the rent, rent period and local authority"
postcode_known:
below_hard_min:"Rent is below the absolute minimum expected for a property of this type. Please check the rent, rent period, local authority and number of bedrooms"
above_hard_max:"Rent is higher than the absolute maximum expected for a property of this type. Please check the rent, rent period, local authority and number of bedrooms"
la:
la:
below_hard_min:"Rent is below the absolute minimum expected for a property of this type based on this local authority"
below_hard_min:"Rent is below the absolute minimum expected for a property of this type based on this local authority"
above_hard_max:"Rent is higher than the absolute maximum expected for a property of this type based on this local authority"
above_hard_max:"Rent is higher than the absolute maximum expected for a property of this type based on this local authority"
@ -313,10 +322,10 @@ en:
rent:
rent:
min:
min:
title_text:"You told us the rent is %{brent}"
title_text:"You told us the rent is %{brent}"
hint_text:"The minimum rent expected for this type of property in %{la} is £%{soft_min_for_period}."
hint_text:"The minimum rent expected for this type of property in this local authority is £%{soft_min_for_period}."
max:
max:
title_text:"You told us the rent is %{brent}"
title_text:"You told us the rent is %{brent}"
hint_text:"The maximum rent expected for this type of property in %{la} is £%{soft_max_for_period}."
hint_text:"The maximum rent expected for this type of property in this local authority is £%{soft_max_for_period}."
retirement:
retirement:
min:
min:
title:"You told us this person is under %{age} and retired"
title:"You told us this person is under %{age} and retired"
natdeanlewissoftwire
2 years ago
committed by
GitHub