Browse Source

Include full stops in hint text

pull/532/head
Paul Robert Lloyd 3 years ago
parent
commit
e2b36ddae5
  1. 2
      config/forms/2021_2022.json
  2. 2
      config/forms/2022_2023.json
  3. 6
      config/locales/en.yml
  4. 6
      spec/models/validations/financial_validations_spec.rb

2
config/forms/2021_2022.json

@ -4264,7 +4264,7 @@
"reasonable_preference_reason": { "reasonable_preference_reason": {
"check_answer_label": "Reason for reasonable preference", "check_answer_label": "Reason for reasonable preference",
"header": "Why was the household given ‘reasonable preference’?", "header": "Why was the household given ‘reasonable preference’?",
"hint_text": "Select all that apply", "hint_text": "Select all that apply.",
"type": "checkbox", "type": "checkbox",
"answer_options": { "answer_options": {
"rp_homeless": { "rp_homeless": {

2
config/forms/2022_2023.json

@ -4275,7 +4275,7 @@
"reasonable_preference_reason": { "reasonable_preference_reason": {
"check_answer_label": "Reason for reasonable preference", "check_answer_label": "Reason for reasonable preference",
"header": "Why was the household given ‘reasonable preference’?", "header": "Why was the household given ‘reasonable preference’?",
"hint_text": "Select all that apply", "hint_text": "Select all that apply.",
"type": "checkbox", "type": "checkbox",
"answer_options": { "answer_options": {
"rp_homeless": { "rp_homeless": {

6
config/locales/en.yml

@ -227,16 +227,16 @@ en:
soft_validations: soft_validations:
net_income: net_income:
hint_text: "<p>You told us the lead tenant’s working situation is: <strong>%{ecstat1}</strong></p><p>The household income you have entered is <strong>%{earnings}</strong></p>" hint_text: "<p>You told us the lead tenant’s working situation is: <strong>%{ecstat1}</strong>.</p><p>The household income you have entered is <strong>%{earnings}</strong>.</p>"
in_soft_min_range: in_soft_min_range:
message: "Net income is lower than expected based on the lead tenant’s working situation. Are you sure this is correct?" message: "Net income is lower than expected based on the lead tenant’s working situation. Are you sure this is correct?"
in_soft_max_range: in_soft_max_range:
message: "Net income is higher than expected based on the lead tenant’s working situation. Are you sure this is correct?" message: "Net income is higher than expected based on the lead tenant’s working situation. Are you sure this is correct?"
rent: rent:
min: min:
hint_text: "<h1 class=\"govuk-heading-l app-panel--interruption\">You told us the rent is %{brent}</h1><p>The minimum rent for this type of property in %{la} is £%{soft_min_for_period}</p>" hint_text: "<h1 class=\"govuk-heading-l app-panel--interruption\">You told us the rent is %{brent}</h1><p>The minimum rent for this type of property in %{la} is £%{soft_min_for_period}.</p>"
max: max:
hint_text: "<h1 class=\"govuk-heading-l app-panel--interruption\">You told us the rent is %{brent}</h1><p>The maximum rent for this type of property in %{la} is £%{soft_max_for_period}</p>" hint_text: "<h1 class=\"govuk-heading-l app-panel--interruption\">You told us the rent is %{brent}</h1><p>The maximum rent for this type of property in %{la} is £%{soft_max_for_period}.</p>"
devise: devise:
two_factor_authentication: two_factor_authentication:
success: "Two-factor authentication successful" success: "Two-factor authentication successful"

6
spec/models/validations/financial_validations_spec.rb

@ -47,7 +47,7 @@ RSpec.describe Validations::FinancialValidations do
expect(record.errors["benefits"]).to be_empty expect(record.errors["benefits"]).to be_empty
end end
it "validates that the tenant's partner is not in full time employment" do it "validates that the tenants partner is not in full time employment" do
record.benefits = 0 record.benefits = 0
record.ecstat2 = 0 record.ecstat2 = 0
record.relat2 = "P" record.relat2 = "P"
@ -55,7 +55,7 @@ RSpec.describe Validations::FinancialValidations do
expect(record.errors["benefits"]).to include(match I18n.t("validations.financial.benefits.part_or_full_time")) expect(record.errors["benefits"]).to include(match I18n.t("validations.financial.benefits.part_or_full_time"))
end end
it "expects that the tenant's partner is not in full-time or part-time employment" do it "expects that the tenants partner is not in full-time or part-time employment" do
record.benefits = 0 record.benefits = 0
record.ecstat2 = 4 record.ecstat2 = 4
record.relat2 = "P" record.relat2 = "P"
@ -144,7 +144,7 @@ RSpec.describe Validations::FinancialValidations do
end end
describe "net income validations" do describe "net income validations" do
it "validates that the net income is within the expected range for the tenant's employment status" do it "validates that the net income is within the expected range for the tenants employment status" do
record.earnings = 200 record.earnings = 200
record.incfreq = 1 record.incfreq = 1
record.ecstat1 = 1 record.ecstat1 = 1

Loading…
Cancel
Save